From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>, Michal Hocko <mhocko@suse.cz>,
Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 0/5] Candidate fixes for premature OOM kills with node-lru v1
Date: Wed, 20 Jul 2016 16:21:46 +0100 [thread overview]
Message-ID: <1469028111-1622-1-git-send-email-mgorman@techsingularity.net> (raw)
Both Joonsoo Kim and Minchan Kim have reported premature OOM kills on
a 32-bit platform. The common element is a zone-constrained high-order
allocation failing. Two factors appear to be at fault -- pgdat being
considered unreclaimable prematurely and insufficient rotation of the
active list.
Unfortunately to date I have been unable to reproduce this with a variety
of stress workloads on a 2G 32-bit KVM instance. It's not clear why as
the steps are similar to what was described. It means I've been unable to
determine if this series addresses the problem or not. I'm hoping they can
test and report back before these are merged to mmotm. What I have checked
is that a basic parallel DD workload completed successfully on the same
machine I used for the node-lru performance tests. I'll leave the other
tests running just in case anything interesting falls out.
The series is in three basic parts;
Patch 1 does not account for skipped pages as scanned. This avoids the pgdat
being prematurely marked unreclaimable
Patches 2-4 add per-zone stats back in. The actual stats patch is different
to Minchan's as the original patch did not account for unevictable
LRU which would corrupt counters. The second two patches remove
approximations based on pgdat statistics. It's effectively a
revert of "mm, vmstat: remove zone and node double accounting by
approximating retries" but different LRU stats are used. This
is better than a full revert or a reworking of the series as
it preserves history of why the zone stats are necessary.
If this work out, we may have to leave the double accounting in
place for now until an alternative cheap solution presents itself.
Patch 5 rotates inactive/active lists for lowmem allocations. This is also
quite different to Minchan's patch as the original patch did not
account for memcg and would rotate if *any* eligible zone needed
rotation which may rotate excessively. The new patch considers
the ratio for all eligible zones which is more in line with
node-lru in general.
include/linux/mm_inline.h | 19 ++-------------
include/linux/mmzone.h | 7 ++++++
include/linux/swap.h | 1 +
mm/compaction.c | 20 +---------------
mm/migrate.c | 2 ++
mm/page-writeback.c | 17 +++++++-------
mm/page_alloc.c | 59 ++++++++++++++++------------------------------
mm/vmscan.c | 60 ++++++++++++++++++++++++++++++++++++++++++-----
mm/vmstat.c | 6 +++++
9 files changed, 102 insertions(+), 89 deletions(-)
--
2.6.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2016-07-20 15:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 15:21 Mel Gorman [this message]
2016-07-20 15:21 ` [PATCH 1/5] mm, vmscan: Do not account skipped pages as scanned Mel Gorman
2016-07-21 5:16 ` Minchan Kim
2016-07-21 8:15 ` Mel Gorman
2016-07-21 8:31 ` Minchan Kim
2016-07-25 8:04 ` Minchan Kim
2016-07-25 9:20 ` Mel Gorman
2016-07-28 1:38 ` Minchan Kim
2016-07-20 15:21 ` [PATCH 2/5] mm: add per-zone lru list stat Mel Gorman
2016-07-21 7:10 ` Joonsoo Kim
2016-07-23 0:45 ` Fengguang Wu
2016-07-23 1:25 ` Minchan Kim
2016-07-20 15:21 ` [PATCH 3/5] mm, vmscan: Remove highmem_file_pages Mel Gorman
2016-07-20 15:21 ` [PATCH 4/5] mm: Remove reclaim and compaction retry approximations Mel Gorman
2016-07-20 15:21 ` [PATCH 5/5] mm: consider per-zone inactive ratio to deactivate Mel Gorman
2016-07-21 5:30 ` Minchan Kim
2016-07-21 8:08 ` Mel Gorman
2016-07-21 7:10 ` Joonsoo Kim
2016-07-21 8:16 ` Mel Gorman
2016-07-21 7:07 ` [PATCH 0/5] Candidate fixes for premature OOM kills with node-lru v1 Minchan Kim
2016-07-21 9:15 ` Mel Gorman
2016-07-21 7:31 ` Joonsoo Kim
2016-07-21 8:39 ` Minchan Kim
2016-07-21 9:16 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469028111-1622-1-git-send-email-mgorman@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).