From: Rik van Riel <riel@surriel.com>
To: Tony Jones <tonyj@suse.de>, Michal Hocko <mhocko@suse.cz>,
Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, hannes@cmpxchg.org,
vdavydov@virtuozzo.com, vbabka@suse.cz,
mgorman@techsingularity.net, kirill.shutemov@linux.intel.com,
bywxiaobai@163.com
Subject: Re: [PATCH 1/3] Add a new field to struct shrinker
Date: Sat, 23 Jul 2016 15:43:37 -0400 [thread overview]
Message-ID: <1469303017.30053.104.camel@surriel.com> (raw)
In-Reply-To: <8663a3c5-7b9b-c5b5-cddd-224e97171921@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]
On Fri, 2016-07-22 at 21:05 -0700, Tony Jones wrote:
> On 07/22/2016 06:27 PM, Tony Jones wrote:
> > On 07/20/2016 07:54 AM, Michal Hocko wrote:
> >
> > > > Michal, just to make sure I understand you correctly, do you
> > > > mean that we
> > > > could infer the names of the shrinkers by looking at the names
> > > > of their callbacks?
> > >
> > > Yes, %ps can then be used for the name of the shrinker structure
> > > (assuming it is available).
> >
> > This is fine for emitting via the ftrace /sys interface, but in
> > order to have the data [name] get
> > marshalled thru to perf (for example) you need to add it to the
> > TP_fast_assign entry.
> >
> > tony
>
> Unfortunately, %ps/%pF doesn't do much (re: Michal's comment
> "assuming it is available"):
>
> - TP_printk("%pF %p: nid: %d objects to shrink %ld gfp_flags %s
> pgs_scanned %ld lru_pgs %ld cache items %ld delta %lld total_scan
> %ld",
> + TP_printk("%pF %p(%ps): nid: %d objects to shrink %ld
> gfp_flags %s pgs_scanned %ld lru_pgs %ld cache items %ld delta %lld
> total_scan %ld",
> __entry->shrink,
> __entry->shr,
> + __entry->shr,
> __entry->nid,
> __entry->nr_objects_to_shrink,
>
> # cat trace_pipe
> bash-1917 [003] ...1 2925.941062: mm_shrink_slab_start:
> super_cache_scan+0x0/0x1a0 ffff88042bb60cc0(0xffff88042bb60cc0): nid:
> 0 objects to shrink 0 gfp_flags GFP_KERNEL pgs_scanned 1000 lru_pgs
> 1000 cache items 4 delta 7 total_scan 7
>
>
> Otherwise what I was suggesting was something like this to ensure it
> was correctly marshaled for perf/etc:
>
Janani,
it may make sense to have the code Tony posted be part of
your patch series. Just have both of your Signed-off-by:
lines on that patch.
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-23 19:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 8:33 [PATCH 0/3] Add names of shrinkers and have tracepoints display them Janani Ravichandran
2016-07-09 8:43 ` [PATCH 1/3] Add a new field to struct shrinker Janani Ravichandran
2016-07-11 6:37 ` Michal Hocko
2016-07-11 14:12 ` Rik van Riel
2016-07-11 14:33 ` Michal Hocko
2016-07-20 14:41 ` Janani Ravichandran
2016-07-20 14:54 ` Michal Hocko
2016-07-23 1:27 ` Tony Jones
2016-07-23 4:05 ` Tony Jones
2016-07-23 19:43 ` Rik van Riel [this message]
2016-07-23 23:21 ` Tony Jones
2016-07-26 16:40 ` Tony Jones
2016-07-28 5:49 ` Dave Chinner
2016-07-28 10:25 ` Mel Gorman
2016-07-29 0:13 ` Dave Chinner
2016-07-29 13:00 ` Mel Gorman
2016-08-12 3:09 ` Tony Jones
2016-07-09 8:52 ` [PATCH 2/3] Update name field for all shrinker instances Janani Ravichandran
2016-07-13 0:43 ` Tony Jones
2016-07-09 9:05 ` [PATCH 3/3] Add name fields in shrinker tracepoint definitions Janani Ravichandran
2016-07-09 9:45 ` kbuild test robot
2016-07-09 16:18 ` Janani Ravichandran
2016-07-11 14:18 ` Vlastimil Babka
2016-07-13 0:35 ` Tony Jones
2016-07-13 6:16 ` Janani Ravichandran
2016-07-13 19:12 ` Tony Jones
2016-07-13 19:48 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469303017.30053.104.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=bywxiaobai@163.com \
--cc=hannes@cmpxchg.org \
--cc=janani.rvchndrn@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.cz \
--cc=tonyj@suse.de \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).