Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] slub: Drop bogus inline for fixup_red_left()
@ 2016-08-03 20:31 Geert Uytterhoeven
  2016-08-03 23:47 ` David Rientjes
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2016-08-03 20:31 UTC (permalink / raw)
  To: Alexander Potapenko, Andrew Morton
  Cc: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
	linux-mm, linux-kernel, Geert Uytterhoeven

With m68k-linux-gnu-gcc-4.1:

    include/linux/slub_def.h:126: warning: a??fixup_red_lefta?? declared inline after being called
    include/linux/slub_def.h:126: warning: previous declaration of a??fixup_red_lefta?? was here

Commit c146a2b98eb5898e ("mm, kasan: account for object redzone in
SLUB's nearest_obj()") made fixup_red_left() global, but forgot to
remove the inline keyword.

Fixes: c146a2b98eb5898e ("mm, kasan: account for object redzone in SLUB's nearest_obj()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 mm/slub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 26eb6a99540e8530..850737bdfbd82410 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -124,7 +124,7 @@ static inline int kmem_cache_debug(struct kmem_cache *s)
 #endif
 }
 
-inline void *fixup_red_left(struct kmem_cache *s, void *p)
+void *fixup_red_left(struct kmem_cache *s, void *p)
 {
 	if (kmem_cache_debug(s) && s->flags & SLAB_RED_ZONE)
 		p += s->red_left_pad;
-- 
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] slub: Drop bogus inline for fixup_red_left()
  2016-08-03 20:31 [PATCH] slub: Drop bogus inline for fixup_red_left() Geert Uytterhoeven
@ 2016-08-03 23:47 ` David Rientjes
  0 siblings, 0 replies; 2+ messages in thread
From: David Rientjes @ 2016-08-03 23:47 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Alexander Potapenko, Andrew Morton, Christoph Lameter,
	Pekka Enberg, Joonsoo Kim, linux-mm, linux-kernel


[-- Attachment #1: Type: TEXT/PLAIN, Size: 652 bytes --]

On Wed, 3 Aug 2016, Geert Uytterhoeven wrote:

> With m68k-linux-gnu-gcc-4.1:
> 
>     include/linux/slub_def.h:126: warning: a??fixup_red_lefta?? declared inline after being called
>     include/linux/slub_def.h:126: warning: previous declaration of a??fixup_red_lefta?? was here
> 
> Commit c146a2b98eb5898e ("mm, kasan: account for object redzone in
> SLUB's nearest_obj()") made fixup_red_left() global, but forgot to
> remove the inline keyword.
> 
> Fixes: c146a2b98eb5898e ("mm, kasan: account for object redzone in SLUB's nearest_obj()")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: David Rientjes <rientjes@google.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 20:31 [PATCH] slub: Drop bogus inline for fixup_red_left() Geert Uytterhoeven
2016-08-03 23:47 ` David Rientjes

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git