From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0671C433F5 for ; Wed, 9 Feb 2022 16:21:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3750A6B0071; Wed, 9 Feb 2022 11:21:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 322D96B0075; Wed, 9 Feb 2022 11:21:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EADF6B0078; Wed, 9 Feb 2022 11:21:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 0F6026B0071 for ; Wed, 9 Feb 2022 11:21:32 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BDBBE18209A9D for ; Wed, 9 Feb 2022 16:21:31 +0000 (UTC) X-FDA: 79123756782.06.2E8FD24 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by imf07.hostedemail.com (Postfix) with ESMTP id 50B6F40009 for ; Wed, 9 Feb 2022 16:21:31 +0000 (UTC) Received: by mail-oo1-f46.google.com with SMTP id r15-20020a4ae5cf000000b002edba1d3349so3046604oov.3 for ; Wed, 09 Feb 2022 08:21:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=eWTUS3VqmsjwF4c8OTdfF5F0odt3UsQcGtmj9YbWaEk=; b=EIBIj1i0RF6eGofIPoMkdMlxqqoTb5r4muwHZujQjmjolPsYNoxgUKu/jT8Fu3jKkB /qytsaekGzVAdDUOk9HLhTVb5vW1puLgQSvn/tRDl2t1ebbB7Vue9+rxQEeIiYcc8KAO oSp8/xPz4a5wHhxGGDkWnXqrbZX0WI29dV4cSPUjoKv486QCfHtYEiBjzC5Em3E7KIVd c9o0+uldteFR96I3dhMGpuEfgcGB4LTR4wSzfkl0tqz3xWkFUlkEsL9Bws0D19G6SHsj qi02gEjgAm5UvcWjIkqPqFpGRuP/+8TMwuUvKw6hSsxPmc4VxhJS4XjMtIc9hQq8+lMZ 7eYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=eWTUS3VqmsjwF4c8OTdfF5F0odt3UsQcGtmj9YbWaEk=; b=iy4V11YPJBnthkp0dW9n27jcuwGY0XUoLGMdn0I00bnqKJHa/CmVDjf8zwStLdESzV PYGTj+hVIxdG9p8RFJfIn+Hv0iZf0j98Uh5w5cW+TXQE4Tmlo26Hf2JgYPF4cXPuvZ8E LIzTwqMgIPspyEz8rQEVNhS7HQrxxDDwz8dz61Fc7/+urnkNxJcsDgsuuIoGE8+YmFKm CZ0rG5VzubaEEuR1a6VxcRRKlUD7K+EILsGkAZ2egC8UV6lnpyC2v5KgWXXWjB5EG390 eqa91wpD1Oj6a5fa2olkqcmSqGTjcOma7NTib+paDHF2G3FJuopro8DQKgpB6B7YYFiJ Ys7A== X-Gm-Message-State: AOAM530hr34UD737bm4tacBvkZo21opaEI+WPHBd/Oe86LmXw9UA0eey qcJBoavQNGmDirIjlvx2R2YqZg== X-Google-Smtp-Source: ABdhPJy0j7eWBmlJVk4eLI22dh3gUmeOg6uBbExzigwzZo5sR81MUFVc0DE25/D1z6UEH3jHHDWPPw== X-Received: by 2002:a4a:1d42:: with SMTP id 63mr326326oog.80.1644423690443; Wed, 09 Feb 2022 08:21:30 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id el40sm7504405oab.22.2022.02.09.08.21.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Feb 2022 08:21:29 -0800 (PST) Date: Wed, 9 Feb 2022 08:21:17 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Michal Hocko cc: Hugh Dickins , Andrew Morton , Vlastimil Babka , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Alistair Popple , Johannes Weiner , Rik van Riel , Suren Baghdasaryan , Yu Zhao , Greg Thelen , Shakeel Butt , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/13] mm/munlock: rework of mlock+munlock page handling In-Reply-To: Message-ID: <147388c6-eb7-5c58-79a-7a8279c27fd@google.com> References: <8e4356d-9622-a7f0-b2c-f116b5f2efea@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: yhrw8sy7uhuq8m41ipckcxwjpewijk8h Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EIBIj1i0; spf=pass (imf07.hostedemail.com: domain of hughd@google.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 50B6F40009 X-HE-Tag: 1644423691-633563 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 9 Feb 2022, Michal Hocko wrote: > > So far I have only managed to read through the series and trying to put > all the pieces together (so far I have given up on the THP part) and my > undestanding is far from complete. But I have to say I like the general > approach and overall simplification. Many thanks for looking, Michal, and for all the positivity! > > The only thing that is not entirely clear to me at the moment is why you > have chosen to ignore already mapped LOCKONFAULT pages. They will > eventually get sorted out during the reclaim/migration but this can > backfire if too many pages have been pre-faulted before LOCKONFAULT > call. Maybe not an interesting case in the first place but I am still > wondering why you have chosen that way. I'm puzzled: what makes you think I'm ignoring already mapped LOCKONFAULT pages? I'd consider that a bug. It is the case, isn't it, that a VM_LOCKONFAULT area always has VM_LOCKED set too? If I've got that wrong, yes, I'll need to revisit conditions. > > I will be off next couple of days and plan to revisit this afterwards > (should time allow). Anyway thanks a lot Hugh! > -- > Michal Hocko > SUSE Labs