From: Joe Perches <joe@perches.com>
To: Michal Hocko <mhocko@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
marcelo.leitner@gmail.com
Subject: Re: [PATCH 0/6 v3] kvmalloc
Date: Thu, 26 Jan 2017 04:14:37 -0800 [thread overview]
Message-ID: <1485432877.12563.100.camel@perches.com> (raw)
In-Reply-To: <20170126103216.GG6590@dhcp22.suse.cz>
On Thu, 2017-01-26 at 11:32 +0100, Michal Hocko wrote:
> So I have folded the following to the patch 1. It is in line with
> kvmalloc and hopefully at least tell more than the current code.
[]
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
[]
> @@ -1741,6 +1741,13 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align,
> * Allocate enough pages to cover @size from the page level
> * allocator with @gfp_mask flags. Map them into contiguous
> * kernel virtual space, using a pagetable protection of @prot.
> + *
> + * Reclaim modifiers in @gfp_mask - __GFP_NORETRY, __GFP_REPEAT
> + * and __GFP_NOFAIL are not supported
Maybe add a BUILD_BUG or a WARN_ON_ONCE to catch new occurrences?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-01-26 12:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 18:14 [PATCH 0/6 v3] kvmalloc Alexei Starovoitov
2017-01-25 20:16 ` Daniel Borkmann
2017-01-26 7:43 ` Michal Hocko
2017-01-26 9:36 ` Daniel Borkmann
2017-01-26 9:48 ` David Laight
2017-01-26 10:08 ` Michal Hocko
2017-01-26 10:32 ` Michal Hocko
2017-01-26 11:04 ` Daniel Borkmann
2017-01-26 11:49 ` Michal Hocko
2017-01-26 12:14 ` Joe Perches [this message]
2017-01-26 12:27 ` Michal Hocko
2017-01-26 11:33 ` Daniel Borkmann
2017-01-26 11:58 ` Michal Hocko
2017-01-26 13:10 ` Daniel Borkmann
2017-01-26 13:40 ` Michal Hocko
2017-01-26 14:13 ` Michal Hocko
2017-01-26 14:37 ` [PATCH] net, bpf: use kvzalloc helper kbuild test robot
2017-01-26 14:58 ` kbuild test robot
2017-01-26 20:34 ` [PATCH 0/6 v3] kvmalloc Daniel Borkmann
2017-01-27 10:05 ` Michal Hocko
2017-01-27 20:12 ` Daniel Borkmann
2017-01-30 7:56 ` Michal Hocko
2017-01-30 16:15 ` Daniel Borkmann
2017-01-30 16:28 ` Michal Hocko
2017-01-30 16:45 ` Daniel Borkmann
-- strict thread matches above, loose matches on Subject: below --
2017-01-30 9:49 Michal Hocko
2017-02-05 10:23 ` Michal Hocko
2017-01-12 15:37 Michal Hocko
2017-01-24 15:17 ` Michal Hocko
2017-01-24 16:00 ` Eric Dumazet
2017-01-25 13:10 ` Michal Hocko
2017-01-24 19:17 ` Alexei Starovoitov
2017-01-25 13:10 ` Michal Hocko
2017-01-25 13:21 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485432877.12563.100.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcelo.leitner@gmail.com \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).