From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10878C47082 for ; Mon, 7 Jun 2021 08:09:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B4E20610A1 for ; Mon, 7 Jun 2021 08:09:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4E20610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4DD896B006C; Mon, 7 Jun 2021 04:09:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48DFE6B006E; Mon, 7 Jun 2021 04:09:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 308286B0070; Mon, 7 Jun 2021 04:09:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 009976B006C for ; Mon, 7 Jun 2021 04:09:06 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8F8A2BBDE for ; Mon, 7 Jun 2021 08:09:06 +0000 (UTC) X-FDA: 78226202292.15.DBD4C1B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 5180AA000252 for ; Mon, 7 Jun 2021 08:09:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623053345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3QjcZXjWMK0kRErypw6axOjNEeFt7y49TjRKf9dcPRU=; b=hpYK6Puat09ZHFUqwv9GE+K6zt8hnPxLHe4FicG1unqzYfuZnahQOKp+8bHcfdYTrufv7S wSX1dbVgwAXIxb9iB7E9BWYV7YRXY4P/JDnynpkYRVSuTn1K2nOegEMzl3RwbmRLrRC61g K41RWdpl/nmAptBsc6hv5G6iHIcoxnU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-Fm64375tNRy2lTGkgps4Dw-1; Mon, 07 Jun 2021 04:09:02 -0400 X-MC-Unique: Fm64375tNRy2lTGkgps4Dw-1 Received: by mail-wm1-f69.google.com with SMTP id u17-20020a05600c19d1b02901af4c4deac5so849856wmq.7 for ; Mon, 07 Jun 2021 01:09:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=3QjcZXjWMK0kRErypw6axOjNEeFt7y49TjRKf9dcPRU=; b=DnM1QQswQ5SOM+WnKa52HH4Vlas8YbbCbcgxpG25tER4looKVPMIqiEmEJY1fARUd3 St4wgrcm1EI5sCzmtPREonucbF9icL3D3hVGNpoC4rWQt5QQhtr8tCAR9wh1nfCIOWNu kt13j/x05Rvh5bGEmd/alAduH7NclLhDym80MDlaaB8K6SHHDgmFOO2H0Zw4iT6pKJcJ GYbHGhNNVDGfsTeu41qTZZSRmGYGqb6G4y5kv6mp8lW5ltnGryaCF4wFc6i0DuyvLVoT 3cQQqNJ6dgTfx57KVSkpNHpk7DkjTn/O76uBf9cJIfckPiMURHzcVyDd+QXIHMr4nVos EeJQ== X-Gm-Message-State: AOAM531kGQuSLhtK3+jyioIQeDYXS8sbkUSeUbN9pgNCr8bXILgg6wqx oi+WM9Xhp4jMvCyMLa+tBYN7HdH0s8KqpG3EFg5XSd5Wt+35ICQC8vIj1wsKVSrIUJpeMLm49Ad E+yRmLbUrMbI= X-Received: by 2002:adf:ee50:: with SMTP id w16mr15621565wro.187.1623053341271; Mon, 07 Jun 2021 01:09:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFWqd+iQBPCe+bHMRZ3V9csrG0lRr6RZgXwXPgDK/h9+cxKbQWeldRF6cskZQdJlqB7yCmIQ== X-Received: by 2002:adf:ee50:: with SMTP id w16mr15621527wro.187.1623053340959; Mon, 07 Jun 2021 01:09:00 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6188.dip0.t-ipconnect.de. [91.12.97.136]) by smtp.gmail.com with ESMTPSA id u14sm16181358wmc.41.2021.06.07.01.08.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 01:09:00 -0700 (PDT) Subject: Re: [PATCH v1] memory-hotplug.rst: complete admin-guide overhaul To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Mike Kravetz , Mike Rapoport , Dave Hansen , Matthew Wilcox , Anshuman Khandual , Muchun Song , Pavel Tatashin , Jonathan Corbet , Stephen Rothwell , linux-doc@vger.kernel.org References: <20210525102604.8770-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat Message-ID: <14b018b0-aa19-7d00-2861-50d0e5e2bea8@redhat.com> Date: Mon, 7 Jun 2021 10:08:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5180AA000252 Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hpYK6Pua; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf15.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: 7yb1wc5w8fo7bzpqy5or5frchwfyqr3x X-HE-Tag: 1623053344-570619 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.06.21 09:51, Michal Hocko wrote: > [Sorry this somehow slipped through cracks] > > On Tue 25-05-21 12:26:04, David Hildenbrand wrote: >> The memory hot(un)plug documentation is outdated and incomplete. Most of >> the content dates back to 2007, so it's time for a major overhaul. >> >> Let's rewrite, reorganize and update most parts of the documentation. In >> addition to memory hot(un)plug, also add some details regarding >> ZONE_MOVABLE, with memory hotunplug being one of its main consumers. >> >> The style of the document is also properly fixed that e.g., "restview" >> renders it cleanly now. >> >> In the future, we might add some more details about virt users like >> virtio-mem, the XEN balloon, the Hyper-V balloon and ppc64 dlpar. > > I haven't really checked the diff but rather looked at the final > outcome. I have to say I like it a lot. Some places are going a bit too > technical for an admin-guide but they are in minority (e.g. locking or > altmap reference). If somebody feels strong then this could get into its > own file but I wouldn't lose sleep over that. I just realized that "Locking Internals" is still a duplicate with core-api/memory-hotplug.rst I thought this (merge issue) was fixed long ago. I'll just remove it from this file, making sure core-api/memory-hotplug.rst is up-to-date > > I would make one thing slightly more explicit though > diff --git a/Documentation/admin-guide/mm/memory-hotplug.rst b/Documentation/admin-guide/mm/memory-hotplug.rst > index c95f5c2b30dd..5b462aba89cc 100644 > --- a/Documentation/admin-guide/mm/memory-hotplug.rst > +++ b/Documentation/admin-guide/mm/memory-hotplug.rst > @@ -568,6 +568,10 @@ Even with ZONE_MOVABLE, there are some corner cases where offlining a memory > Further, when running into out of memory situations while migrating pages, or > when still encountering permanently unmovable pages within ZONE_MOVABLE > (-> BUG), memory offlining will keep retrying until it eventually succeeds. > +The offlining context can be terminated by a fatal signal. A timeout based > +offlining can be easily implemented by > + > + % timeout $TIMEOUT offline_block | failure_handling > > Locking Internals > ================= > > > In the future I would find some examples of a failure cases we have seen > so far. E.g. offlining failure with dump_page example. Thanks, I'll pick up your change and see if I can get rid of some low-level stuff. I'll address Mike's review shortly and resend. -- Thanks, David / dhildenb