From: Zhaoyang Huang <huangzhaoyang@gmail.com>
To: zhaoyang.huang@spreadtrum.com,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Ingo Molnar <mingo@kernel.org>,
zijun_hu <zijun_hu@htc.com>, Vlastimil Babka <vbabka@suse.cz>,
Thomas Garnier <thgarnie@google.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zijun_hu@zoho.com
Subject: [PATCH v4] mm/vmalloc: terminate searching since one node found
Date: Thu, 20 Jul 2017 17:24:16 +0800 [thread overview]
Message-ID: <1500542656-23332-1-git-send-email-zhaoyang.huang@spreadtrum.com> (raw)
It is no need to find the very beginning of the area within
alloc_vmap_area, which can be done by judging each node during the process
free_vmap_cache miss:
vmap_area_root
/ \
tmp_next U
/ (T1)
tmp
/
... (T2)
/
first
vmap_area_list->first->......->tmp->tmp_next->...->vmap_area_list
|-----(T3)----|
Under the scenario of free_vmap_cache miss, total time consumption of finding
the suitable hole is T = T1 + T2 + T3, while the commit decrease it to T1.
In fact, 'vmalloc' always start from the fix address(VMALLOC_START),which will
cause the 'first' to be close to the begining of the list(vmap_area_list) and
make T3 to be big.
The commit will especially help for a large and almost full vmalloc area.
Whearas, it would NOT affect current quick approach such as free_vmap_cache, for
it just take effect when free_vmap_cache miss and will reestablish it laterly.
Signed-off-by: Zhaoyang Huang <zhaoyang.huang@spreadtrum.com>
---
mm/vmalloc.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 8698c1c..f58f445 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -471,9 +471,20 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
while (n) {
struct vmap_area *tmp;
+ struct vmap_area *tmp_next;
tmp = rb_entry(n, struct vmap_area, rb_node);
+ tmp_next = list_next_entry(tmp, list);
if (tmp->va_end >= addr) {
first = tmp;
+ if (ALIGN(tmp->va_end, align) + size
+ < tmp_next->va_start) {
+ /*
+ * free_vmap_cache miss now,don't
+ * update cached_hole_size here,
+ * as __free_vmap_area does
+ */
+ goto found;
+ }
if (tmp->va_start <= addr)
break;
n = n->rb_left;
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-07-20 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 9:24 Zhaoyang Huang [this message]
2017-07-24 2:07 ` [lkp-robot] [mm/vmalloc] dec0553d31: WARNING:at_mm/vmalloc.c:#vmap_page_range_noflush kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500542656-23332-1-git-send-email-zhaoyang.huang@spreadtrum.com \
--to=huangzhaoyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=thgarnie@google.com \
--cc=vbabka@suse.cz \
--cc=zhaoyang.huang@spreadtrum.com \
--cc=zijun_hu@htc.com \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).