From: Yisheng Xie <xieyisheng1@huawei.com>
To: akpm@linux-foundation.org, vbabka@suse.cz, mhocko@suse.com,
mingo@kernel.org, rientjes@google.com, n-horiguchi@ah.jp.nec.com,
salls@cs.ucsb.edu
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
tanxiaojun@huawei.com, linux-api@vger.kernel.org
Subject: [PATCH RFC v2 4/4] mm/mempolicy: add nodes_empty check in SYSC_migrate_pages
Date: Fri, 27 Oct 2017 18:14:25 +0800 [thread overview]
Message-ID: <1509099265-30868-5-git-send-email-xieyisheng1@huawei.com> (raw)
In-Reply-To: <1509099265-30868-1-git-send-email-xieyisheng1@huawei.com>
As manpage of migrate_pages, the errno should be set to EINVAL when none
of the specified nodes contain memory. However, when new_nodes is null,
i.e. the specified nodes also do not have memory, as the following case:
new_nodes = 0;
old_nodes = 0xf;
ret = migrate_pages(pid, old_nodes, new_nodes, MAX);
The ret will be 0 and no errno is set.
This patch is to add nodes_empty check to fix above case.
Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
---
mm/mempolicy.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 8798ecb..58352cc 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1402,6 +1402,11 @@ static int copy_nodes_to_user(unsigned long __user *mask, unsigned long maxnode,
if (err)
goto out;
+ if (nodes_empty(*new)) {
+ err = -EINVAL;
+ goto out;
+ }
+
/* Find the mm_struct */
rcu_read_lock();
task = pid ? find_task_by_vpid(pid) : current;
--
1.7.12.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-27 10:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 10:14 [PATCH RFC v2 0/4] some fixes and clean up for mempolicy Yisheng Xie
2017-10-27 10:14 ` [PATCH RFC v2 1/4] mm/mempolicy: Fix get_nodes() mask miscalculation Yisheng Xie
2017-10-31 8:34 ` Vlastimil Babka
2017-11-01 9:37 ` Yisheng Xie
2017-10-27 10:14 ` [PATCH RFC v2 2/4] mm/mempolicy: remove redundant check in get_nodes Yisheng Xie
2017-10-31 8:55 ` Vlastimil Babka
2017-10-27 10:14 ` [PATCH RFC v2 3/4] mm/mempolicy: fix the check of nodemask from user Yisheng Xie
2017-10-31 9:30 ` Vlastimil Babka
2017-10-31 11:01 ` Yisheng Xie
2017-10-31 11:28 ` Vlastimil Babka
2017-10-27 10:14 ` Yisheng Xie [this message]
2017-10-31 9:46 ` [PATCH RFC v2 4/4] mm/mempolicy: add nodes_empty check in SYSC_migrate_pages Vlastimil Babka
2017-11-06 1:31 ` Yisheng Xie
2017-11-06 7:39 ` Vlastimil Babka
2017-11-06 15:29 ` Christopher Lameter
2017-11-07 11:23 ` Yisheng Xie
2017-11-07 14:54 ` Christopher Lameter
2017-11-07 15:05 ` Vlastimil Babka
2017-11-07 15:55 ` Christopher Lameter
2017-11-08 1:38 ` Yisheng Xie
2017-11-08 15:02 ` Christopher Lameter
2017-11-09 10:54 ` Yisheng Xie
2017-11-09 15:46 ` Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509099265-30868-5-git-send-email-xieyisheng1@huawei.com \
--to=xieyisheng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=salls@cs.ucsb.edu \
--cc=tanxiaojun@huawei.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).