From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B977C432C0 for ; Mon, 25 Nov 2019 16:38:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B96AB2068E for ; Mon, 25 Nov 2019 16:38:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="EvwQUkVG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B96AB2068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xenosoft.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6183C6B05D9; Mon, 25 Nov 2019 11:38:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A1796B05DB; Mon, 25 Nov 2019 11:38:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46A206B05DD; Mon, 25 Nov 2019 11:38:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 2DFED6B05D9 for ; Mon, 25 Nov 2019 11:38:46 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id D73E4180AD81C for ; Mon, 25 Nov 2019 16:38:45 +0000 (UTC) X-FDA: 76195358610.17.pest84_86a123c2f0921 X-HE-Tag: pest84_86a123c2f0921 X-Filterd-Recvd-Size: 6004 Received: from mo4-p02-ob.smtp.rzone.de (mo4-p02-ob.smtp.rzone.de [85.215.255.84]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Nov 2019 16:38:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1574699923; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=gq/GyN0XSt4ZyXeob4dkH3Ai2PFxE9jquzF6wyzI+SE=; b=EvwQUkVGEHdkUW01kO7bTXoBR6K2I8yK7ty+3YhFnl/MAZn/l7BiKXCu6yMyTjHVf0 Jz4WpU99pdRPWxQXvXh4L/2JQstcEE6U6hx1/SBC8waX60/4dJHrhAGZBttApgHO7Ipk MHT5fHjOTgoCAOUx/GCXdWDBoew/HtNzANzpYuVmHXe/eI1AdIz2gtXuCYcBrdhQExav 3eL5XBDrZ1KXZYu5DFii3oI3/No+M9vOwgLRuhHzR2wLQl9axutEVSvyZ0k9l4rs8gSc y3Ufyc15Y0hJM1wPBw9WemaTEy+TeP8Kc08mrw335rZbIkBG5eRz3JfSjRfBtk1+OkZh gokw== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5DdBJSrwuuqxvPhXJixqXRlXNgnQNtnHeat+VHo=" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:89c0:ebfc:40cb:202:5c2:453d] by smtp.strato.de (RZmta 45.0.2 AUTH) with ESMTPSA id x0678cvAPGcX2cB (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 25 Nov 2019 17:38:33 +0100 (CET) Subject: Re: Bug 205201 - Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M To: Mike Rapoport , Christoph Hellwig Cc: Robin Murphy , linux-arch@vger.kernel.org, darren@stevens-zone.net, mad skateman , Benjamin Herrenschmidt , linux-kernel@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rob Herring , paulus@samba.org, rtd2@xtra.co.nz, "contact@a-eon.com" , linuxppc-dev , nsaenzjulienne@suse.de References: <20191121072943.GA24024@lst.de> <6eec5c42-019c-a988-fc2a-cb804194683d@xenosoft.de> <20191121180226.GA3852@lst.de> <2fde79cf-875f-94e6-4a1b-f73ebb2e2c32@xenosoft.de> <20191125073923.GA30168@lst.de> <20191125093159.GA23118@linux.ibm.com> From: Christian Zigotzky Message-ID: <1521ec47-f358-0304-da23-313e6bebb66d@xenosoft.de> Date: Mon, 25 Nov 2019 17:38:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191125093159.GA23118@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: de-DE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25 November 2019 at 10:32 am, Mike Rapoport wrote: > On Mon, Nov 25, 2019 at 08:39:23AM +0100, Christoph Hellwig wrote: >> On Sat, Nov 23, 2019 at 12:42:27PM +0100, Christian Zigotzky wrote: >>> Hello Christoph, >>> >>> Please find attached the dmesg of your Git kernel. >> Thanks. It looks like on your platform the swiotlb buffer isn't >> actually addressable based on the bus dma mask limit, which is rather >> interesting. swiotlb_init uses memblock_alloc_low to allocate the >> buffer, and I'll need some help from Mike and the powerpc maintainers >> to figure out how that select where to allocate the buffer from, and >> how we can move it to a lower address. My gut feeling would be to try >> to do what arm64 does and define a new ARCH_LOW_ADDRESS_LIMIT, preferably >> without needing too much arch specific magic. > Presuming the problem is relevant for all CoreNet boards something like > this could work: > > diff --git a/arch/powerpc/include/asm/dma.h b/arch/powerpc/include/asm/dma.h > index 1b4f0254868f..7c6cfeeaff52 100644 > --- a/arch/powerpc/include/asm/dma.h > +++ b/arch/powerpc/include/asm/dma.h > @@ -347,5 +347,11 @@ extern int isa_dma_bridge_buggy; > #define isa_dma_bridge_buggy (0) > #endif > > +#ifdef CONFIG_CORENET_GENERIC > +extern phys_addr_t ppc_dma_phys_limit; > +#define ARCH_LOW_ADDRESS_LIMIT (ppc_dma_phys_limit - 1) > +#endif > + > + > #endif /* __KERNEL__ */ > #endif /* _ASM_POWERPC_DMA_H */ > diff --git a/arch/powerpc/platforms/85xx/common.c b/arch/powerpc/platforms/85xx/common.c > index fe0606439b5a..346b436b6d3f 100644 > --- a/arch/powerpc/platforms/85xx/common.c > +++ b/arch/powerpc/platforms/85xx/common.c > @@ -126,3 +126,7 @@ void __init mpc85xx_qe_par_io_init(void) > } > } > #endif > + > +#ifdef CONFIG_CORENET_GENERIC > +phys_addr_t ppc_dma_phys_limit = 0xffffffffUL; > +#endif > diff --git a/arch/powerpc/platforms/85xx/corenet_generic.c b/arch/powerpc/platforms/85xx/corenet_generic.c > index 7ee2c6628f64..673bcbdc7c75 100644 > --- a/arch/powerpc/platforms/85xx/corenet_generic.c > +++ b/arch/powerpc/platforms/85xx/corenet_generic.c > @@ -64,7 +64,7 @@ void __init corenet_gen_setup_arch(void) > mpc85xx_smp_init(); > > swiotlb_detect_4g(); > - > + ppc_dma_phys_limit = 0x0fffffffUL; > pr_info("%s board\n", ppc_md.name); > > mpc85xx_qe_init(); > >> As a quick hack can you try this patch on top of the tree from Friday? >> >> diff --git a/include/linux/memblock.h b/include/linux/memblock.h >> index f491690d54c6..e3f95c362922 100644 >> --- a/include/linux/memblock.h >> +++ b/include/linux/memblock.h >> @@ -344,7 +344,7 @@ static inline int memblock_get_region_node(const struct memblock_region *r) >> #define MEMBLOCK_LOW_LIMIT 0 >> >> #ifndef ARCH_LOW_ADDRESS_LIMIT >> -#define ARCH_LOW_ADDRESS_LIMIT 0xffffffffUL >> +#define ARCH_LOW_ADDRESS_LIMIT 0x0fffffffUL >> #endif >> >> phys_addr_t memblock_phys_alloc_range(phys_addr_t size, phys_addr_t align, Hello Mike, Many thanks for your patch! I will test it tomorrow. Cheers, Christian