From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> To: kasan-dev@googlegroups.com Cc: linux-mm@kvack.org, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, Alexander Potapenko <glider@google.com>, Andrey Konovalov <adech.fo@gmail.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Christoph Lameter <cl@linux.com>, David Rientjes <rientjes@google.com>, Dmitry Chernenkov <dmitryc@google.com>, Dmitry Vyukov <dvyukov@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Konstantin Serebryany <kcc@google.com>, Pekka Enberg <penberg@kernel.org>, Steven Rostedt <rostedt@goodmis.org> Subject: [PATCH] kasan: record timestamp of memory allocation/free Date: Wed, 2 May 2018 19:58:09 +0900 Message-ID: <1525258689-3430-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> (raw) syzbot is reporting many refcount/use-after-free bugs along with flood of memory allocation fault injection messages. Showing timestamp of memory allocation/free would help narrowing down kernel messages to examine. Revive timestamp field which was removed by commit cd11016e5f5212c1 ("mm, kasan: stackdepot implementation. Enable stackdepot for SLAB"). Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: Alexander Potapenko <glider@google.com> Cc: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Christoph Lameter <cl@linux.com> Cc: Pekka Enberg <penberg@kernel.org> Cc: David Rientjes <rientjes@google.com> Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Andrey Konovalov <adech.fo@gmail.com> Cc: Dmitry Vyukov <dvyukov@google.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Konstantin Serebryany <kcc@google.com> Cc: Dmitry Chernenkov <dmitryc@google.com> --- mm/kasan/kasan.c | 1 + mm/kasan/kasan.h | 1 + mm/kasan/report.c | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c index 135ce28..a336834 100644 --- a/mm/kasan/kasan.c +++ b/mm/kasan/kasan.c @@ -457,6 +457,7 @@ static inline depot_stack_handle_t save_stack(gfp_t flags) static inline void set_track(struct kasan_track *track, gfp_t flags) { track->pid = current->pid; + track->when = jiffies; track->stack = save_stack(flags); } diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h index c12dcfd..0e4951b 100644 --- a/mm/kasan/kasan.h +++ b/mm/kasan/kasan.h @@ -77,6 +77,7 @@ struct kasan_global { struct kasan_track { u32 pid; depot_stack_handle_t stack; + unsigned long when; }; struct kasan_alloc_meta { diff --git a/mm/kasan/report.c b/mm/kasan/report.c index 5c169aa..062c8ae 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -183,7 +183,8 @@ static void kasan_end_report(unsigned long *flags) static void print_track(struct kasan_track *track, const char *prefix) { - pr_err("%s by task %u:\n", prefix, track->pid); + pr_err("%s by task %u (%lu jiffies ago):\n", prefix, track->pid, + jiffies - track->when); if (track->stack) { struct stack_trace trace; -- 1.8.3.1
next reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-02 10:58 Tetsuo Handa [this message] 2018-05-02 11:12 ` Dmitry Vyukov 2018-05-02 11:13 ` Dmitry Vyukov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1525258689-3430-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp \ --to=penguin-kernel@i-love.sakura.ne.jp \ --cc=adech.fo@gmail.com \ --cc=aryabinin@virtuozzo.com \ --cc=cl@linux.com \ --cc=dmitryc@google.com \ --cc=dvyukov@google.com \ --cc=glider@google.com \ --cc=iamjoonsoo.kim@lge.com \ --cc=kasan-dev@googlegroups.com \ --cc=kcc@google.com \ --cc=linux-mm@kvack.org \ --cc=penberg@kernel.org \ --cc=rientjes@google.com \ --cc=rostedt@goodmis.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \ linux-mm@kvack.org public-inbox-index linux-mm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kvack.linux-mm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git