* [PATCH] mm: Remove useless check in pagecache_get_page()
@ 2018-12-07 15:46 Kirill Tkhai
2018-12-07 17:04 ` Kirill Gorkunov
0 siblings, 1 reply; 2+ messages in thread
From: Kirill Tkhai @ 2018-12-07 15:46 UTC (permalink / raw)
To: akpm, gorcunov, ktkhai, linux-mm, linux-kernel
page always is not NULL, so we may remove this useless check.
Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
---
mm/filemap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index b1165a311a1f..5da9ce090898 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1601,7 +1601,7 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t offset,
VM_BUG_ON_PAGE(page->index != offset, page);
}
- if (page && (fgp_flags & FGP_ACCESSED))
+ if (fgp_flags & FGP_ACCESSED)
mark_page_accessed(page);
no_page:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: Remove useless check in pagecache_get_page()
2018-12-07 15:46 [PATCH] mm: Remove useless check in pagecache_get_page() Kirill Tkhai
@ 2018-12-07 17:04 ` Kirill Gorkunov
0 siblings, 0 replies; 2+ messages in thread
From: Kirill Gorkunov @ 2018-12-07 17:04 UTC (permalink / raw)
To: Kirill Tkhai; +Cc: akpm, linux-mm, linux-kernel
On Fri, Dec 07, 2018 at 06:46:24PM +0300, Kirill Tkhai wrote:
> page always is not NULL, so we may remove this useless check.
>
> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-07 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-07 15:46 [PATCH] mm: Remove useless check in pagecache_get_page() Kirill Tkhai
2018-12-07 17:04 ` Kirill Gorkunov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).