From: Oscar Salvador <osalvador@suse.de>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, david@redhat.com,
pasha.tatashin@soleen.com, dan.j.williams@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely
Date: Wed, 12 Dec 2018 07:16:27 +0100 [thread overview]
Message-ID: <1544595387.3125.2.camel@suse.de> (raw)
In-Reply-To: <20181212033506.tyj747b7kzyvsp4c@master>
On Wed, 2018-12-12 at 03:35 +0000, Wei Yang wrote:
> I see the above code is wrapped with CONFIG_DEBUG_VM on current Linus
> tree.
> This is removed by someone else?
Yes, e8abbd69957288 ("mm, memory_hotplug: be more verbose for memory
offline failures") got rid of the CONFIG_DEBUG_VM.
This commit is sitting in the -mmotm tree.
>
> > - put_page(page);
> > - /* Because we don't have big zone->lock.
> > we should
> > - check this again here. */
> > - if (page_count(page)) {
> > - not_managed++;
> > - ret = -EBUSY;
> > - break;
> > - }
> > }
> > + put_page(page);
> > }
> > if (!list_empty(&source)) {
> > - if (not_managed) {
> > - putback_movable_pages(&source);
> > - goto out;
> > - }
> > -
> > /* Allocate a new page from the nearest neighbor node
> > */
> > ret = migrate_pages(&source, new_node_page, NULL, 0,
> > MIGRATE_SYNC,
> > MR_MEMORY_HOTPLUG);
> > @@ -1426,7 +1412,7 @@ do_migrate_range(unsigned long start_pfn,
> > unsigned long end_pfn)
> > putback_movable_pages(&source);
> > }
> > }
> > -out:
> > +
> > return ret;
> > }
> >
> > --
> > 2.13.7
>
>
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-12-12 6:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 13:53 [PATCH v2] mm, memory_hotplug: Don't bail out in do_migrate_range prematurely Oscar Salvador
2018-12-12 0:57 ` Wei Yang
2018-12-12 3:35 ` Wei Yang
2018-12-12 6:16 ` Oscar Salvador [this message]
2018-12-13 3:35 ` Wei Yang
2018-12-13 8:48 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544595387.3125.2.camel@suse.de \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@gmail.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).