From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD707C4320A for ; Tue, 27 Jul 2021 03:32:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A88F61077 for ; Tue, 27 Jul 2021 03:32:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A88F61077 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3CCAD6B0036; Mon, 26 Jul 2021 23:32:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37D306B005D; Mon, 26 Jul 2021 23:32:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26B506B006C; Mon, 26 Jul 2021 23:32:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id 09CAC6B0036 for ; Mon, 26 Jul 2021 23:32:45 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 88D5A20427 for ; Tue, 27 Jul 2021 03:32:44 +0000 (UTC) X-FDA: 78406945848.26.721E779 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf29.hostedemail.com (Postfix) with ESMTP id D99749008031 for ; Tue, 27 Jul 2021 03:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=Z5OTHAoZBoL/SIl2ruEQOeyRsTlnOUVPwpimgyS/uS8=; b=OKHmk2zQ+VU1/UmXqMg+XTROia eCdPlEg03Z42i9H1TINqbUMFUo0zG3Nma0I2Rv5B0ifctio5yE7P/9ncedSMUbW8/jtrZwe+qJZd6 0k+ajWQY71ticFXRcEXl8EbThQY2GxKLLOd1ramA2skbs/trFBklvKOjSrKxiURl2ljGfgti81tvT ISly06NfPvXfPY6oo26nXXdwyB+3esFPaqZ3qvDMr+kHGGLhf0A+aVxdT2DLozInlhZlfzw+9bDnS qJjUFB7Nyni5NmLzCvstoY/QD0JWrOkK/wB95lx8Ca/8zI5Zu/bFIqdOkiJAei8v7+oEM628yyTUc NQR2fQuA==; Received: from [2601:1c0:6280:3f0::aefb] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8Dpe-00D0NX-GD; Tue, 27 Jul 2021 03:32:38 +0000 Subject: Re: mmotm 2021-07-23-15-03 uploaded (mm/memory_hotplug.c) To: David Hildenbrand , akpm@linux-foundation.org, broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au References: <20210723220400.w5iKInKaC%akpm@linux-foundation.org> <5966f6a2-bdba-3a54-c6cb-d21aaeb8f534@infradead.org> <5394da5e-29f0-ff7d-e614-e2805400a8bb@redhat.com> From: Randy Dunlap Message-ID: <1549416a-05aa-108b-ec95-cac9d84febd1@infradead.org> Date: Mon, 26 Jul 2021 20:32:37 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <5394da5e-29f0-ff7d-e614-e2805400a8bb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D99749008031 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=OKHmk2zQ; dmarc=none; spf=none (imf29.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org X-Stat-Signature: 6aadayogf7k16dnxgcz96bq1w1qam1kt X-HE-Tag: 1627356763-526150 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/26/21 12:14 AM, David Hildenbrand wrote: > On 24.07.21 20:49, Randy Dunlap wrote: >> On 7/23/21 3:04 PM, akpm@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2021-07-23-15-03 has been uploaded to >>> >>> =C2=A0=C2=A0=C2=A0 https://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.txt says >>> >>> README for mm-of-the-moment: >>> >>> https://www.ozlabs.org/~akpm/mmotm/ >>> >>> This is a snapshot of my -mm patch queue.=C2=A0 Uploaded at random ho= pefully >>> more than once a week. >>> >>> You will need quilt to apply these patches to the latest Linus releas= e (5.x >>> or 5.x-rcY).=C2=A0 The series file is in broken-out.tar.gz and is dup= licated in >>> https://ozlabs.org/~akpm/mmotm/series >>> >>> The file broken-out.tar.gz contains two datestamp files: .DATE and >>> .DATE-yyyy-mm-dd-hh-mm-ss.=C2=A0 Both contain the string yyyy-mm-dd-h= h-mm-ss, >>> followed by the base kernel version against which this patch series i= s to >>> be applied. >>> >> >> on x86_64: >> # CONFIG_CMA is not set >> >> mm-memory_hotplug-memory-group-aware-auto-movable-online-policy.patch >> >> >> >> ../mm/memory_hotplug.c: In function =E2=80=98auto_movable_stats_accoun= t_zone=E2=80=99: >> ../mm/memory_hotplug.c:748:33: error: =E2=80=98struct zone=E2=80=99 ha= s no member named =E2=80=98cma_pages=E2=80=99; did you mean =E2=80=98mana= ged_pages=E2=80=99? >> =C2=A0=C2=A0=C2=A0 stats->movable_pages +=3D zone->cma_pages; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~~~~ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 managed_pages >> ../mm/memory_hotplug.c:750:38: error: =E2=80=98struct zone=E2=80=99 ha= s no member named =E2=80=98cma_pages=E2=80=99; did you mean =E2=80=98mana= ged_pages=E2=80=99? >> =C2=A0=C2=A0=C2=A0 stats->kernel_early_pages -=3D zone->cma_pages; >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 ^~~~~~~~~ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 managed_pages >> >> >=20 > Thanks Randy, the following on top should make it fly: >=20 > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index bfdaa28eb86f..fa1a0afd32ba 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -741,13 +741,15 @@ static void auto_movable_stats_account_zone(struc= t auto_movable_stats *stats, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (zone_idx(zone) =3D=3D ZO= NE_MOVABLE) { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 stats->movable_pages +=3D zone->present_pages; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } else { > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 stats->kernel_early_pages +=3D zone->present_early_pages; > +#ifdef CONFIG_CMA > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 /* > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 * CMA pages (never on hotplugged memory) behave = like > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 * ZONE_MOVABLE. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 */ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 stats->movable_pages +=3D zone->cma_pages; > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 stats->kernel_early_pages +=3D zone->present_early_pages; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 stats->kernel_early_pages -=3D zone->cma_pages; > +#endif /* CONFIG_CMA */ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } > =C2=A0} > =C2=A0struct auto_movable_group_stats { >=20 >=20 Acked-by: Randy Dunlap # build-tested Thanks. --=20 ~Randy