From: Guenter Roeck <linux@roeck-us.net> To: Andrew Morton <akpm@linux-foundation.org> Cc: linux-mm@kvack.org, Stephen Rothwell <sfr@canb.auug.org.au>, Robin Murphy <robin.murphy@arm.com>, linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net> Subject: [PATCH -next] mm: Mark undo_dev_pagemap as __maybe_unused Date: Tue, 2 Jul 2019 06:02:03 -0700 Message-ID: <1562072523-22311-1-git-send-email-linux@roeck-us.net> (raw) Several mips builds generate the following build warning. mm/gup.c:1788:13: warning: 'undo_dev_pagemap' defined but not used The function is declared unconditionally but only called from behind various ifdefs. Mark it __maybe_unused. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- mm/gup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/gup.c b/mm/gup.c index 7dde2e3a1963..95a373bd8f21 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -1785,7 +1785,8 @@ static inline pte_t gup_get_pte(pte_t *ptep) } #endif /* CONFIG_GUP_GET_PTE_LOW_HIGH */ -static void undo_dev_pagemap(int *nr, int nr_start, struct page **pages) +static void __maybe_unused undo_dev_pagemap(int *nr, int nr_start, + struct page **pages) { while ((*nr) - nr_start) { struct page *page = pages[--(*nr)]; -- 2.7.4
next reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-02 13:02 Guenter Roeck [this message] 2019-07-02 20:54 ` Andrew Morton 2019-07-02 23:27 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1562072523-22311-1-git-send-email-linux@roeck-us.net \ --to=linux@roeck-us.net \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=robin.murphy@arm.com \ --cc=sfr@canb.auug.org.au \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-mm Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \ linux-mm@kvack.org public-inbox-index linux-mm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kvack.linux-mm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git