From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03136C3A5A2 for ; Tue, 10 Sep 2019 12:46:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C67D52089F for ; Tue, 10 Sep 2019 12:45:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C67D52089F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 684A76B0006; Tue, 10 Sep 2019 08:45:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 635EC6B0007; Tue, 10 Sep 2019 08:45:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54C286B0008; Tue, 10 Sep 2019 08:45:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id 373F86B0006 for ; Tue, 10 Sep 2019 08:45:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id D445F6D85 for ; Tue, 10 Sep 2019 12:45:58 +0000 (UTC) X-FDA: 75918983196.08.milk89_512a49e53c258 X-HE-Tag: milk89_512a49e53c258 X-Filterd-Recvd-Size: 3122 Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Sep 2019 12:45:57 +0000 (UTC) X-UUID: ea7760d474544bb18f6fd74ca1614a77-20190910 X-UUID: ea7760d474544bb18f6fd74ca1614a77-20190910 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 1580390971; Tue, 10 Sep 2019 20:45:50 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Sep 2019 20:45:48 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 20:45:48 +0800 Message-ID: <1568119549.24886.18.camel@mtksdccf07> Subject: Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator From: Walter Wu To: Vlastimil Babka CC: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Matthias Brugger , Andrew Morton , "Martin Schwidefsky" , Will Deacon , "Andrey Konovalov" , Arnd Bergmann , "Thomas Gleixner" , Michal Hocko , Qian Cai , , , , , , Date: Tue, 10 Sep 2019 20:45:49 +0800 In-Reply-To: <4faedb4d-f16c-1917-9eaa-b0f9c169fa50@suse.cz> References: <20190909082412.24356-1-walter-zh.wu@mediatek.com> <4faedb4d-f16c-1917-9eaa-b0f9c169fa50@suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2019-09-10 at 13:53 +0200, Vlastimil Babka wrote: > On 9/10/19 12:50 PM, Andrey Ryabinin wrote: > > > > > > For slab objects we memorize both alloc and free stacks. You'll never know in advance what information will be usefull > > to fix an issue, so it usually better to provide more information. I don't think we should do anything different for pages. > > Exactly, thanks. > > > Given that we already have the page_owner responsible for providing alloc/free stacks for pages, all that we should in KASAN do is to > > enable the feature by default. Free stack saving should be decoupled from debug_pagealloc into separate option so that it can be enabled > > by KASAN and/or debug_pagealloc. > > Right. Walter, can you do it that way, or should I? > > Thanks, > Vlastimil I will send new patch v3.