From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72ABC32792 for ; Tue, 1 Oct 2019 02:42:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 510672075C for ; Tue, 1 Oct 2019 02:42:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nyt8XUXn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 510672075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ACF776B0005; Mon, 30 Sep 2019 22:42:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A585B6B0006; Mon, 30 Sep 2019 22:42:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91ED56B0007; Mon, 30 Sep 2019 22:42:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 6B8556B0005 for ; Mon, 30 Sep 2019 22:42:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 0ADD01EE6 for ; Tue, 1 Oct 2019 02:42:25 +0000 (UTC) X-FDA: 75993667050.18.edge67_6c57cb6a89407 X-HE-Tag: edge67_6c57cb6a89407 X-Filterd-Recvd-Size: 4873 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 02:42:24 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id q7so6829463pfh.8 for ; Mon, 30 Sep 2019 19:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=KCSgPg2RBIDL55p0zhNUa6csNsydfSPiDOMOTKFbrzM=; b=Nyt8XUXn/pUu+9DQJYoUyYYLmzluKIhiqC6qG5D7i6RlQG4nr7wyOWTWLIu+U3Tyu0 j+AZelUKpVbTNTw+Ce0ps2tA4jQkC8YLmkvGYob8WBFzihCVDCZ1KPwzbxV2wk8w0oTM hjmg9oeYqwRSDj1uxG71R2CrBSwEX6CvcArtVy9W6XrpmHpluNLZJ92yph93Q9ZSxmVn bZdSL/QaHTOcR2F+/3GengdDUCsjwP7rGrEXXcsvVVQaAxd4/zOQHsj4P9vwYReAhicF ipn+JBS0532WP86iAs5AVE9VcBYvQZBmrhxF7qFRPJCda7fiRx7iX6CNqNKNEEs9Tr0+ 3kHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=KCSgPg2RBIDL55p0zhNUa6csNsydfSPiDOMOTKFbrzM=; b=JnprDt9PBnZatmKl29MmZZVmfKRFRRGyYPnt5IQpQvErqEFfAWGXDXOzCGMXXCIhdb Ru81knMREjVSXTlXb//cUQOnKSpeqxVaEmPamUqOiOeoPBUKepyoGoorv9xJrs9XfU9C woxJE/NrEBVkm/0HqbPtdYilcHoPuYEqM1KBK7KsUMBq3uODWJliMN6D2rJhCXg6NHz9 pYrL0I1pNZ0ts4PbR7PjhFSmqGjP3psBo4W2KqTOX7JhG2r5wDLyF8henP3X/0fV/5Y4 e4OdZiUkA7EsOe5HVXpXCCRuSMChBDEiDT1BGZxVP7iMD5ZtYBF0L8BY7mk8vaRCTtkZ B/hg== X-Gm-Message-State: APjAAAU+jNeLzWDIbhcgnY5torSXfO8hGzIOWDKpyH+Jvsu2NpJI4L5Q OpbUQmFSjyEUJLHedj28fZE= X-Google-Smtp-Source: APXvYqyYLxlvhMghWN0GF7NqiN+G8HbnmB+ilX2UKJNex999WVWd3q3IzwW73xIR1vq/Ew6aUWG2iA== X-Received: by 2002:a65:6659:: with SMTP id z25mr28098813pgv.23.1569897743383; Mon, 30 Sep 2019 19:42:23 -0700 (PDT) Received: from dev.localdomain ([203.100.54.194]) by smtp.gmail.com with ESMTPSA id p189sm14891929pga.2.2019.09.30.19.42.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Sep 2019 19:42:22 -0700 (PDT) From: Yafang Shao To: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com Cc: linux-mm@kvack.org, Yafang Shao Subject: [PATCH] mm, memcg: clean up reclaim iter array Date: Mon, 30 Sep 2019 22:42:08 -0400 Message-Id: <1569897728-1686-1-git-send-email-laoar.shao@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The mem_cgroup_reclaim_cookie is only used in memcg softlimit reclaim now, and the priority of the reclaim is always 0. We don't need to define the iter in struct mem_cgroup_per_node as an array any more. That could make the code more clear and save some space. Signed-off-by: Yafang Shao --- include/linux/memcontrol.h | 3 +-- mm/memcontrol.c | 11 +++-------- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 0c762e8..7d99a65 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -58,7 +58,6 @@ enum mem_cgroup_protection { struct mem_cgroup_reclaim_cookie { pg_data_t *pgdat; - int priority; unsigned int generation; }; @@ -126,7 +125,7 @@ struct mem_cgroup_per_node { unsigned long lru_zone_size[MAX_NR_ZONES][NR_LRU_LISTS]; - struct mem_cgroup_reclaim_iter iter[DEF_PRIORITY + 1]; + struct mem_cgroup_reclaim_iter iter; struct memcg_shrinker_map __rcu *shrinker_map; diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 1c4c08b..5d9b00f 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1052,7 +1052,7 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root, struct mem_cgroup_per_node *mz; mz = mem_cgroup_nodeinfo(root, reclaim->pgdat->node_id); - iter = &mz->iter[reclaim->priority]; + iter = &mz->iter; if (prev && reclaim->generation != iter->generation) goto out_unlock; @@ -1152,15 +1152,11 @@ static void __invalidate_reclaim_iterators(struct mem_cgroup *from, struct mem_cgroup_reclaim_iter *iter; struct mem_cgroup_per_node *mz; int nid; - int i; for_each_node(nid) { mz = mem_cgroup_nodeinfo(from, nid); - for (i = 0; i <= DEF_PRIORITY; i++) { - iter = &mz->iter[i]; - cmpxchg(&iter->position, - dead_memcg, NULL); - } + iter = &mz->iter; + cmpxchg(&iter->position, dead_memcg, NULL); } } @@ -1705,7 +1701,6 @@ static int mem_cgroup_soft_reclaim(struct mem_cgroup *root_memcg, unsigned long nr_scanned; struct mem_cgroup_reclaim_cookie reclaim = { .pgdat = pgdat, - .priority = 0, }; excess = soft_limit_excess(root_memcg); -- 1.8.3.1