From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAABEECE587 for ; Tue, 1 Oct 2019 14:40:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 492F62054F for ; Tue, 1 Oct 2019 14:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="IeYUUoTk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 492F62054F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A5D8E8E0005; Tue, 1 Oct 2019 10:40:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0E6E8E0001; Tue, 1 Oct 2019 10:40:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FC8E8E0005; Tue, 1 Oct 2019 10:40:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 69B258E0001 for ; Tue, 1 Oct 2019 10:40:12 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id DAF87181AC9AE for ; Tue, 1 Oct 2019 14:40:11 +0000 (UTC) X-FDA: 75995475822.19.pan67_7611d9558a952 X-HE-Tag: pan67_7611d9558a952 X-Filterd-Recvd-Size: 4672 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 14:40:11 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id m15so21935198qtq.2 for ; Tue, 01 Oct 2019 07:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=9VDIX95q75l1fcGPHAGCoexbF88NYXczf33Qn1D7mVs=; b=IeYUUoTk8eThv+72jp/pu8xdlXAAX3/zY7+IYupoKCxoermZheJWI2mo/kCxoX9snx axePe7gr3wV54BxZqT/+17qIbHZ7OBZwdPCzV3bvxJW064GLwtbydfK8IG03nph4oexj VdPBwQumivhwrAaBWPsJv1sWgC25P8FIgxuzWJKhmJw25hkWNqen/jbydTfC5Yh1LGzA qh9CmPBeE9R4aXGYkDViCY+fox3lMgOFu471rQJ3cDyGzPLktOYX1FDYoQDKH2EKrjQ8 E2zZ/g0fWndeRA309yMCUTfJ3uRFlKpj6BQtWyUfSSsrMSJIjg8gSg5DVJc+Lfzn6Tgp Vzcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=9VDIX95q75l1fcGPHAGCoexbF88NYXczf33Qn1D7mVs=; b=DPV7gIwzh4QnJu/JEiQSJnC4+x+HfW2Q/GLsUv84ypu8LTBcoy2LZwIKlYNCgvJJTp sBNJhryn0r+JshlupBXkxO0Od29mYO5f7WWKi26B4C8x3Dr9JgxL9QiSzflmLPTjAqaM Rt8sZxqA5nMrZwgVXEV6wYrcJCfL0GSx9pUoLypTU02xJwJpvury9jqnC87L7Wbpgo7U jTwK4kaBo9+DFRp8kcqzANlGBnOsxfp/wXIfnf5sG2ERPVfsLg/kUTW6x9AnftPPpoDS QOpdRA6pZlizO8rTyL+KfCHAqKJDL8LUckgwydiUW79BsgzRJjvHCcUg5CX+gSRVLU7J FhIQ== X-Gm-Message-State: APjAAAX80iN0MBVmsSyZ+n4GIlQUEwbK6lZJVriUIELZGt8hafZ2H09i uf5wObnsPfvqRY7AVpwxfi0ahg== X-Google-Smtp-Source: APXvYqzJ4rqvFAJEgTDf25ELUEziBgh6eojZxo/BhgpnqhUElgq0KqGYVa27C4uPjU2WvJ+a3QRC7A== X-Received: by 2002:a05:6214:180a:: with SMTP id o10mr25687114qvw.51.1569940808438; Tue, 01 Oct 2019 07:40:08 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id q2sm7515437qkc.68.2019.10.01.07.40.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 07:40:07 -0700 (PDT) Message-ID: <1569940805.5576.257.camel@lca.pw> Subject: Re: [PATCH] mm/memcontrol.c: fix another unused function warning From: Qian Cai To: Arnd Bergmann , Johannes Weiner , Michal Hocko , Vladimir Davydov Cc: Michal Hocko , Andrew Morton , Roman Gushchin , Shakeel Butt , Chris Down , Tejun Heo , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Date: Tue, 01 Oct 2019 10:40:05 -0400 In-Reply-To: <20191001142227.1227176-1-arnd@arndb.de> References: <20191001142227.1227176-1-arnd@arndb.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > Removing the mem_cgroup_id_get() stub function introduced a new warning > of the same kind when CONFIG_MMU is disabled: Shouldn't CONFIG_MEMCG depends on CONFIG_MMU instead? > > mm/memcontrol.c:4929:13: error: unused function 'mem_cgroup_id_get_many' [-Werror,-Wunused-function] > > Address this using a __maybe_unused annotation. > > Note: alternatively, this could be moved into an #ifdef block. Marking it > 'static inline' would not work here as that would still produce the > warning on clang, which only ignores unused inline functions declared > in header files instead of .c files. > > Fixes: 4d0e3230a56a ("mm/memcontrol.c: fix a -Wunused-function warning") > Signed-off-by: Arnd Bergmann > --- > mm/memcontrol.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index c313c49074ca..5f9f90e3cef8 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4921,7 +4921,8 @@ static void mem_cgroup_id_remove(struct mem_cgroup *memcg) > } > } > > -static void mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) > +static void __maybe_unused > +mem_cgroup_id_get_many(struct mem_cgroup *memcg, unsigned int n) > { > refcount_add(n, &memcg->id.ref); > }