From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 280AEECE587 for ; Tue, 1 Oct 2019 16:44:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC8D721924 for ; Tue, 1 Oct 2019 16:44:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="UI4eNsI0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC8D721924 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7694B8E0006; Tue, 1 Oct 2019 12:44:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719C28E0001; Tue, 1 Oct 2019 12:44:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62E748E0006; Tue, 1 Oct 2019 12:44:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 4010E8E0001 for ; Tue, 1 Oct 2019 12:44:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id DE250181AC9AE for ; Tue, 1 Oct 2019 16:44:36 +0000 (UTC) X-FDA: 75995789352.28.limit71_283d45858d449 X-HE-Tag: limit71_283d45858d449 X-Filterd-Recvd-Size: 4172 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 16:44:36 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id d16so1841122qtq.8 for ; Tue, 01 Oct 2019 09:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=7GPDFQWuJXwzJuqgdtkv8cWj1/rryU2amRMgaS7klwk=; b=UI4eNsI01cw12FCH1szI/WpOWDa4aYdcfwkvjF0IataQqplLO5GIZr4lLpKiTNA1Ay 30U8FhzxOnozK/bML5k8xB8Vk/Mvr4T7avhwBHv7jt3G0Id/wFihN8VFw3eyKc8pGSLF vhJd5VxytmfI8W3SVJ6Y70mWApfvtdP0qOYh7jZjeIuXbqyZ30E6+7D8kBMzAJGnJwMj JO2DFGWYAm8+CuNdxW50PvPeOpgJUYiXllV7SB789XKFpeK9CDGSwG6iG7kBSIKxpHeE 2GhuyBg5Imcu8wBPi3w4si8hU8R9pLqCkPmY8iyZyieAMvzcmNRhTOiCeB3x7VYWf7L3 MWRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=7GPDFQWuJXwzJuqgdtkv8cWj1/rryU2amRMgaS7klwk=; b=Nhf+/SgfKzK2JmMo2Pi1FQ7canKnVwJcA7AM7ORKtJM6F+H0JkeQY5+NTpoD1d67GJ R+A1YU0dz+xJ0kNyt1HWxFaRNqdCmEQ7RC6YsIJM3k7Jblv+KeqbqXqp9SSnRCBxKNRA lS9xlBxXU+06e3TTAqQodwRuPyUzHw7X+90AsWzM8ECRvLgyTBflGSJRtB2CSPRvxyo6 6PEU6MJGwklDaaLqcDJ/nzgve1EYD8yWF7fe3qp1l/AXZtx5VIw6zRgem+EKxzoRR96c 8ploz6Hl8h5zZJkQIwcn08KauuKDvN85l3aliE2dhIFf8yvGTskRdf8OAq2hjBXKUnhN v8Pg== X-Gm-Message-State: APjAAAXU8FosDJuSuHLXokt6+QdVSTzjVhmlt1/2bxkOn5hiY3xCwFu4 ut2CzsxYfCUkRODDShf55/I8LA== X-Google-Smtp-Source: APXvYqyObNCYAzFu3jyjhNDjKUVhXypcTsi/L5PiHM0qUrfbw71DITAFbh7MVl2LtTvReBCYDaJLHQ== X-Received: by 2002:ac8:1207:: with SMTP id x7mr22977563qti.247.1569948275773; Tue, 01 Oct 2019 09:44:35 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id a11sm7923492qkc.123.2019.10.01.09.44.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 09:44:35 -0700 (PDT) Message-ID: <1569948272.5576.259.camel@lca.pw> Subject: Re: [PATCH] mm/memcontrol.c: fix another unused function warning From: Qian Cai To: Arnd Bergmann Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Michal Hocko , Andrew Morton , Roman Gushchin , Shakeel Butt , Chris Down , Tejun Heo , cgroups@vger.kernel.org, Linux-MM , "linux-kernel@vger.kernel.org" , clang-built-linux Date: Tue, 01 Oct 2019 12:44:32 -0400 In-Reply-To: References: <20191001142227.1227176-1-arnd@arndb.de> <1569940805.5576.257.camel@lca.pw> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2019-10-01 at 18:00 +0200, Arnd Bergmann wrote: > On Tue, Oct 1, 2019 at 4:40 PM Qian Cai wrote: > > > > On Tue, 2019-10-01 at 16:22 +0200, Arnd Bergmann wrote: > > > Removing the mem_cgroup_id_get() stub function introduced a new warning > > > of the same kind when CONFIG_MMU is disabled: > > > > Shouldn't CONFIG_MEMCG depends on CONFIG_MMU instead? > > Maybe. Generally we allow building a lot of stuff without CONFIG_MMU that > may not make sense, so I just followed the same idea here. Those blindly mark __maybe_unused might just mask important warnings off in the future, and they are ugly. Let's fix it properly.