From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13ADDECE587 for ; Tue, 1 Oct 2019 23:57:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8D90120818 for ; Tue, 1 Oct 2019 23:57:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D90120818 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2A0AD8E0006; Tue, 1 Oct 2019 19:57:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2069D8E0001; Tue, 1 Oct 2019 19:57:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 02CA58E0006; Tue, 1 Oct 2019 19:57:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D03868E0001 for ; Tue, 1 Oct 2019 19:57:01 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 5762B34A3 for ; Tue, 1 Oct 2019 23:57:01 +0000 (UTC) X-FDA: 75996879042.26.suit78_200e43c920725 X-HE-Tag: suit78_200e43c920725 X-Filterd-Recvd-Size: 2877 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Oct 2019 23:56:59 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R641e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07417;MF=yang.shi@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0TdwevRd_1569974210; Received: from e19h19392.et15sqa.tbsite.net(mailfrom:yang.shi@linux.alibaba.com fp:SMTPD_---0TdwevRd_1569974210) by smtp.aliyun-inc.com(127.0.0.1); Wed, 02 Oct 2019 07:56:56 +0800 From: Yang Shi To: kirill.shutemov@linux.intel.com, ktkhai@virtuozzo.com, hannes@cmpxchg.org, mhocko@suse.com, hughd@google.com, shakeelb@google.com, rientjes@google.com, akpm@linux-foundation.org Cc: yang.shi@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm thp: shrink deferred split THPs harder Date: Wed, 2 Oct 2019 07:56:50 +0800 Message-Id: <1569974210-55366-1-git-send-email-yang.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The deferred split THPs may get accumulated with some workloads, they would get shrunk when memory pressure is hit. Now we use DEFAULT_SEEKS to determine how many objects would get scanned then split if possible, but actually they are not like other system cache objects, i.e. inode cache which would incur extra I/O if over reclaimed, the unmapped pages will not be accessed anymore, so we could shrink them more aggressively. We could shrink THPs more pro-actively even though memory pressure is not hit, however, IMHO waiting for memory pressure is still a good compromise and trade-off. And, we do have simpler ways to shrink these objects harder until we have to take other means do pro-actively drain. Change shrinker->seeks to 0 to shrink deferred split THPs harder. Cc: Kirill A. Shutemov Cc: Kirill Tkhai Cc: Johannes Weiner Cc: Michal Hocko Cc: Hugh Dickins Cc: Shakeel Butt Cc: David Rientjes Signed-off-by: Yang Shi --- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 3b78910..1d6b1f1 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2955,7 +2955,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, static struct shrinker deferred_split_shrinker = { .count_objects = deferred_split_count, .scan_objects = deferred_split_scan, - .seeks = DEFAULT_SEEKS, + .seeks = 0, .flags = SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE | SHRINKER_NONSLAB, }; -- 1.8.3.1