From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0587DC2BD09 for ; Wed, 4 Dec 2019 13:22:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE7EB2073C for ; Wed, 4 Dec 2019 13:22:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyRyiRJs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE7EB2073C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4914B6B0ABD; Wed, 4 Dec 2019 08:22:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4417C6B0ABE; Wed, 4 Dec 2019 08:22:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 356E96B0ABF; Wed, 4 Dec 2019 08:22:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id 217636B0ABD for ; Wed, 4 Dec 2019 08:22:33 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id D772582D032E for ; Wed, 4 Dec 2019 13:22:32 +0000 (UTC) X-FDA: 76227523344.03.group95_6d7999b341e4b X-HE-Tag: group95_6d7999b341e4b X-Filterd-Recvd-Size: 6489 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Dec 2019 13:22:32 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id h14so3640169pfe.10 for ; Wed, 04 Dec 2019 05:22:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wZJOF5sLAkP6Lj5JLT4j1oHbVGDdAKwvCkWIUq+dheE=; b=pyRyiRJsR/LSFSgykNDNtWvgkjb/xDhjdWYPO4bvDoYwIrAiXaC8Q9Mfe1qKKmYaYR JGPz6eDAEudYkUKAeATKN7m8fsMYj1DteNEskTvJFGYJ/At5faDtqSL/RU12cSxucLnA RrbwncZHxyOUZ6HvOlL/m+ImhQucJU7j0tMmCXkom+JkJkQJJcg0/2JiLLTYBFhrYNX2 ZRhSs1k59HQ9adQyGfpYEk2vMSekJHU9onLCDZyH8bdnlj6UzaUbsTkXclR6XB+ik+1m dflGFJf6R4P6X7Ct5JDhiuAiIqObkM0FdrlxMLHxzgMiyfo83v/ANwBZVNjQ358K8BkO TxiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wZJOF5sLAkP6Lj5JLT4j1oHbVGDdAKwvCkWIUq+dheE=; b=iFWXwCKBBjWE6c+IZCKs8Q+2r2oEz4bP9cRt9yY2gMV4tOuR/hJ/KaucYta7r8J+Sl nSQ3elArCDUxqhUbL6VP6Cmq1GyioRmZBSutcNYFpyW86G2q7F5nIFzzusjhazWQ/gY/ wNcpnlxf1UMsy3LgXD2CMyw0nMy6nkSOR7kD+Q/8vPMDWOuduIyLjbSpkJEsebBrHIke aaA8HqZgWt9190b1KcO0QUyD22UUWfyBP5do9N3kt+gI+NvPRAUr7g2mITa5V3x44qJt d12+cFJhFEKZBsOrDWa3obeDdH8ND8lcRiw8oCmNWHgaFLXZ0Oemx4B8QCXgJuIcEqwP yiiw== X-Gm-Message-State: APjAAAVsFYD/YoL32Vn+yO2JMdnOwbDi4hOonvSmUH9leQH1V++dvP9M ozd74ThWuy5ZKopYf+TEM98= X-Google-Smtp-Source: APXvYqwkk/5MouzqntAeuXQGGYrBHHJiqg16oYZsk0XxEdxvjahSNBUzsQvvraKzr9vzruaDkgwQtw== X-Received: by 2002:aa7:8ad3:: with SMTP id b19mr3489646pfd.134.1575465751097; Wed, 04 Dec 2019 05:22:31 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id s7sm7911105pfe.22.2019.12.04.05.22.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2019 05:22:30 -0800 (PST) Subject: Re: [PATCH v6 10/18] sh/tlb: Convert SH to generic mmu_gather To: Geert Uytterhoeven , Peter Zijlstra Cc: Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nicholas Piggin , Linux-Arch , Linux MM , Linux Kernel Mailing List , Russell King , Heiko Carstens , Rik van Riel , Yoshinori Sato , Rich Felker , Linux-sh list References: <20190219103148.192029670@infradead.org> <20190219103233.443069009@infradead.org> <20191204104733.GR2844@hirez.programming.kicks-ass.net> From: Guenter Roeck Message-ID: <156fa92f-4c5a-08bd-bcda-20029724c0de@roeck-us.net> Date: Wed, 4 Dec 2019 05:22:28 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/4/19 4:32 AM, Geert Uytterhoeven wrote: > Hoi Peter, >=20 > On Wed, Dec 4, 2019 at 11:48 AM Peter Zijlstra w= rote: >> On Tue, Dec 03, 2019 at 12:19:00PM +0100, Geert Uytterhoeven wrote: >>> On Tue, Feb 19, 2019 at 11:35 AM Peter Zijlstra wrote: >>>> Generic mmu_gather provides everything SH needs (range tracking and >>>> cache coherency). >>>> >>>> Cc: Will Deacon >>>> Cc: "Aneesh Kumar K.V" >>>> Cc: Andrew Morton >>>> Cc: Nick Piggin >>>> Cc: Yoshinori Sato >>>> Cc: Rich Felker >>>> Signed-off-by: Peter Zijlstra (Intel) >>> >>> I got remote access to an SH7722-based Migo-R again, which spews a lo= ng >>> sequence of BUGs during userspace startup. I've bisected this to com= mit >>> c5b27a889da92f4a ("sh/tlb: Convert SH to generic mmu_gather"). >> >> Whoopsy.. also, is this really the first time anybody booted an SH >> kernel in over a year ?!? >=20 > Nah, but the v5.4-rc3 I booted recently on qemu -M r2d had > CONFIG_PGTABLE_LEVELS=3D2, so it didn't show the problem. >=20 Guess that explains why I do not see the problem with my qemu boots. I use rts7751r2dplus_defconfig. Is it possible to reproduce the problem with qemu ? I don't think so, but maybe I am missing something. Guenter >>> Do you have a clue? >> >> Does the below help? >=20 > Unfortunately not. >=20 >> diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgall= oc.h >> index 22d968bfe9bb..73a2c00de6c5 100644 >> --- a/arch/sh/include/asm/pgalloc.h >> +++ b/arch/sh/include/asm/pgalloc.h >> @@ -36,9 +36,8 @@ do { = \ >> #if CONFIG_PGTABLE_LEVELS > 2 >> #define __pmd_free_tlb(tlb, pmdp, addr) \ >> do { \ >> - struct page *page =3D virt_to_page(pmdp); \ >> - pgtable_pmd_page_dtor(page); \ >> - tlb_remove_page((tlb), page); \ >> + pgtable_pmd_page_dtor(pmdp); \ >=20 > expected =E2=80=98struct page *=E2=80=99 but argument is of type =E2=80= =98pmd_t * {aka struct > *}=E2=80=99 >=20 >> + tlb_remove_page((tlb), (pmdp)); \ >=20 > likewise >=20 >> } while (0); >> #endif >=20 > Gr{oetje,eeting}s, >=20 > Geert >=20