From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F09C4360C for ; Fri, 4 Oct 2019 13:30:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CAEE0207FF for ; Fri, 4 Oct 2019 13:30:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="e8IRDuL5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAEE0207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 513D28E0005; Fri, 4 Oct 2019 09:30:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C4D98E0003; Fri, 4 Oct 2019 09:30:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DB248E0005; Fri, 4 Oct 2019 09:30:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 1B44C8E0003 for ; Fri, 4 Oct 2019 09:30:44 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id B1CB8824376B for ; Fri, 4 Oct 2019 13:30:43 +0000 (UTC) X-FDA: 76006187166.04.fog78_7ab451140d501 X-HE-Tag: fog78_7ab451140d501 X-Filterd-Recvd-Size: 4094 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Oct 2019 13:30:43 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id c3so8490080qtv.10 for ; Fri, 04 Oct 2019 06:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=B5vnSSCIcbplBcWNA19HtmeOraO3xHVwUmiEjyji+dc=; b=e8IRDuL5YyKeZPPnATe7X4oE8SALc3CKjZg+DyKSbhJqyrlr+9MFiRisQJfTHCFGUN I1v3KWVu3KlqiHLDMEgkPLKD7QK7oWnmxeciqctHX3o80NnUmRSbjoP/M5GZ+a3r/v4w 0qpwZGqBg2SqYUYhO+S6AqTU4vMxa9zfsBzjRH8i3sRB2gw747U5qDthrVlBCGck6c09 rAr8Xx2waDW6mV+hJs5aJvyEjUK2dpAkyz5rtJXkuCs5PVJndm9xm8HQ9TYQgp9ImdtL JTNezfq/awagUkCVuzXYghiyNmwjngYkcfH7Dsp7ZVo3JVY41hIPxnzaLxJQYpBFS1fH aNlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=B5vnSSCIcbplBcWNA19HtmeOraO3xHVwUmiEjyji+dc=; b=dst+eRlX1bWyxq+YUwyhVIrMgtx1jJ078miKYgVp4iTphufJgG07YlTYTwDnVYzbtQ 11VhJRckLy8eDoloUOJUUlZ2HZKAXoxTSb/pc4JGeMYnm9lahlbajOrO7j1qiJ+e9HFb ZQwf12XuJk55iHgiYJ2R1NM5cMj8CoK7pkMrCqVQQ0NE7XqROpeeJgacAJegecCQxFek MER3HGUQExGGbaG+6uFF1BxEj/7xUpp4lZCVTWf8IN1NwOG2B0w/keCOO4D3P8NgvBcS E187DPRrLZZ3CEcR79KrGBLrLhaZjZwaRMVwZgCriCX28OScCi3HaJ12dpzYwfWFI7QH 6cJg== X-Gm-Message-State: APjAAAVEl5uLmSc2Mk3ay4eVZmqqf+1+UEjTZPs9ejLvbCiF4FiKJDXY U/XrKvRaIyE9LxlVXqI+5vxW0g== X-Google-Smtp-Source: APXvYqyifeRTX7SmGTGjjWVD0NCxVG8ZiHqtUI/fVbaztaXVCrdZ2DBwCZvtleHH5tDQUjLVjdAEtw== X-Received: by 2002:a0c:f3c1:: with SMTP id f1mr1163664qvm.165.1570195842396; Fri, 04 Oct 2019 06:30:42 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id i66sm3176454qkb.105.2019.10.04.06.30.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Oct 2019 06:30:41 -0700 (PDT) Message-ID: <1570195839.5576.273.camel@lca.pw> Subject: Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages() From: Qian Cai To: Michal Hocko Cc: Anshuman Khandual , linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Oscar Salvador , Mel Gorman , Mike Rapoport , Dan Williams , Pavel Tatashin , linux-kernel@vger.kernel.org Date: Fri, 04 Oct 2019 09:30:39 -0400 In-Reply-To: <20191004130713.GK9578@dhcp22.suse.cz> References: <1570090257-25001-1-git-send-email-anshuman.khandual@arm.com> <20191004105824.GD9578@dhcp22.suse.cz> <91128b73-9a47-100b-d3de-e83f0b941e9f@arm.com> <1570193776.5576.270.camel@lca.pw> <20191004130713.GK9578@dhcp22.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000343, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2019-10-04 at 15:07 +0200, Michal Hocko wrote: > On Fri 04-10-19 08:56:16, Qian Cai wrote: > [...] > > It might be a good time to rethink if it is really a good idea to dump_page() > > at all inside has_unmovable_pages(). As it is right now, it is a a potential > > deadlock between console vs memory offline. More details are in this thread, > > > > https://lore.kernel.org/lkml/1568817579.5576.172.camel@lca.pw/ > > Huh. That would imply we cannot do any printk from that path, no? Yes, or use something like printk_deferred() or it needs to rework of the current console locking which I have no clue yet.