From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF48C4360C for ; Tue, 8 Oct 2019 19:06:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 227DD206B6 for ; Tue, 8 Oct 2019 19:06:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="hUg06ZRT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 227DD206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A181D8E0005; Tue, 8 Oct 2019 15:06:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A09F8E0003; Tue, 8 Oct 2019 15:06:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 869BE8E0005; Tue, 8 Oct 2019 15:06:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0177.hostedemail.com [216.40.44.177]) by kanga.kvack.org (Postfix) with ESMTP id 5E9C98E0003 for ; Tue, 8 Oct 2019 15:06:17 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 15272824CA0A for ; Tue, 8 Oct 2019 19:06:17 +0000 (UTC) X-FDA: 76021547994.26.team78_53dfb8f0f531f X-HE-Tag: team78_53dfb8f0f531f X-Filterd-Recvd-Size: 10010 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Oct 2019 19:06:16 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id 3so26909258qta.1 for ; Tue, 08 Oct 2019 12:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=MEHy0LqfQYezFUAL4y0Jud/jb8GNwlETVuuWl+duy9U=; b=hUg06ZRTxQUAYHnpHo9oNxpakjT9uXkh8KrVTGzFF3rae6KaKOqr8Zk7vJlVTQoVdU B58xVuav9XT2gdT2LPOjx+7hIf+1XdoZI9BFRSjoPNaeye6QoNmeEeDD5/Z4QzC9/7+o JgC8dSoyKTI9Ty0+/6bEuEY/N9CRFErNx/qPB3vHtiBxIGXL95qGY1kpXrEtrtsYpvSh rbFYw3HNpJ5bd2A2gL9ZCw8CDQDmSmv/lXz7nSAcBKHtCe/t41rmzFcKyH2vGk511BV7 Nj+3ogB3AtjoOVJmW0+do7VBqUUfus+ckWtB6J5kV9i+g61JdjG0swnvNYE6VI9+pOEr k2Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=MEHy0LqfQYezFUAL4y0Jud/jb8GNwlETVuuWl+duy9U=; b=sY/lEHItIV24Ycf0ybP+S7lf5sM2szrK/8yoNAteNd2ns7WNjge4Kfy5EE1SDHA0A8 fO+AO9MKBvsxRYoax3ENV08ubBXXNqFegsR1WhmcCQAeKXojxjYKVaoS7qZ8POemXvam 4bWtV4OlgOSijhl6SdzOKQ1YXnChutf1dicVGmlmhIqunWAlMgT6CfDSQDkwzGmdNWfg HFjoqoEzDP2Ub37DKCVv1tCyx6/GEOkAs2j82/PHPWopoXyfyvyMEkW26Kf2LQKg7s3Q 4ziO0lQEydkV9lHOPdoKH0KxZXyqwu2YGBT/FleBqZson+/rda4VHzE0LuxerJeLgHCf JH4w== X-Gm-Message-State: APjAAAVoJcMvF1gFQ2m0K/CUDCNMslMRTIm1VvNchr/vel3Y0HlPA/El Mcujy4gGuLiFbt6twbZBuNyoKg== X-Google-Smtp-Source: APXvYqwoSsU9q/h+zKqV9Lp2EUueseEvYqy1MGNRKRShqnHobg+k+WZqVk7ISv/p4SVWALhZiQc5hQ== X-Received: by 2002:ac8:37cb:: with SMTP id e11mr38483393qtc.22.1570561575487; Tue, 08 Oct 2019 12:06:15 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id m15sm8809190qka.104.2019.10.08.12.06.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Oct 2019 12:06:14 -0700 (PDT) Message-ID: <1570561573.5576.307.camel@lca.pw> Subject: Re: [PATCH v2] mm/page_isolation: fix a deadlock with printk() From: Qian Cai To: Michal Hocko Cc: Christian Borntraeger , Petr Mladek , Peter Oberparleiter , akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com, rostedt@goodmis.org, peterz@infradead.org, linux-mm@kvack.org, john.ogness@linutronix.de, david@redhat.com, linux-kernel@vger.kernel.org, Heiko Carstens , Vasily Gorbik Date: Tue, 08 Oct 2019 15:06:13 -0400 In-Reply-To: <20191008183525.GQ6681@dhcp22.suse.cz> References: <1570228005-24979-1-git-send-email-cai@lca.pw> <20191007143002.l37bt2lzqtnqjqxu@pathway.suse.cz> <20191007144937.GO2381@dhcp22.suse.cz> <20191008074357.f33f6pbs4cw5majk@pathway.suse.cz> <20191008082752.GB6681@dhcp22.suse.cz> <1570550917.5576.303.camel@lca.pw> <20191008183525.GQ6681@dhcp22.suse.cz> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2019-10-08 at 20:35 +0200, Michal Hocko wrote: > On Tue 08-10-19 12:08:37, Qian Cai wrote: > > On Tue, 2019-10-08 at 14:56 +0200, Christian Borntraeger wrote: > > > Adding Peter Oberparleiter. > > > Peter, can you have a look? > > >=20 > > > On 08.10.19 10:27, Michal Hocko wrote: > > > > On Tue 08-10-19 09:43:57, Petr Mladek wrote: > > > > > On Mon 2019-10-07 16:49:37, Michal Hocko wrote: > > > > > > [Cc s390 maintainers - the lockdep is http://lkml.kernel.org/= r/1570228005-24979-1-git-send-email-cai@lca.pw > > > > > > Petr has explained it is a false positive > > > > > > http://lkml.kernel.org/r/20191007143002.l37bt2lzqtnqjqxu@pat= hway.suse.cz] > > > > > > On Mon 07-10-19 16:30:02, Petr Mladek wrote: > > > > > > [...] > > > > > > > I believe that it cannot really happen because: > > > > > > >=20 > > > > > > > static int __init > > > > > > > sclp_console_init(void) > > > > > > > { > > > > > > > [...] > > > > > > > rc =3D sclp_rw_init(); > > > > > > > [...] > > > > > > > register_console(&sclp_console); > > > > > > > return 0; > > > > > > > } > > > > > > >=20 > > > > > > > sclp_rw_init() is called before register_console(). And > > > > > > > console_unlock() will never call sclp_console_write() befor= e > > > > > > > the console is registered. > > > > > > >=20 > > > > > > > AFAIK, lockdep only compares existing chain of locks. It do= es > > > > > > > not know about console registration that would make some > > > > > > > code paths mutually exclusive. > > > > > > >=20 > > > > > > > I believe that it is a false positive. I do not know how to > > > > > > > avoid this lockdep report. I hope that it will disappear > > > > > > > by deferring all printk() calls rather soon. > > > > > >=20 > > > > > > Thanks a lot for looking into this Petr. I have also checked = the code > > > > > > and I really fail to see why the allocation has to be done un= der the > > > > > > lock in the first place. sclp_read_sccb and sclp_init_sccb ar= e global > > > > > > variables but I strongly suspect that they need a synchroniza= tion during > > > > > > early init, callbacks are registered only later IIUC: > > > > >=20 > > > > > Good idea. It would work when the init function is called only = once. > > > > > But see below. > > > > >=20 > > > > > > diff --git a/drivers/s390/char/sclp.c b/drivers/s390/char/scl= p.c > > > > > > index d2ab3f07c008..4b1c033e3255 100644 > > > > > > --- a/drivers/s390/char/sclp.c > > > > > > +++ b/drivers/s390/char/sclp.c > > > > > > @@ -1169,13 +1169,13 @@ sclp_init(void) > > > > > > unsigned long flags; > > > > > > int rc =3D 0; > > > > > > =20 > > > > > > + sclp_read_sccb =3D (void *) __get_free_page(GFP_ATOMIC | GF= P_DMA); > > > > > > + sclp_init_sccb =3D (void *) __get_free_page(GFP_ATOMIC | GF= P_DMA); > > > > > > spin_lock_irqsave(&sclp_lock, flags); > > > > > > /* Check for previous or running initialization */ > > > > > > if (sclp_init_state !=3D sclp_init_state_uninitialized) > > > > > > goto fail_unlock; > > > > >=20 > > > > > It seems that sclp_init() could be called several times in para= llel. > > > > > I see it called from sclp_register() and sclp_initcall(). > > > >=20 > > > > Interesting. Something for s390 people to answer I guess. > > > > Anyway, this should be quite trivial to workaround by a cmpxch or= alike. > > > >=20 > >=20 > > The above fix is simply insufficient, >=20 > Isn't this yet another init time lockdep false possitive? Again, this is not 100% false positive for sure yet. >=20 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654337] -> #3 (console_owner){....}:=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654343]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0lock_acquire+0x21a/0x468=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654345]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0console_unlock+0x3a6/0xa30=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654346]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0vprintk_emit+0x184/0x3c8=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654348]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0vprintk_default+0x44/0x50=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654349]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0printk+0xa8/0xc0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654351]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0get_random_u64+0x40/0x108=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654360]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0add_to_free_area_random+0x188/0x1c0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654364]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0free_one_page+0x72/0x128=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654366]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0__free_pages_ok+0x51c/0xca0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654368]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0memblock_free_all+0x30a/0x3b0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654370]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0mem_init+0x84/0x200=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654371]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0start_kernel+0x384/0x6a0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 > > 00: [=C2=A0=C2=A0=C2=A0=C2=A03.654373]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0startup_continue+0x70/0xd0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=20 > This one is actually a nice example why trying to get printk out of the > zone->lock is simply not viable. This one is likely a printk to warn > that the random pool is not fully intiailized. Just because the > allocator tries to randomize the initial free memory pool. You are not > going to remove that printk, right? Well, Sergey had a patch to convert that one to printk_deferred(), but ev= en with his patch, it will still trigger the lockdep splat here because the lock dependency between zone->lock --> console_owner is still there from memor= y offline. >=20 > I fully agree that this class of lockdep splats are annoying especially > when they make the lockdep unusable but please discuss this with lockde= p > maintainers and try to find some solution rather than go and try to > workaround the problem all over the place. If there are places that > would result in a cleaner code then go for it but please do not make th= e > code worse just because of a non existent problem flagged by a false > positive. It makes me wonder what make you think it is a false positive for sure.