From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B23ECE588 for ; Tue, 15 Oct 2019 18:09:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 739D82086A for ; Tue, 15 Oct 2019 18:09:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="OnJVDC5h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 739D82086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D8EA28E0005; Tue, 15 Oct 2019 14:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D40228E0001; Tue, 15 Oct 2019 14:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2EA28E0005; Tue, 15 Oct 2019 14:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id A47A68E0001 for ; Tue, 15 Oct 2019 14:09:47 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 29B142DFD for ; Tue, 15 Oct 2019 18:09:47 +0000 (UTC) X-FDA: 76046807214.10.honey64_8f94af9e16d48 X-HE-Tag: honey64_8f94af9e16d48 X-Filterd-Recvd-Size: 6111 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Tue, 15 Oct 2019 18:09:46 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id m61so31901249qte.7 for ; Tue, 15 Oct 2019 11:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=OnJVDC5hcrBKYzJ0aaZLxRkdp1U3qCbQgu81veLGc4CM3Zb6t5hcOJCBpTdvyBdixF VWur9qZ4L56kK+G5lLndae4M48fKcE348SEdyWD92O4lDLHkfxe5ub5wW2//gFbMdbTi iE/SuY24OOqYt++fDwkOv1/GwgIUIlLUQjLQSRUD9o8GbrJtA9JJHM6yNqLJ6MTwQsp1 dfxkcvx1nTD9OtgmSDJrI8pHgij5k8GqR5jvJV2yqTmJQajvA0gKezgdBIJXSTBKmtgD Bn30ldSgF22fHm04r+hQGzlUE6CW7jcqmMjIT04sV5F04SskgoCcXMGW7VfjZDMID4ld SbxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=0qwLtcxPALcuAsItN1B8qx8pI5MyvooMsDhjXlcFVYU=; b=jUzkCQ7jGo7meV1m9BouJKBZIIcc+Re6XsYWyJkSyqIF219ze1jPyDcaZRqb3n2mrr +pEAIt48moNXqPAviL3ZaVEEr7hPEv9XAxhxjFyN4RgaabM/k+QxIVbzsbOHtOsSSsQ2 +ovpMMeVscvUKLyGKjZMYRzRNrFpptH+KLG53m69MgGrecOdAzffiW6vH1iNaJJg2Nsf OG0iy3wRlcYsyMYV41uJET4oYvHdwIZ2HvtvzXQW1U9/LVQwHgi6ARAQQRs4yWMZlPj/ pNdeY8ceLfe4zN0lXxvEzDrvuMHJ0OukqUjvzr7LTKzl++L/1ChOmu71gH0LarIOhz+Q SF0g== X-Gm-Message-State: APjAAAVEDwgxmVFOIKYd+lDcH88BSRj44/+c4HywIuq0IO0cQU6w7OeR XhAZ8Xxp0UdH2Yz9eKWTP+xI3Q== X-Google-Smtp-Source: APXvYqyVLYUWTIAK6GzhvgdzZLJE6+q5wD4mjw+q975FciP9rpwUqd4etcurLcTJHzy5ZkDdOjbnKA== X-Received: by 2002:ac8:7289:: with SMTP id v9mr39571710qto.139.1571162985818; Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k54sm15559033qtf.28.2019.10.15.11.09.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Oct 2019 11:09:45 -0700 (PDT) Message-ID: <1571162982.5937.42.camel@lca.pw> Subject: Re: [PATCH V6 2/2] mm/debug: Add tests validating architecture page table helpers From: Qian Cai To: Anshuman Khandual , linux-mm@kvack.org Cc: Andrew Morton , Vlastimil Babka , Greg Kroah-Hartman , Thomas Gleixner , Mike Rapoport , Jason Gunthorpe , Dan Williams , Peter Zijlstra , Michal Hocko , Mark Rutland , Mark Brown , Steven Price , Ard Biesheuvel , Masahiro Yamada , Kees Cook , Tetsuo Handa , Matthew Wilcox , Sri Krishna chowdary , Dave Hansen , Russell King - ARM Linux , Michael Ellerman , Paul Mackerras , Martin Schwidefsky , Heiko Carstens , "David S. Miller" , Vineet Gupta , James Hogan , Paul Burton , Ralf Baechle , "Kirill A . Shutemov" , Gerald Schaefer , Christophe Leroy , linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Date: Tue, 15 Oct 2019 14:09:42 -0400 In-Reply-To: <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> References: <1571131302-32290-1-git-send-email-anshuman.khandual@arm.com> <1571131302-32290-3-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2019-10-15 at 14:51 +0530, Anshuman Khandual wrote: > +static unsigned long __init get_random_vaddr(void) > +{ > + unsigned long random_vaddr, random_pages, total_user_pages; > + > + total_user_pages =3D (TASK_SIZE - FIRST_USER_ADDRESS) / PAGE_SIZE; > + > + random_pages =3D get_random_long() % total_user_pages; > + random_vaddr =3D FIRST_USER_ADDRESS + random_pages * PAGE_SIZE; > + > + WARN_ON(random_vaddr > TASK_SIZE); > + WARN_ON(random_vaddr < FIRST_USER_ADDRESS); It would be nice if this patch does not introduce a new W=3D1 GCC warning= here on x86 because FIRST_USER_ADDRESS is 0, and GCC think the code is dumb becau= se "random_vaddr" is unsigned, In file included from ./arch/x86/include/asm/bug.h:83, =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0from ./include/linux/bug.h:5, =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0from ./include/linux/mmdebug.h:5, =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0from ./include/linux/gfp.h:5, =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0from mm/debug_vm_pgtable.c:13: mm/debug_vm_pgtable.c: In function =E2=80=98get_random_vaddr=E2=80=99: mm/debug_vm_pgtable.c:359:23: warning: comparison of unsigned expression = < 0 is always false [-Wtype-limits] =C2=A0 WARN_ON(random_vaddr < FIRST_USER_ADDRESS); =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0^ ./include/asm-generic/bug.h:113:25: note: in definition of macro =E2=80=98= WARN_ON=E2=80=99 =C2=A0 int __ret_warn_on =3D !!(condition);=C2=A0=C2=A0=C2=A0=C2=A0\ =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= ^~~~~~~~~