Linux-mm Archive on lore.kernel.org
 help / color / Atom feed
From: Qian Cai <cai@lca.pw>
To: akpm@linux-foundation.org
Cc: steven.price@arm.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>
Subject: [PATCH -next] mm/ptdump: fix a -Wold-style-declaration warning
Date: Mon,  4 Nov 2019 14:23:05 -0500
Message-ID: <1572895385-29194-1-git-send-email-cai@lca.pw> (raw)

The -next commit "mm: add generic ptdump" [1] introduced a GCC
compilation warning,

mm/ptdump.c:123:1: warning: 'static' is not at beginning of declaration
[-Wold-style-declaration]
 const static struct mm_walk_ops ptdump_ops = {
 ^~~~~

[1] http://lkml.kernel.org/r/20191028135910.33253-20-steven.price@arm.com

Signed-off-by: Qian Cai <cai@lca.pw>
---
 mm/ptdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/ptdump.c b/mm/ptdump.c
index 5d349311e77e..a30ea0cf6c5f 100644
--- a/mm/ptdump.c
+++ b/mm/ptdump.c
@@ -120,7 +120,7 @@ static int ptdump_hole(unsigned long addr, unsigned long next,
 	return 0;
 }
 
-const static struct mm_walk_ops ptdump_ops = {
+static const struct mm_walk_ops ptdump_ops = {
 	.pgd_entry	= ptdump_pgd_entry,
 	.p4d_entry	= ptdump_p4d_entry,
 	.pud_entry	= ptdump_pud_entry,
-- 
1.8.3.1



                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1572895385-29194-1-git-send-email-cai@lca.pw \
    --to=cai@lca.pw \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=steven.price@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-mm Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-mm/0 linux-mm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-mm linux-mm/ https://lore.kernel.org/linux-mm \
		linux-mm@kvack.org
	public-inbox-index linux-mm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kvack.linux-mm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git