* [PATCH] mm/kasan: Fix an compile error
@ 2019-12-03 8:50 zhong jiang
2019-12-03 23:06 ` Daniel Axtens
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2019-12-03 8:50 UTC (permalink / raw)
To: akpm, dja; +Cc: aryabinin, glider, linux-mm
I hit the following compile error in arch/x86/
mm/kasan/common.c: In function kasan_populate_vmalloc:
mm/kasan/common.c:797:2: error: implicit declaration of function flush_cache_vmap; did you mean flush_rcu_work? [-Werror=implicit-function-declaration]
flush_cache_vmap(shadow_start, shadow_end);
^~~~~~~~~~~~~~~~
flush_rcu_work
cc1: some warnings being treated as errors
make[2]: *** [mm/kasan/common.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [mm/kasan] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [mm] Error 2
make: *** Waiting for unfinished jobs....
Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory")
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
mm/kasan/common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/kasan/common.c b/mm/kasan/common.c
index df3371d..2fa710b 100644
--- a/mm/kasan/common.c
+++ b/mm/kasan/common.c
@@ -36,6 +36,7 @@
#include <linux/bug.h>
#include <linux/uaccess.h>
+#include <asm/cacheflush.h>
#include <asm/tlbflush.h>
#include "kasan.h"
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm/kasan: Fix an compile error
2019-12-03 8:50 [PATCH] mm/kasan: Fix an compile error zhong jiang
@ 2019-12-03 23:06 ` Daniel Axtens
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Axtens @ 2019-12-03 23:06 UTC (permalink / raw)
To: zhong jiang, akpm; +Cc: aryabinin, glider, linux-mm
Hi,
Thanks, I see that Andrew has already picked this up, but for what it's
worth:
Reviewed-by: Daniel Axtens <dja@axtens.net>
Regards,
Daniel
> I hit the following compile error in arch/x86/
>
> mm/kasan/common.c: In function kasan_populate_vmalloc:
> mm/kasan/common.c:797:2: error: implicit declaration of function flush_cache_vmap; did you mean flush_rcu_work? [-Werror=implicit-function-declaration]
> flush_cache_vmap(shadow_start, shadow_end);
> ^~~~~~~~~~~~~~~~
> flush_rcu_work
> cc1: some warnings being treated as errors
> make[2]: *** [mm/kasan/common.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [mm/kasan] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [mm] Error 2
> make: *** Waiting for unfinished jobs....
>
> Fixes: 3c5c3cfb9ef4 ("kasan: support backing vmalloc space with real shadow memory")
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> mm/kasan/common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/kasan/common.c b/mm/kasan/common.c
> index df3371d..2fa710b 100644
> --- a/mm/kasan/common.c
> +++ b/mm/kasan/common.c
> @@ -36,6 +36,7 @@
> #include <linux/bug.h>
> #include <linux/uaccess.h>
>
> +#include <asm/cacheflush.h>
> #include <asm/tlbflush.h>
>
> #include "kasan.h"
> --
> 1.7.12.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-03 23:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 8:50 [PATCH] mm/kasan: Fix an compile error zhong jiang
2019-12-03 23:06 ` Daniel Axtens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).