From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CBF2C3403D for ; Tue, 18 Feb 2020 14:21:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 458AF2176D for ; Tue, 18 Feb 2020 14:21:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="pVwRuh4B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 458AF2176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E47D66B0003; Tue, 18 Feb 2020 09:21:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF8836B0006; Tue, 18 Feb 2020 09:21:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE5D76B0007; Tue, 18 Feb 2020 09:21:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id B109D6B0003 for ; Tue, 18 Feb 2020 09:21:03 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7F57C180AD802 for ; Tue, 18 Feb 2020 14:21:03 +0000 (UTC) X-FDA: 76503459606.29.table76_607b7875e3842 X-HE-Tag: table76_607b7875e3842 X-Filterd-Recvd-Size: 7275 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Feb 2020 14:21:02 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id a2so19554332qko.12 for ; Tue, 18 Feb 2020 06:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=oQ5uMvj46YJt8du9hHYIxA2AHiZ2qf4UtK0vshdPA7k=; b=pVwRuh4BaTn8YPjr2IxIwRAmmQKxPSCA61udn+YRyUJNFsLAVCbihPsf7i75uhUwbr +0fs1RaV4qLf9li0eukOM5+LEaNAwgkcriWirfC0RF6txXF1SBd8esVOjADSEoZO+Wr0 /X01M29q8Bi1V8jFSz2+vsig87KwPaoILhBOuAUkTvLaO+AZ7yOXfWej+eBeJXiLuyg7 FJGgckZGhgHDiGaof0+31va7N2CnPPuELXoWnsc1ctExVXUBp9Qbbxngeea1NHJmLFUa Fdpjgmod1Ih1wjBMZnE5deA9PivD7MmcRKe6cQoK6wOoF0Pc26hA+6PbHq5IdbLEtNDP pXhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=oQ5uMvj46YJt8du9hHYIxA2AHiZ2qf4UtK0vshdPA7k=; b=m9DrWjuZZ6CHvPSQGCJ2xtgZDRqUGZPhto/HKE75Guf3bf52tzHU/3W/PWnoSGJc9p htPmFLSNJ99s+JjushQPcGyoiWq1e3LsJayJelIkNmxtnlwsXUPLyryMaRNt6ajbjREH tfdaJaEZ2+HNxTvVdf4roo4gE2FWMsizOuV663jIFaaTDDbzR1iy/s4SIfhOyraQdpcN ByIDkiwg6S7Zb6yApPK59RQ2p+lsdBlj1nnIiutAohbTU1nD3zzWG1qe2zlXB0l9hwkX Ak8h712IPxz5w0EKTSE9WtmXWA1mVWEPPIw1Mns1T3qRqLCD4xIlEh9LUR5riFWdeckK a8HA== X-Gm-Message-State: APjAAAXmsOgZAyaa91gwrWDGjnQZD4NzBRT8MLoqx4snIEvoZWxTCiPd zfclUReu1yEUVQNkXeaxdY9P4g== X-Google-Smtp-Source: APXvYqzi+ZyeIa0ShCT4V+bcuLrOAzliPevTmxjHuIzAagLNkXUxzGqFIjS23L1FVBe5nLBjzfoN0w== X-Received: by 2002:a37:9186:: with SMTP id t128mr17685805qkd.180.1582035661956; Tue, 18 Feb 2020 06:21:01 -0800 (PST) Received: from dhcp-41-57.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id s8sm1936681qkm.88.2020.02.18.06.21.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Feb 2020 06:21:01 -0800 (PST) Message-ID: <1582035660.7365.90.camel@lca.pw> Subject: Re: [PATCH v12 1/9] hugetlb_cgroup: Add hugetlb_cgroup reservation counter From: Qian Cai To: Andrew Morton , Mina Almasry Cc: mike.kravetz@oracle.com, shuah@kernel.org, rientjes@google.com, shakeelb@google.com, gthelen@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org Date: Tue, 18 Feb 2020 09:21:00 -0500 In-Reply-To: <20200211151906.637d1703e4756066583b89da@linux-foundation.org> References: <20200211213128.73302-1-almasrymina@google.com> <20200211151906.637d1703e4756066583b89da@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 (3.22.6-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2020-02-11 at 15:19 -0800, Andrew Morton wrote: > On Tue, 11 Feb 2020 13:31:20 -0800 Mina Almasry wrote: >=20 > > These counters will track hugetlb reservations rather than hugetlb > > memory faulted in. This patch only adds the counter, following patche= s > > add the charging and uncharging of the counter. >=20 > We're still pretty thin on review here, but as it's v12 and Mike > appears to be signed up to look at this work, I'll add them to -next to > help move things forward. >=20 Reverted the whole series on the top of next-20200217 fixed a crash below= (I don't see anything in=C2=A0next-20200218 would make any differences). [ 7933.691114][T35046] LTP: starting hugemmap06 [ 7933.806377][T14355] ------------[ cut here ]------------ [ 7933.806541][T14355] kernel BUG at mm/hugetlb.c:490! VM_BUG_ON(t - f <=3D 1); [ 7933.806562][T14355] Oops: Exception in kernel mode, sig: 5 [#1] [ 7933.806573][T14355] LE PAGE_SIZE=3D64K MMU=3DRadix SMP NR_CPUS=3D256 DEBUG_PAGEALLOC NUMA PowerNV [ 7933.806594][T14355] Modules linked in: kvm_hv kvm brd ext4 crc16 mbcac= he jbd2 loop ip_tables x_tables xfs sd_mod bnx2x ahci mdio libahci tg3 libata lib= phy firmware_class dm_mirror dm_region_hash dm_log dm_mod [last unloaded: binfmt_misc] [ 7933.806651][T14355] CPU: 54 PID: 14355 Comm: hugemmap06 Tainted: G=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0O=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A05.6.0-rc2-next-20200217 #1 [ 7933.806674][T14355] NIP:=C2=A0=C2=A0c00000000040d22c LR: c00000000040d= 210 CTR: 0000000000000000 [ 7933.806696][T14355] REGS: c0000014b71ef660 TRAP: 0700=C2=A0=C2=A0=C2=A0= Tainted: G=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0O=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0(5.6.0-rc2-next-20200217) [ 7933.806727][T14355] MSR:=C2=A0=C2=A0900000000282b033 =C2=A0=C2=A0CR: 22022228=C2=A0=C2=A0X= ER: 00000000 [ 7933.806772][T14355] CFAR: c00000000040cbec IRQMASK: 0=C2=A0 [ 7933.806772][T14355] GPR00: c00000000040d210 c0000014b71ef8f0 c00000000= 1657000 0000000000000001=C2=A0 [ 7933.806772][T14355] GPR04: 0000000000000012 0000000000000013 000000000= 0000000 0000000000000000=C2=A0 [ 7933.806772][T14355] GPR08: 0000000000000002 0000000000000002 000000000= 0000001 0000000000000036=C2=A0 [ 7933.806772][T14355] GPR12: 0000000022022222 c000001ffffd3d00 00007fffa= d670000 00007fffa4bc0000=C2=A0 [ 7933.806772][T14355] GPR16: 0000000000000000 c000000001567178 c0000014b= 71efa50 0000000000000000=C2=A0 [ 7933.806772][T14355] GPR20: 0000000000000000 0000000000000013 000000000= 0000012 0000000000000001=C2=A0 [ 7933.806772][T14355] GPR24: c0000019f74cd270 5deadbeef0000100 5deadbeef= 0000122 c0000019f74cd2c0=C2=A0 [ 7933.806772][T14355] GPR28: 0000000000000001 c0000019f74cd268 c0000014b= 71ef918 0000000000000001=C2=A0 [ 7933.806961][T14355] NIP [c00000000040d22c] region_add+0x11c/0x3a0 [ 7933.806980][T14355] LR [c00000000040d210] region_add+0x100/0x3a0 [ 7933.807008][T14355] Call Trace: [ 7933.807024][T14355] [c0000014b71ef8f0] [c00000000040d210] region_add+0x100/0x3a0 (unreliable) [ 7933.807056][T14355] [c0000014b71ef9b0] [c00000000040e0c8] __vma_reservation_common+0x148/0x210 __vma_reservation_common at mm/hugetlb.c:2150 [ 7933.807087][T14355] [c0000014b71efa20] [c0000000004132a0] alloc_huge_page+0x350/0x830 alloc_huge_page at mm/hugetlb.c:2359 [ 7933.807100][T14355] [c0000014b71efad0] [c0000000004168f8] hugetlb_no_page+0x158/0xcb0 [ 7933.807113][T14355] [c0000014b71efc20] [c000000000417bc8] hugetlb_fault+0x678/0xb30 [ 7933.807136][T14355] [c0000014b71efcd0] [c0000000003b1de4] handle_mm_fault+0x444/0x450 [ 7933.807158][T14355] [c0000014b71efd20] [c000000000070b1c] __do_page_fault+0x2bc/0xfd0 [ 7933.807181][T14355] [c0000014b71efe20] [c00000000000aa88] handle_page_fault+0x10/0x30 [ 7933.807201][T14355] Instruction dump: [ 7933.807209][T14355] 38c00000 7ea5ab78 7ec4b378 7fa3eb78 4bfff80d e9210= 020 e91d0050 e95d0068=C2=A0 [ 7933.807232][T14355] 7d3c4850 7d294214 7faa4800 409c0238 <0b170000> 7f0= 3c378 4858c005 60000000=C2=A0 [ 7933.807267][T14355] ---[ end trace 7560275de5f409f8 ]--- [ 7933.905258][T14355]=C2=A0 [ 7934.905339][T14355] Kernel panic - not syncing: Fatal exception