From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3AAC4332B for ; Sun, 22 Mar 2020 13:59:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3676920637 for ; Sun, 22 Mar 2020 13:59:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GGhPPEd0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3676920637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B21E6B0005; Sun, 22 Mar 2020 09:59:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 962BB6B0006; Sun, 22 Mar 2020 09:59:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 852496B0007; Sun, 22 Mar 2020 09:59:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 69ECF6B0005 for ; Sun, 22 Mar 2020 09:59:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1E95E4995ED for ; Sun, 22 Mar 2020 13:59:37 +0000 (UTC) X-FDA: 76623155994.26.toe76_53eedb05c9133 X-HE-Tag: toe76_53eedb05c9133 X-Filterd-Recvd-Size: 4350 Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Sun, 22 Mar 2020 13:59:36 +0000 (UTC) Received: by mail-pj1-f65.google.com with SMTP id q16so4867053pje.1 for ; Sun, 22 Mar 2020 06:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ErbU1Pl3FyoNVgMmAuU1geFNdNYAU7fQOVTZXUK989o=; b=GGhPPEd0/rE7OgSdG2SeTPCquWkn/lshOxcSq+O00WhJIWaKA5xqto8+VohswQi2pu ZPgM5QN1GGnbeuLByWewMiymfZ936/miT3jEi1ls8pKMJekWvkKXn0Z26PTODZJw4bz0 moVbW4i9z69G/z/OKQFjG4q6ZcLQv+J1Se606MWhLVm0ykzl0J/sEbSWY3gfqq98Z2MA KFlWHCFQhVYCFIXzY2qYVpqJ/4Z0JzRxtAAXqrwb3mkVh/LOy4/KyD38oij1T6vPBtEt uDDn/nOne6PmnxFdDGDrv8mqNoWaRJFqtfRVq281X2nBpXUSaP40AHW41r2POjVEfjNJ cAMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ErbU1Pl3FyoNVgMmAuU1geFNdNYAU7fQOVTZXUK989o=; b=qqc4Hax11pbMeZqSqlRq1gd/WHotfVj0fYIf+GvBeYj8LOaIyuz4lmp1LdF7uGSDNI eeYZWvDrglDJYGXGxv7qT03ZBeE1x+w3X17jDCkzM2MDaa+mJM/mlVFc2Yv45NnJSOdG SwHZW727zmkMmRO8IAGGUzrrwvhA2BPgESSufVLEA5ChKTWpnma4+W1yUnXydFSyvtYF Hege7r6aHKJ+g3EBcF9Dm877tghchekegCjn0buZlaLjNqT6zPAL9SWyLe6V4lDA5D+y 1ahBKeheoo+rcctVV/qox8WDoO2swtgjkgALJ55HQHlphsvJVs4ftz0ovIRcs1cVl2kE Pt/A== X-Gm-Message-State: ANhLgQ0d5zrOolbq50HGsaTFcPRQG5sV0b8xO21tEGcgzJYnsaGoauhq k8XG7dhYU9qm9ivu1kOAV+5YJlc= X-Google-Smtp-Source: ADFU+vtAQHxPOhZgk2fRmPzxQqGFhDKvDpFS+cvDtPZgoqLYxKKvY7Xzgm5Uh1lXBthZwwaHrSvyJA== X-Received: by 2002:a17:90a:1954:: with SMTP id 20mr20715462pjh.106.1584885575278; Sun, 22 Mar 2020 06:59:35 -0700 (PDT) Received: from mylaptop.redhat.com ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id mu15sm1707595pjb.30.2020.03.22.06.59.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Mar 2020 06:59:34 -0700 (PDT) From: Pingfan Liu To: linux-mm@kvack.org Cc: Pingfan Liu , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Michal Hocko , John Hubbard , "Kirill A . Shutemov" , Aneesh Kumar , Andrew Morton Subject: [PATCH] mm/rmap: fix the handling of device private page in try_to_unmap_one() Date: Sun, 22 Mar 2020 21:57:07 +0800 Message-Id: <1584885427-4952-1-git-send-email-kernelfans@gmail.com> X-Mailer: git-send-email 2.7.5 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: For zone_device, migration can only happen on is_device_private_page(page= ). Correct the logic in try_to_unmap_one(). Signed-off-by: Pingfan Liu Cc: J=C3=A9r=C3=B4me Glisse Cc: Michal Hocko Cc: John Hubbard Cc: Kirill A. Shutemov Cc: Aneesh Kumar Cc: Andrew Morton To: linux-mm@kvack.org --- mm/rmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/rmap.c b/mm/rmap.c index b838647..ffadf3e 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1380,7 +1380,7 @@ static bool try_to_unmap_one(struct page *page, str= uct vm_area_struct *vma, if (IS_ENABLED(CONFIG_MIGRATION) && (flags & TTU_MIGRATION) && is_zone_device_page(page) && !is_device_private_page(page)) - return true; + return false; if (flags & TTU_SPLIT_HUGE_PMD) { split_huge_pmd_address(vma, address, @@ -1487,7 +1487,7 @@ static bool try_to_unmap_one(struct page *page, str= uct vm_area_struct *vma, if (IS_ENABLED(CONFIG_MIGRATION) && (flags & TTU_MIGRATION) && - is_zone_device_page(page)) { + is_device_private_page(page)) { swp_entry_t entry; pte_t swp_pte; -- 2.7.5