From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4AEC3A5A0 for ; Mon, 20 Apr 2020 08:01:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D667B206D5 for ; Mon, 20 Apr 2020 08:01:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W4H+9z7K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D667B206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8580C8E000E; Mon, 20 Apr 2020 04:01:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E0F18E0003; Mon, 20 Apr 2020 04:01:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A9C08E000E; Mon, 20 Apr 2020 04:01:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 52A4A8E0003 for ; Mon, 20 Apr 2020 04:01:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1406A180AD83E for ; Mon, 20 Apr 2020 08:01:07 +0000 (UTC) X-FDA: 76727487774.09.mom65_6103dad9a9c3d X-HE-Tag: mom65_6103dad9a9c3d X-Filterd-Recvd-Size: 4199 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 08:01:06 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id np9so4219606pjb.4 for ; Mon, 20 Apr 2020 01:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3sIc/9DDAXKMYRBsv64/To7rDNyZRnaOfPvxZnOJWw0=; b=W4H+9z7KpXVaJoSsLGidF0McaGPT/JauXtbjVyABdYzu78ZKOjCTK+mQ6b28MkRA9M ZcdVu+Gt+H2BiYtsZ9IbBef+c3FdwRJ/VbeMPC9s62wlMA4oY4S8i5JZrRkBUinh05gY kBXBV7FFzDJOPUCTfWbO7D+kuk5t7Ch4XYJsaA2GBu6roPdoGq+doypS+LmDGK7t2tFJ sYXjv1BUogESKtLi6d7znXOFetnpn0/V00wIlxhx0ZY3XA2DfQpas0L7IePNeYfnYCaT fytNPBIoIhh9L5NIJaB0PCCbQOegkEaTSRFddqLQHKLRtn7KoSPmcnJsjJfa7D172psD q7ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3sIc/9DDAXKMYRBsv64/To7rDNyZRnaOfPvxZnOJWw0=; b=hPay6+8iMpRJ+cQpITmQyKn8nei2mnAKe/DOSzZ8aChs9XVjdRLatbuRsyCzqb232M O0w1dsAu7Y2L7gBv1bpA6s6pQ548szZcVUPPW9jEDLzepQOqfyNtfgWxu2uROv3iuTvr Uq0xE9CGO16AJtnSdFfsSnXaTP3x844sFE6+78pSP6PFE9l5Y6xig2mDeaQWp48Wg3iN m93WohJE6ZVuj9JUTfiVC2vjTT9ydUnOTm0MZrmPSL0yKuxZWgkZdxAb2pZHNqrLHamW +zH3QONb6MEJ3dGnA5MB+QTNQU1/5beH7YgIBwb6VDr/gISujpcE30beFVaBMCJH/bK6 3RbA== X-Gm-Message-State: AGi0PuYLuVxi0qarbNCjML29bbl+RtTD6kCj/mDEGdQAuaBkKFoFQcjE glxTFqY9rjB8d8Gz1/kaDl4= X-Google-Smtp-Source: APiQypI/6Iexa+qCAwULiej30HBrZEEGi/rV7BS4Iy8tksx1e9x7E71opNFYjhiSnCXV0czZ53bGtg== X-Received: by 2002:a17:902:20b:: with SMTP id 11mr14153835plc.209.1587369665788; Mon, 20 Apr 2020 01:01:05 -0700 (PDT) Received: from localhost.localdomain ([114.206.198.176]) by smtp.gmail.com with ESMTPSA id n9sm314947pjt.29.2020.04.20.01.01.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2020 01:01:05 -0700 (PDT) From: js1304@gmail.com X-Google-Original-From: iamjoonsoo.kim@lge.com To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , Joonsoo Kim Subject: [PATCH 09/10] mm/page_alloc: correct the use of is_highmem_idx() Date: Mon, 20 Apr 2020 16:59:41 +0900 Message-Id: <1587369582-3882-10-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1587369582-3882-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1587369582-3882-1-git-send-email-iamjoonsoo.kim@lge.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Joonsoo Kim What we'd like to check here is whether page has direct mapping or not. Use PageHighMem() since it is perfectly matched for this purpose. Signed-off-by: Joonsoo Kim --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 9997f87..e07148d 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1399,7 +1399,7 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn, INIT_LIST_HEAD(&page->lru); #ifdef WANT_PAGE_VIRTUAL /* The shift won't overflow because ZONE_NORMAL is below 4G. */ - if (!is_highmem_idx(zone)) + if (!PageHighMem(page)) set_page_address(page, __va(pfn << PAGE_SHIFT)); #endif } -- 2.7.4