From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD2DC54FCC for ; Tue, 21 Apr 2020 14:34:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E6CA20656 for ; Tue, 21 Apr 2020 14:34:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wy08LnTG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E6CA20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D40D8E0007; Tue, 21 Apr 2020 10:34:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05F128E0003; Tue, 21 Apr 2020 10:34:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E68438E0007; Tue, 21 Apr 2020 10:34:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id CEBA88E0003 for ; Tue, 21 Apr 2020 10:34:31 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9EF0A4DCF for ; Tue, 21 Apr 2020 14:34:31 +0000 (UTC) X-FDA: 76732107942.19.room18_61b2f9a641f35 X-HE-Tag: room18_61b2f9a641f35 X-Filterd-Recvd-Size: 3580 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Tue, 21 Apr 2020 14:34:31 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id ay1so5312398plb.0 for ; Tue, 21 Apr 2020 07:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=C8Mrw9X7edKDmqL+8VPf+gpjxoJPqohW+isJAL0j8Lo=; b=Wy08LnTGTxdZ4nKdhu0m2wtwHXruJLdPruiRIeqvE8V/1+3cB2W/UNgO1wiqo5AR48 yQUOZfzw98sSK/cOBXGlnV+HyXT9BRn4FColV3RxfG5bcJ/yItIPnN+Pne4UeHRCY/YR xvTyDsGY2zy4TYR3uOylMhnbAqLBtDXw7NQss3fBevEj2Jwu4GBQTVDj6eH8dIbOglNH RvZDMkJMD9262HJVJC6yCyq/sedo5X+e940B5uxLYwZnzDcRLL+0ZK8qNQSofhxcn9MP 6/2mACb6+CqAxPtCX3/2wsMC9CXQOK5A2AES1z7OYEpos8qcaHRCQg5Cb2owS8uG6/qC AKTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=C8Mrw9X7edKDmqL+8VPf+gpjxoJPqohW+isJAL0j8Lo=; b=cTkcrplFrq8KGtAZqSuIYBU6w71oI9KfXkTo/8n7aEh2Hg3evpvFH8dqhtIGjaWHMl 6f/D8CLlMwiE+4Ao7LTSKkvLGSE84s/xJ+Szr6hqyoEFYic7cw2pkNzBJoFFJri4nD49 gpRfjuRtzou75+3yFqVOwd+9BK8rX1QoilYb50GU9pQIvZQFwrz/U6WAFouBusYmeaAl Iz820b8xDuOCAd+bpT21Ou5W5i7g9ARtikBgmqKDRxwzAhffO3mYdrBzXC0FZUWJ5mnl rMMXqtunLB+qbMQIfC6hNH++KR0QlEHn7dIaY6ZGvcUykhBQWtCqZHdh2Q6HzhM+NaRz 4OGA== X-Gm-Message-State: AGi0PuZtJg7sqJCXgThnd9IsukXg1HsBJx2YILFi5iIBJGeR/QuI1qx/ aUW02ZqqA8/nNs6aQNezXg== X-Google-Smtp-Source: APiQypI1GRSN6GLXm1QaHoKkGwizILD7HAjt4DsFxd5b1xEy8ebSE8N/SHsBbPiFwWhQvxvrL1/cIQ== X-Received: by 2002:a17:902:6a88:: with SMTP id n8mr21686971plk.292.1587479670349; Tue, 21 Apr 2020 07:34:30 -0700 (PDT) Received: from he-cluster.localdomain ([67.216.221.250]) by smtp.gmail.com with ESMTPSA id v64sm705762pfb.20.2020.04.21.07.34.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2020 07:34:29 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com Cc: linux-mm@kvack.org, Kaixu Xia Subject: [PATCH] mm: memcontrol: simplify value comparison between count and limit Date: Tue, 21 Apr 2020 22:34:21 +0800 Message-Id: <1587479661-27237-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia When the variables count and limit have the same value(count == limit), the result of min(margin, limit - count) statement should be 0 and the variable margin is set to 0. So in this case, the min() statement is not necessary and we can directly set the variable margin to 0. Signed-off-by: Kaixu Xia --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 5beea03dd58a..fedc5afdc482 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1314,7 +1314,7 @@ static unsigned long mem_cgroup_margin(struct mem_cgroup *memcg) if (do_memsw_account()) { count = page_counter_read(&memcg->memsw); limit = READ_ONCE(memcg->memsw.max); - if (count <= limit) + if (count < limit) margin = min(margin, limit - count); else margin = 0; -- 2.20.0