From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493A1C83001 for ; Wed, 29 Apr 2020 03:27:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 05B162068E for ; Wed, 29 Apr 2020 03:27:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X7xH1293" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05B162068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9EEF18E000D; Tue, 28 Apr 2020 23:27:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99E948E0001; Tue, 28 Apr 2020 23:27:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88E018E000D; Tue, 28 Apr 2020 23:27:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id 705508E0001 for ; Tue, 28 Apr 2020 23:27:41 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2312E824999B for ; Wed, 29 Apr 2020 03:27:41 +0000 (UTC) X-FDA: 76759457922.24.brush11_7d43aa2378536 X-HE-Tag: brush11_7d43aa2378536 X-Filterd-Recvd-Size: 4311 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 03:27:40 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id x77so446888pfc.0 for ; Tue, 28 Apr 2020 20:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jN6OWGZfzhz5cy8NH2EykEDo9H91RlV0Cb10AXbRh+4=; b=X7xH1293dienMFUF4Cx9EMFvcB0WqWvKSdXLSakGPz9VAaJgR5Rp27zddaF/mgBDWJ jueccWhjSMYdgmbHtRyzWn7s3QmL+K7gxIsAWZdL/KoIlDZICUr1kKmqxW8pBuvLxo3M hMm9lL77QLGsa5xpvuGlaOin3uwvSqolrCIiw4WVLuakiZNZBeg/nQEMNYhlcbw3OJVd 62Ukj+wbkKaaSNlrnnexEedfYZDoAp5dmdkltB9GFzrEnQiv0H720MbDH2oOUTsX/FIb l9EwFJu7W8HYh/UIqUDaR5FvacZnO6I7X5qH7gzSiye3TYD7Jwk+dBBJlk+/rKxG52s3 NieA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jN6OWGZfzhz5cy8NH2EykEDo9H91RlV0Cb10AXbRh+4=; b=diaRFf0hsomglLBrs6+bTGsC6voUsz+9PekBHQalwioIj99dcRfzVfYkbHe/7yEAQH Ap+QT4vm6s3Nna/7bgzqMulcpp3I1nfFomLzxuwnm3MLdy+BdkpMMomK1SjGsTPht+QC /KTNaTNRDAOoflSXNOhEAlxDUYYkhWtDDIZi03WdlkjZ4a4hK4vEDFpz76rH6hKR6VFy i9kUPeuaLMxLZWsngs0GPMRAfSdExTYnSEja+iwPkX7vHMppZJzL5sjVaaBL3iCl51ow MRs14M9UpUX4emNK3NEWF6ZjCTA6NOQmGM8ZWREhgjfwtTrO/MYXpXYmoKBQ1Cj1qT8p WVgA== X-Gm-Message-State: AGi0PuYhJC442T0BvLmHWS646YcgU8VP0eWVHaOcixwNxVlnaKqDR9ia i2mY0w10XMI4PAqz+6IY8E8= X-Google-Smtp-Source: APiQypInVbH7ylHMhU07Tfmqu8yaakpX3/HbtkY8RGK6W+4l2MkEeAn29ptQFf/Lvq2iASEnh+35qw== X-Received: by 2002:a62:e113:: with SMTP id q19mr32206900pfh.107.1588130859931; Tue, 28 Apr 2020 20:27:39 -0700 (PDT) Received: from localhost.localdomain ([114.206.198.176]) by smtp.gmail.com with ESMTPSA id q11sm9559796pfl.97.2020.04.28.20.27.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Apr 2020 20:27:39 -0700 (PDT) From: js1304@gmail.com X-Google-Original-From: iamjoonsoo.kim@lge.com To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , kernel-team@lge.com, Christoph Hellwig , Joonsoo Kim Subject: [PATCH v2 08/10] mm/page_alloc: correct the use of is_highmem_idx() Date: Wed, 29 Apr 2020 12:26:41 +0900 Message-Id: <1588130803-20527-9-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Joonsoo Kim What we'd like to check here is whether page has direct mapping or not. Use PageHighMem() since it is perfectly matched for this purpose. Acked-by: Roman Gushchin Signed-off-by: Joonsoo Kim --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7fe5115..da473c7 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1399,7 +1399,7 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn, INIT_LIST_HEAD(&page->lru); #ifdef WANT_PAGE_VIRTUAL /* The shift won't overflow because ZONE_NORMAL is below 4G. */ - if (!is_highmem_idx(zone)) + if (!PageHighMem(page)) set_page_address(page, __va(pfn << PAGE_SHIFT)); #endif } -- 2.7.4