From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0DFBC433E0 for ; Thu, 21 May 2020 18:57:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B542207D3 for ; Thu, 21 May 2020 18:57:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B542207D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA9218000A; Thu, 21 May 2020 14:57:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7E1380007; Thu, 21 May 2020 14:57:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D938A8000A; Thu, 21 May 2020 14:57:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id C3E6080007 for ; Thu, 21 May 2020 14:57:47 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 93FB64DBC for ; Thu, 21 May 2020 18:57:47 +0000 (UTC) X-FDA: 76841635374.12.apple56_43f4b1692474e X-HE-Tag: apple56_43f4b1692474e X-Filterd-Recvd-Size: 4072 Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 18:57:46 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 21252267-1500050 for multiple; Thu, 21 May 2020 19:57:36 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200519002124.2025955-1-jhubbard@nvidia.com> References: <20200519002124.2025955-1-jhubbard@nvidia.com> To: Andrew Morton , John Hubbard Cc: Souptick Joarder , Matthew Wilcox , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Tvrtko Ursulin , Matthew Auld , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, LKML , linux-mm@kvack.org, John Hubbard From: Chris Wilson Subject: Re: [PATCH 0/4] mm/gup, drm/i915: refactor gup_fast, convert to pin_user_pages() Message-ID: <159008745422.32320.5724805750977048669@build.alporthouse.com> User-Agent: alot/0.8.1 Date: Thu, 21 May 2020 19:57:34 +0100 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Quoting John Hubbard (2020-05-19 01:21:20) > This needs to go through Andrew's -mm tree, due to adding a new gup.c > routine. However, I would really love to have some testing from the > drm/i915 folks, because I haven't been able to run-time test that part > of it. CI hit <4> [185.667750] WARNING: CPU: 0 PID: 1387 at mm/gup.c:2699 internal_get_us= er_pages_fast+0x63a/0xac0 <4> [185.667752] Modules linked in: vgem snd_hda_codec_hdmi snd_hda_codec_r= ealtek snd_hda_codec_generic i915 mei_hdcp x86_pkg_temp_thermal coretemp sn= d_hda_intel snd_intel_dspcfg crct10dif_pclmul snd_hda_codec crc32_pclmul sn= d_hwdep snd_hda_core ghash_clmulni_intel cdc_ether usbnet mii snd_pcm e1000= e mei_me ptp pps_core mei intel_lpss_pci prime_numbers <4> [185.667774] CPU: 0 PID: 1387 Comm: gem_userptr_bli Tainted: G U = 5.7.0-rc5-CI-Patchwork_17704+ #1 <4> [185.667777] Hardware name: Intel Corporation Ice Lake Client Platform/= IceLake U DDR4 SODIMM PD RVP, BIOS ICLSFWR1.R00.3234.A01.1906141750 06/14/2= 019 <4> [185.667782] RIP: 0010:internal_get_user_pages_fast+0x63a/0xac0 <4> [185.667785] Code: 24 40 08 48 39 5c 24 38 49 89 df 0f 85 74 fc ff ff 4= 8 83 44 24 50 08 48 39 5c 24 58 49 89 dc 0f 85 e0 fb ff ff e9 14 fe ff ff <= 0f> 0b b8 ea ff ff ff e9 36 fb ff ff 4c 89 e8 48 21 e8 48 39 e8 0f <4> [185.667789] RSP: 0018:ffffc90001133c38 EFLAGS: 00010206 <4> [185.667792] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff88849= 99ee800 <4> [185.667795] RDX: 00000000000c0001 RSI: 0000000000000100 RDI: 00007f419= e774000 <4> [185.667798] RBP: ffff888453dbf040 R08: 0000000000000000 R09: 000000000= 0000001 <4> [185.667800] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88845= 3dbf380 <4> [185.667803] R13: ffff8884999ee800 R14: ffff888453dbf3e8 R15: 000000000= 0000040 <4> [185.667806] FS: 00007f419e875e40(0000) GS:ffff88849fe00000(0000) knlG= S:0000000000000000 <4> [185.667808] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [185.667811] CR2: 00007f419e873000 CR3: 0000000458bd2004 CR4: 000000000= 0760ef0 <4> [185.667814] PKRU: 55555554 <4> [185.667816] Call Trace: <4> [185.667912] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.667918] ? mark_held_locks+0x49/0x70 <4> [185.667998] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] <4> [185.668073] ? i915_gem_userptr_get_pages+0x1c6/0x290 [i915] and then panicked, across a range of systems. -Chris