From: Alex Shi <alex.shi@linux.alibaba.com>
To: akpm@linux-foundation.org, mgorman@techsingularity.net,
tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru,
daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com,
willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, shakeelb@google.com,
iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com
Cc: Alex Shi <alex.shi@linux.alibaba.com>
Subject: [PATCH v15 03/21] mm/compaction: correct the comments of compact_defer_shift
Date: Tue, 7 Jul 2020 19:46:35 +0800 [thread overview]
Message-ID: <1594122412-28057-4-git-send-email-alex.shi@linux.alibaba.com> (raw)
In-Reply-To: <1594122412-28057-1-git-send-email-alex.shi@linux.alibaba.com>
There is no compact_defer_limit. It should be compact_defer_shift in
use. and add compact_order_failed explanation.
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/mmzone.h | 1 +
mm/compaction.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index f6f884970511..14c668b7e793 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -512,6 +512,7 @@ struct zone {
* On compaction failure, 1<<compact_defer_shift compactions
* are skipped before trying again. The number attempted since
* last failure is tracked with compact_considered.
+ * compact_order_failed is the minimum compaction failed order.
*/
unsigned int compact_considered;
unsigned int compact_defer_shift;
diff --git a/mm/compaction.c b/mm/compaction.c
index 86375605faa9..cd1ef9e5e638 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -136,7 +136,7 @@ void __ClearPageMovable(struct page *page)
/*
* Compaction is deferred when compaction fails to result in a page
- * allocation success. 1 << compact_defer_limit compactions are skipped up
+ * allocation success. compact_defer_shift++, compactions are skipped up
* to a limit of 1 << COMPACT_MAX_DEFER_SHIFT
*/
void defer_compaction(struct zone *zone, int order)
--
1.8.3.1
next prev parent reply other threads:[~2020-07-07 11:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 11:46 [PATCH v15 00/20] per memcg lock Alex Shi
2020-07-07 11:46 ` [PATCH v15 01/21] mm/vmscan: remove unnecessary lruvec adding Alex Shi
2020-07-07 11:46 ` [PATCH v15 02/21] mm/page_idle: no unlikely double check for idle page counting Alex Shi
2020-07-07 11:46 ` Alex Shi [this message]
2020-07-07 11:46 ` [PATCH v15 04/21] mm/compaction: rename compact_deferred as compact_should_defer Alex Shi
2020-07-07 11:46 ` [PATCH v15 05/21] mm/thp: move lru_add_page_tail func to huge_memory.c Alex Shi
2020-07-07 12:00 ` Alex Shi
2020-07-09 15:55 ` Kirill A. Shutemov
2020-07-07 11:46 ` [PATCH v15 06/21] mm/thp: clean up lru_add_page_tail Alex Shi
2020-07-07 11:46 ` [PATCH v15 07/21] mm/thp: narrow lru locking Alex Shi
2020-07-07 11:46 ` [PATCH v15 08/21] mm/memcg: add debug checking in lock_page_memcg Alex Shi
2020-07-07 11:46 ` [PATCH v15 09/21] mm/swap: fold vm event PGROTATED into pagevec_move_tail_fn Alex Shi
2020-07-07 11:46 ` [PATCH v15 10/21] mm/lru: move lru_lock holding in func lru_note_cost_page Alex Shi
2020-07-07 11:46 ` [PATCH v15 11/21] mm/lru: move lock into lru_note_cost Alex Shi
2020-07-07 11:46 ` [PATCH v15 12/21] mm/lru: introduce TestClearPageLRU Alex Shi
2020-07-07 11:46 ` [PATCH v15 13/21] mm/compaction: do page isolation first in compaction Alex Shi
2020-07-07 11:46 ` [PATCH v15 14/21] mm/mlock: reorder isolation sequence during munlock Alex Shi
2020-07-07 11:46 ` [PATCH v15 15/21] mm/swap: serialize memcg changes during pagevec_lru_move_fn Alex Shi
2020-07-07 11:46 ` [PATCH v15 16/21] mm/lru: replace pgdat lru_lock with lruvec lock Alex Shi
2020-07-07 11:46 ` [PATCH v15 17/21] mm/lru: introduce the relock_page_lruvec function Alex Shi
2020-07-07 11:46 ` [PATCH v15 18/21] mm/vmscan: use relock for move_pages_to_lru Alex Shi
2020-07-07 11:46 ` [PATCH v15 19/21] mm/pgdat: remove pgdat lru_lock Alex Shi
2020-07-07 11:46 ` [PATCH v15 20/21] mm/lru: revise the comments of lru_lock Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594122412-28057-4-git-send-email-alex.shi@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=daniel.m.jordan@oracle.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mgorman@techsingularity.net \
--cc=richard.weiyang@gmail.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).