From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8BE0C433E3 for ; Fri, 21 Aug 2020 11:38:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 35A452078B for ; Fri, 21 Aug 2020 11:38:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35A452078B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B04F66B000A; Fri, 21 Aug 2020 07:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB59B6B000C; Fri, 21 Aug 2020 07:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CC146B000D; Fri, 21 Aug 2020 07:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 852A36B000A for ; Fri, 21 Aug 2020 07:38:36 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3CE83181AEF0B for ; Fri, 21 Aug 2020 11:38:36 +0000 (UTC) X-FDA: 77174378232.14.coach19_451130827038 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 0C0A618229835 for ; Fri, 21 Aug 2020 11:38:36 +0000 (UTC) X-HE-Tag: coach19_451130827038 X-Filterd-Recvd-Size: 2616 Received: from fireflyinternet.com (unknown [77.68.26.236]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Fri, 21 Aug 2020 11:38:35 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 22197337-1500050 for multiple; Fri, 21 Aug 2020 12:38:05 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <159800635942.29194.13489565974587679781@build.alporthouse.com> References: <20200821085011.28878-1-chris@chris-wilson.co.uk> <20200821100902.GG3354@suse.de> <159800481672.29194.17217138842959831589@build.alporthouse.com> <20200821102343.GI3354@suse.de> <159800635942.29194.13489565974587679781@build.alporthouse.com> Subject: Re: [PATCH] mm: Track page table modifications in __apply_to_page_range() construction From: Chris Wilson Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, Pavel Machek , Andrew Morton , Linus Torvalds , Dave Airlie , Joonas Lahtinen , Rodrigo Vivi , David Vrabel , stable@vger.kernel.org To: Joerg Roedel Date: Fri, 21 Aug 2020 12:38:03 +0100 Message-ID: <159800988352.29194.8498025838223804532@build.alporthouse.com> User-Agent: alot/0.9 X-Rspamd-Queue-Id: 0C0A618229835 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Quoting Chris Wilson (2020-08-21 11:39:19) > Quoting Joerg Roedel (2020-08-21 11:23:43) > > On Fri, Aug 21, 2020 at 11:13:36AM +0100, Chris Wilson wrote: > > > We need to store the initial addr, as here addr =3D=3D end [or earlie= r on > > > earlier], so range is (start, addr). > >=20 > > Right, I missed that, thanks for pointing it out. >=20 > And with that (start, addr) >=20 > Tested-by: Chris Wilson #x86-32 In the version I tested, I also had @@ -2216,7 +2216,7 @@ static int apply_to_pte_range(struct mm_struct *mm, p= md_t *pmd, if (create) { pte =3D (mm =3D=3D &init_mm) ? - pte_alloc_kernel(pmd, addr) : + pte_alloc_kernel_track(pmd, addr, mask) : pte_alloc_map_lock(mm, pmd, addr, &ptl); if (!pte) return -ENOMEM; And that PGTBL_PMD_MODIFIED makes a difference. -Chris