From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04684C56202 for ; Mon, 23 Nov 2020 14:03:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5E48120782 for ; Mon, 23 Nov 2020 14:03:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="a+WKgWhm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E48120782 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8A89D6B0085; Mon, 23 Nov 2020 09:03:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 831EB6B0087; Mon, 23 Nov 2020 09:03:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F9416B0088; Mon, 23 Nov 2020 09:03:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id 441766B0085 for ; Mon, 23 Nov 2020 09:03:53 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4A091181AEF21 for ; Mon, 23 Nov 2020 14:03:52 +0000 (UTC) X-FDA: 77515851504.23.rail81_240edd927366 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 30FAE37606 for ; Mon, 23 Nov 2020 14:03:52 +0000 (UTC) X-HE-Tag: rail81_240edd927366 X-Filterd-Recvd-Size: 4122 Received: from z5.mailgun.us (z5.mailgun.us [104.130.96.5]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Nov 2020 14:03:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606140231; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=GMDPBCCMonm9madELgXD+35QPE+dhBMWpkpv8t4h7ZA=; b=a+WKgWhmN/meiv/P884vlUPa4g8v+at0eKYbVtXf6BGVQlPVkw60gfUQz9UJepixC4BcdYDd g4xG0tCQkfJcEjC/6jzt1kWd6samImCJHn06iRj0V9uXr5GbO4n2XV1bl1wVeRryz2fN75MJ 8dspnq1Ieuhk4HQpvth4PEVyPqM= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-west-2.postgun.com with SMTP id 5fbbc146eb04c00160c86ebc (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 23 Nov 2020 14:03:50 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9A4C3C43463; Mon, 23 Nov 2020 14:03:50 +0000 (UTC) Received: from charante-linux.qualcomm.com (unknown [202.46.22.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: charante) by smtp.codeaurora.org (Postfix) with ESMTPSA id 11605C433C6; Mon, 23 Nov 2020 14:03:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 11605C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=charante@codeaurora.org From: Charan Teja Reddy To: akpm@linux-foundation.org, david@redhat.com, mhocko@suse.com, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Charan Teja Reddy Subject: [PATCH] mm: memory_hotplug: put migration failure information under DEBUG_VM Date: Mon, 23 Nov 2020 19:33:16 +0530 Message-Id: <1606140196-6053-1-git-send-email-charante@codeaurora.org> X-Mailer: git-send-email 2.7.4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When the pages are failed to get isolate or migrate, the page owner information along with page info is dumped. If there are continuous failures in migration(say page is pinned) or isolation, the log buffer is simply getting flooded with the page owner information. As most of the times page info is sufficient to know the causes for failures of migration or isolation, place the page owner information under DEBUG_VM. Signed-off-by: Charan Teja Reddy --- mm/memory_hotplug.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 63b2e46..f48f30d 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1326,7 +1326,10 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) } else { pr_warn("failed to isolate pfn %lx\n", pfn); - dump_page(page, "isolation failed"); + __dump_page(page, "isolation failed"); +#if defined(CONFIG_DEBUG_VM) + dump_page_owner(page); +#endif } put_page(page); } @@ -1357,7 +1360,10 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) list_for_each_entry(page, &source, lru) { pr_warn("migrating pfn %lx failed ret:%d ", page_to_pfn(page), ret); - dump_page(page, "migration failure"); + __dump_page(page, "migration failure"); +#if defined(CONFIG_DEBUG_VM) + dump_page_owner(page); +#endif } putback_movable_pages(&source); } -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation