From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 252B3C433E0 for ; Wed, 3 Feb 2021 03:01:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 99A1264F49 for ; Wed, 3 Feb 2021 03:01:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99A1264F49 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E7DA06B0006; Tue, 2 Feb 2021 22:01:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2C1C6B006C; Tue, 2 Feb 2021 22:01:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41A36B006E; Tue, 2 Feb 2021 22:01:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id BBAF46B0006 for ; Tue, 2 Feb 2021 22:01:55 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7399D180AD802 for ; Wed, 3 Feb 2021 03:01:55 +0000 (UTC) X-FDA: 77775456990.23.map30_2009e32275d0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 5804937604 for ; Wed, 3 Feb 2021 03:01:55 +0000 (UTC) X-HE-Tag: map30_2009e32275d0 X-Filterd-Recvd-Size: 4540 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Feb 2021 03:01:54 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id z9so3688795pjl.5 for ; Tue, 02 Feb 2021 19:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=1D1lbt3Rz38vk3ZD1aJTQKM02Emv7JinCawTwnh8mas=; b=sjnb/xpg2f3ib4neVS501ZZ2+5QYiUqICTfujzksFFyQvYH9TTRQ1OHrQ42QsKAXSw bYeMWQeeyhhJ2MqhVAjE/WET+Lr0Z5huKLrYJ8ysoXbZDvjSBYqrbZV2uDM/7yce2mp4 xqiKORJgRDQ2BObp815Hkg/jms8ML0Waag35kaQiy4qmqOHdGz92PvVy8Q7IB/VJMguq lHOoJy5FAmrj4d4B6yT8Dc98F4Lvm3ysZk3pWiatccBV6pgOgdhhBhtMFa3uP5o4RDHo MYU9ebBwx4j4daf2bNPsakaE9OJcuDEYdJ07eo99qx2mYqdjYpE59yOSMBlWXXOBZ5ui FWsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=1D1lbt3Rz38vk3ZD1aJTQKM02Emv7JinCawTwnh8mas=; b=ogtWtL4WYOW8suAMIL2Nw9cPnkW6zN0LYlD7Cn3FtZ253P5E5vkd7S2ZQArvyoq3nd acbJ9E1opm/3wYG6SvXW4CFQKi1LHOXOu21YO8L6LD9rDJpZAkpxTsx8xqFW8dlZKTr+ x7eOCbwslpFBxRztqJWlOauKeAuA4p/cZspvsr90GS4qLMQVn7DWgO7w/q1aljflvLfr MhLEdhKA3KbZWCE126Jub6lHtyoRvyJ2vIfGIf6m7J+iu850JVoDwapSt4ApBET79rIg NisKd7Ibe0osq4J/KQg6QvhHjoq0wX6Vj0DekPvZX+YAY7zsaLawyIVYGgnWmRZmwt33 04xw== X-Gm-Message-State: AOAM530Wl3AhT6k99s5vVjHDj8Syf14X0s+wigUgM84u7yQ9C+VbC1B6 YMsXb3j5kCZVcMDmsYT3dF4= X-Google-Smtp-Source: ABdhPJzMyqDrlccGlrZjTkYB9avc7WfWGiiIvH2N7+xa6oX+t0dwLupW2e+1/RqMFKXpP4AxmXtK+Q== X-Received: by 2002:a17:902:a40b:b029:e0:1096:7fb with SMTP id p11-20020a170902a40bb02900e0109607fbmr1125710plq.40.1612321313502; Tue, 02 Feb 2021 19:01:53 -0800 (PST) Received: from localhost (60-242-11-44.static.tpgi.com.au. [60.242.11.44]) by smtp.gmail.com with ESMTPSA id 78sm322545pfx.127.2021.02.02.19.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 19:01:53 -0800 (PST) Date: Wed, 03 Feb 2021 13:01:47 +1000 From: Nicholas Piggin Subject: Re: [PATCH v12 01/14] ARM: mm: add missing pud_page define to 2-level page tables To: Russell King - ARM Linux admin Cc: Andrew Morton , Christophe Leroy , Ding Tianhong , Christoph Hellwig , Jonathan Cameron , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Rick Edgecombe References: <20210202110515.3575274-1-npiggin@gmail.com> <20210202110515.3575274-2-npiggin@gmail.com> <20210202111319.GL1463@shell.armlinux.org.uk> In-Reply-To: <20210202111319.GL1463@shell.armlinux.org.uk> MIME-Version: 1.0 Message-Id: <1612321006.e59gckigqu.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Excerpts from Russell King - ARM Linux admin's message of February 2, 2021 = 9:13 pm: > On Tue, Feb 02, 2021 at 09:05:02PM +1000, Nicholas Piggin wrote: >> diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtab= le.h >> index c02f24400369..d63a5bb6bd0c 100644 >> --- a/arch/arm/include/asm/pgtable.h >> +++ b/arch/arm/include/asm/pgtable.h >> @@ -166,6 +166,9 @@ extern struct page *empty_zero_page; >> =20 >> extern pgd_t swapper_pg_dir[PTRS_PER_PGD]; >> =20 >> +#define pud_page(pud) pmd_page(__pmd(pud_val(pud))) >> +#define pud_write(pud) pmd_write(__pmd(pud_val(pud))) >=20 > As there is no PUD, does it really make sense to return a valid > struct page (which will be the PTE page) for pud_page(), which is > several tables above? There is no PUD on 3-level either, and the pgtable-nopud.h which it uses=20 also passes down p4d_page to pud_page, so by convention... Although in this case at least for my next patch it won't acutally use=20 pud_page unless it's a leaf entry so maybe it shouldn't get called anyway. Thanks, Nick