From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56E93C43460 for ; Mon, 12 Apr 2021 08:47:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E52E761285 for ; Mon, 12 Apr 2021 08:47:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E52E761285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 552956B0036; Mon, 12 Apr 2021 04:47:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 529836B006C; Mon, 12 Apr 2021 04:47:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C9D16B006E; Mon, 12 Apr 2021 04:47:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 1C94C6B0036 for ; Mon, 12 Apr 2021 04:47:31 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C82CD173085F for ; Mon, 12 Apr 2021 08:47:30 +0000 (UTC) X-FDA: 78023086260.09.6812BF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 14BB2A00039B for ; Mon, 12 Apr 2021 08:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618217249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ZVzewdg79RzKFsnnpj3toO21U2g5cN2oMm8eONJYHY=; b=J8rsO5dXvzCFlWjwK5h0bjoSsjLBgovY9Oeb191zVNoScFbR0elUw2vPuawKm9yHrb7ODT qKIs7Lu7//7FfQSuLZc7LSGxcO1n2lfDeY+TjSgVTxceLAAqAxqOSZGtvSCRBPr5lLrisW 63vAitL7U+8fQ7t2pTwOMIjWGAcAIwM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-DWnKepheM6Sr3XO3lGg0Mw-1; Mon, 12 Apr 2021 04:47:28 -0400 X-MC-Unique: DWnKepheM6Sr3XO3lGg0Mw-1 Received: by mail-wm1-f70.google.com with SMTP id b20-20020a7bc2540000b029010f7732a35fso5838188wmj.1 for ; Mon, 12 Apr 2021 01:47:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=+ZVzewdg79RzKFsnnpj3toO21U2g5cN2oMm8eONJYHY=; b=j1+LRiRn/EelMmRupO+ZRt1SkUxYBtnjNLKYrczEVYLE/5HftBjb3m73iv5WR7RdE3 hR+XAhCW5vnN7Jo84rGBOncYj1eJ1ELdbNnu7RY978MF4y2GXAjf8oAzvq+dzpp7JkNi k8ZCyeToOS61XWper78FOouj4nIxHjtttoKBxJPw1JceW3E50iLHbDcZ5nf48UBXnIaH He6BuESQsaARpyGkQpMPCgzOaH4nxslCjbFA6hqYPVdyOzqS5rpAHDxRSlPnX53HO307 EIHEZLtdPvopEnBfxhO9wB8nCkU5iawXd2CfWVstKsSvZeSv6ldcdyWq5etKRzwOKTOm IsPg== X-Gm-Message-State: AOAM531RS5KfW0Ewq1EJu/7dmfbm/mEyCmfZt7Kx1/lfNlVZoayso66Y Acm79kmXJYc7toZjOGSHuoTwaygWFVv3u4eZSsLAAqFzxxfLDwv9GkfjFsU/McfY41Zga2Kcv8m G9WvgiAM25W0= X-Received: by 2002:a05:600c:4482:: with SMTP id e2mr619417wmo.121.1618217247180; Mon, 12 Apr 2021 01:47:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxx4EM0F3QJf++u7/wgOu5mPjOoaJFUsv/zcyrlmWMxAjz9nri7Al51/O7Rz2gFFz2XuY2fYQ== X-Received: by 2002:a05:600c:4482:: with SMTP id e2mr619402wmo.121.1618217246983; Mon, 12 Apr 2021 01:47:26 -0700 (PDT) Received: from [192.168.3.132] (p5b0c66cb.dip0.t-ipconnect.de. [91.12.102.203]) by smtp.gmail.com with ESMTPSA id g5sm15937930wrq.30.2021.04.12.01.47.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Apr 2021 01:47:26 -0700 (PDT) To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, "linuxppc-dev @ lists . ozlabs . org" , "linux-ia64@vger.kernel.org" , Vlastimil Babka , Michal Hocko , Mel Gorman References: <1618199302-29335-1-git-send-email-anshuman.khandual@arm.com> <09284b9a-cfe1-fc49-e1f6-3cf0c1b74c76@arm.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER Message-ID: <162877dd-e6ba-d465-d301-2956bb034429@redhat.com> Date: Mon, 12 Apr 2021 10:47:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <09284b9a-cfe1-fc49-e1f6-3cf0c1b74c76@arm.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 14BB2A00039B X-Stat-Signature: gtzroybn4535f4c6xqwygnxajet6h1jx Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618217244-788274 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.04.21 10:06, Anshuman Khandual wrote: > + linuxppc-dev@lists.ozlabs.org > + linux-ia64@vger.kernel.org >=20 > On 4/12/21 9:18 AM, Anshuman Khandual wrote: >> pageblock_order must always be less than MAX_ORDER, otherwise it might= lead >> to an warning during boot. A similar problem got fixed on arm64 platfo= rm >> with the commit 79cc2ed5a716 ("arm64/mm: Drop THP conditionality from >> FORCE_MAX_ZONEORDER"). Assert the above condition before HUGETLB_PAGE_= ORDER >> gets assigned as pageblock_order. This will help detect the problem ea= rlier >> on platforms where HUGETLB_PAGE_SIZE_VARIABLE is enabled. >> >> Cc: David Hildenbrand >> Cc: Andrew Morton >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual >> --- >> Changes in V2: >> >> - Changed WARN_ON() to BUILD_BUG_ON() per David >> >> Changes in V1: >> >> https://patchwork.kernel.org/project/linux-mm/patch/1617947717-2424-1-= git-send-email-anshuman.khandual@arm.com/ >> >> mm/page_alloc.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index cfc72873961d..19283bff4bec 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -6875,10 +6875,17 @@ void __init set_pageblock_order(void) >> if (pageblock_order) >> return; >> =20 >> - if (HPAGE_SHIFT > PAGE_SHIFT) >> + if (HPAGE_SHIFT > PAGE_SHIFT) { >> + /* >> + * pageblock_order must always be less than >> + * MAX_ORDER. So does HUGETLB_PAGE_ORDER if >> + * that is being assigned here. >> + */ >> + BUILD_BUG_ON(HUGETLB_PAGE_ORDER >=3D MAX_ORDER); >=20 > Unfortunately the build test fails on both the platforms (powerpc and i= a64) > which subscribe HUGETLB_PAGE_SIZE_VARIABLE and where this check would m= ake > sense. I some how overlooked the cross compile build failure that actua= lly > detected this problem. >=20 > But wondering why this assert is not holding true ? and how these platf= orms > do not see the warning during boot (or do they ?) at mm/vmscan.c:1092 l= ike > arm64 did. >=20 > static int __fragmentation_index(unsigned int order, struct contig_page= _info *info) > { > unsigned long requested =3D 1UL << order; >=20 > if (WARN_ON_ONCE(order >=3D MAX_ORDER)) > return 0; > .... >=20 > Can pageblock_order really exceed MAX_ORDER - 1 ? Ehm, for now I was under the impression that such configurations=20 wouldn't exist. And originally, HUGETLB_PAGE_SIZE_VARIABLE was introduced to handle=20 hugepage sizes that all *smaller* than MAX_ORDER - 1: See d9c234005227=20 ("Do not depend on MAX_ORDER when grouping pages by mobility") However, looking into init_cma_reserved_pageblock(): if (pageblock_order >=3D MAX_ORDER) { i =3D pageblock_nr_pages; ... } But it's kind of weird, isn't it? Let's assume we have MAX_ORDER - 1=20 correspond to 4 MiB and pageblock_order correspond to 8 MiB. Sure, we'd be grouping pages in 8 MiB chunks, however, we cannot even=20 allocate 8 MiB chunks via the buddy. So only alloc_contig_range() could=20 really grab them (IOW: gigantic pages). Further, we have code like deferred_free_range(), where we end up=20 calling __free_pages_core()->...->__free_one_page() with=20 pageblock_order. Wouldn't we end up setting the buddy order to something=20 > MAX_ORDER -1 on that path? Having pageblock_order > MAX_ORDER feels wrong and looks shaky. --=20 Thanks, David / dhildenb