From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 351F7C433EF for ; Tue, 26 Oct 2021 10:31:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C58B260EFE for ; Tue, 26 Oct 2021 10:31:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C58B260EFE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 04E17940008; Tue, 26 Oct 2021 06:31:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3FE3940007; Tue, 26 Oct 2021 06:31:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E06EE940008; Tue, 26 Oct 2021 06:31:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id CD0DF940007 for ; Tue, 26 Oct 2021 06:31:00 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 683678249980 for ; Tue, 26 Oct 2021 10:31:00 +0000 (UTC) X-FDA: 78738220680.36.568F4C6 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf07.hostedemail.com (Postfix) with ESMTP id E18C310004C4 for ; Tue, 26 Oct 2021 10:30:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7FF9E2195D; Tue, 26 Oct 2021 10:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1635244258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDeyQBV9DEd0tXGdD1qku14+9u4jb7PKJUH26QFG8DU=; b=cIfY3dnXPMscVImWyijSTbuMwtr/YCMjZw0IyDyoG4QR3wYLXRq5JGSTJKBTs8ufoBoxcB LN0NXPQWvcRfRQ1hrwSmo6WhIySYM5H9L6KR6pfjBPqiB2u1rWKYJp0WIR/6bqrYqwjuE7 nEmMDPZV2Nu2pRT7xGdDgJv297WGA70= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1635244258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WDeyQBV9DEd0tXGdD1qku14+9u4jb7PKJUH26QFG8DU=; b=3lUTKYQ6NxuOyMBjALvs/LScH2rgJneMYKzuxLMCCut4B0rZkFlz+yckRlHbfgJ2+hNwzo YJNaMcVClDDJPmDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A6AB13D43; Tue, 26 Oct 2021 10:30:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zbQ2Ft/Yd2GRFgAAMHmgww (envelope-from ); Tue, 26 Oct 2021 10:30:55 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 From: "NeilBrown" To: "Michal Hocko" Cc: linux-mm@kvack.org, "Dave Chinner" , "Andrew Morton" , "Christoph Hellwig" , "Uladzislau Rezki" , linux-fsdevel@vger.kernel.org, "LKML" , "Ilya Dryomov" , "Jeff Layton" Subject: Re: [PATCH 2/4] mm/vmalloc: add support for __GFP_NOFAIL In-reply-to: References: <20211025150223.13621-1-mhocko@kernel.org>, <20211025150223.13621-3-mhocko@kernel.org>, <163520277623.16092.15759069160856953654@noble.neil.brown.name>, Date: Tue, 26 Oct 2021 21:30:52 +1100 Message-id: <163524425265.8576.7853645770508739439@noble.neil.brown.name> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E18C310004C4 X-Stat-Signature: f5m7hzt7b3h65rasqrjtsqq5qcsyoxcy Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=cIfY3dnX; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3lUTKYQ6; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de X-HE-Tag: 1635244259-542355 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 26 Oct 2021, Michal Hocko wrote: > On Tue 26-10-21 09:59:36, Neil Brown wrote: > > On Tue, 26 Oct 2021, Michal Hocko wrote: > [...] > > > @@ -3032,6 +3036,10 @@ void *__vmalloc_node_range(unsigned long size, u= nsigned long align, > > > warn_alloc(gfp_mask, NULL, > > > "vmalloc error: size %lu, vm_struct allocation failed", > > > real_size); > > > + if (gfp_mask & __GFP_NOFAIL) { > > > + schedule_timeout_uninterruptible(1); > > > + goto again; > > > + } > >=20 > > Shouldn't the retry happen *before* the warning? >=20 > I've done it after to catch the "depleted or fragmented" vmalloc space. > This is not related to the memory available and therefore it won't be > handled by the oom killer. The error message shouldn't imply the vmalloc > allocation failure IMHO but I am open to suggestions. The word "failed" does seem to imply what you don't want it to imply... I guess it is reasonable to have this warning, but maybe add " -- retrying" if __GFP_NOFAIL. Thanks, NeilBrown