From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBF93C2D0A3 for ; Sun, 1 Nov 2020 17:48:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 271D8208A9 for ; Sun, 1 Nov 2020 17:48:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="cNDELfK3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 271D8208A9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F3E56B0074; Sun, 1 Nov 2020 12:48:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A40F6B007D; Sun, 1 Nov 2020 12:48:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8922D6B007E; Sun, 1 Nov 2020 12:48:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 5D89E6B0074 for ; Sun, 1 Nov 2020 12:48:51 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 007943626 for ; Sun, 1 Nov 2020 17:48:50 +0000 (UTC) X-FDA: 77436584862.05.earth23_3211ccd272a9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id D0FD41801781A for ; Sun, 1 Nov 2020 17:48:50 +0000 (UTC) X-HE-Tag: earth23_3211ccd272a9 X-Filterd-Recvd-Size: 3085 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Nov 2020 17:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=rHIUsRqrjkVztjUWi8Epx0pSoF2undlIvOpK0aQ9PcQ=; b=cNDELfK3gq95oiPePm7nSbAv1k Wl+Qr9avH+rXbIJ6p+Z90+8Sqt2LMeZvzbeY6quEy0MuFis5MPhbEA62qTxDtNsHe9xNUu1Ikf3H2 PLOt9PVea67kW3WtqgijmQglDRMK0YTkZLgKArDIbF+NFj2pU/bwFp/84ztd0bpZzzwkWCVacNog7 wdph9yQrkAN9rN7kH3WUBQFzC8L+z4nl2Yh1Mg4bDFAPzhZCTx1yVgZStEiu3ZKZqRiwmewC8P2Od jm/UXaKjLy5qPH02aVOrq0s8J4jHoRENlNF9bW8YfEGTvDe9b6iACuO8vwGI4olc9dx7YK1/RqkvK MrwzVaqA==; Received: from [2601:1c0:6280:3f0::371c] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZHT2-0002jC-Io; Sun, 01 Nov 2020 17:48:36 +0000 Subject: Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h To: Matthew Wilcox , Arvind Sankar Cc: kernel test robot , linux-next@vger.kernel.org, Stephen Rothwell , kbuild-all@lists.01.org, Linux Memory Management List , Nick Desaulniers , Kees Cook , Andrew Morton , stable@vger.kernel.org References: <202010312104.Dk9VQJYb-lkp@intel.com> <20201101173105.1723648-1-nivedita@alum.mit.edu> <20201101173835.GC27442@casper.infradead.org> From: Randy Dunlap Message-ID: <163c2869-8ea5-54a4-e146-951619294379@infradead.org> Date: Sun, 1 Nov 2020 09:48:30 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201101173835.GC27442@casper.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/1/20 9:38 AM, Matthew Wilcox wrote: > On Sun, Nov 01, 2020 at 12:31:05PM -0500, Arvind Sankar wrote: >> Commit >> b9de06783f01 ("compiler.h: fix barrier_data() on clang") >> moved the definition of barrier() into compiler.h. > > That's not a real commit ID. It only exists in linux-next and > will expire after a few weeks. > > The right way to fix a patch in Andrew's tree is to send an email > asking him to apply it as a -fix patch. As part of Andrew's submission > process, he folds all the -fix patches into the parent patch and it > shows up pristine in Linus' tree. > >> This causes build failures at least on alpha, because there are files >> that rely on barrier() being defined via the implicit include of >> compiler_types.h. > > That seems like a bug that should be fixed rather than reverting this > part of the patch? > maybe: ? https://lore.kernel.org/lkml/20201101030159.15858-1-rdunlap@infradead.org/ -- ~Randy