From: "NeilBrown" <neilb@suse.de>
To: "Matthew Wilcox" <willy@infradead.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Jeff Layton" <jlayton@kernel.org>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna.schumaker@netapp.com>,
linux-mm@kvack.org, linux-nfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] nfs: remove reliance on bdi congestion
Date: Tue, 01 Feb 2022 08:38:11 +1100 [thread overview]
Message-ID: <164366509142.18996.11029008051103064089@noble.neil.brown.name> (raw)
In-Reply-To: <YffhBYZ+6pgWeF71@casper.infradead.org>
On Tue, 01 Feb 2022, Matthew Wilcox wrote:
> On Mon, Jan 31, 2022 at 03:55:22PM +1100, NeilBrown wrote:
> > On Mon, 31 Jan 2022, Matthew Wilcox wrote:
> > > On Mon, Jan 31, 2022 at 03:03:53PM +1100, NeilBrown wrote:
> > > > - .writepage to return AOP_WRITEPAGE_ACTIVATE if WB_SYNC_NONE
> > > > and the flag is set.
> > >
> > > Is this actually useful? I ask because Dave Chinner believes
> > > the call to ->writepage in vmscan to be essentially unused.
> >
> > He would be wrong ... unless "essentially" means "mostly" rather than
> > "totally".
> > swap-out to NFS results in that ->writepage call.
>
> For writes, SWP_FS_OPS uses ->direct_IO, not ->writepage. Confused.
>
I shouldn't have mentioned NFS - that is an irrelevant distraction.
The "call to ->writepage in vmscan" is used, at least for swap.
For swapout it is the ->writepage from swap_aops, not the ->writepage of
any filesystem. This is swap_writepage(), and for SWP_FS_OPS that maps
to a ->direct_IO call.
Dave may well be right that the ->writepage in vmscan never calls
xfs_writepage or many others.
To get to the ->writepage of a filesystem it would need to be called
from kswapd. You would need to have no swap configured, and 90% of
memory consumed with anon pages so that the dirty_background_ratio
of 10% didn't kick off writeback. Then I would expect to kswapd to
write out to a filesystem before writeback would do it.
Nonetheless, without clear evidence to the contrary, I think it is
safest to add this test to the ->writepage function for any filesystem
which currently sets the bdi async congested flag.
Thanks,
NeilBrown
prev parent reply other threads:[~2022-01-31 21:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 4:03 [PATCH 0/3] remove dependence of inode_congested() NeilBrown
2022-01-31 4:03 ` [PATCH 1/3] fuse: remove reliance on bdi congestion NeilBrown
2022-01-31 4:28 ` Matthew Wilcox
2022-01-31 4:47 ` NeilBrown
2022-01-31 10:21 ` Miklos Szeredi
2022-01-31 13:12 ` Matthew Wilcox
2022-01-31 23:00 ` NeilBrown
2022-02-01 2:01 ` Matthew Wilcox
2022-02-01 3:28 ` NeilBrown
2022-02-01 4:06 ` Matthew Wilcox
2022-02-07 0:47 ` NeilBrown
2022-01-31 4:03 ` [PATCH 3/3] ceph: " NeilBrown
2022-01-31 4:03 ` [PATCH 2/3] nfs: " NeilBrown
2022-01-31 4:22 ` Matthew Wilcox
2022-01-31 4:55 ` NeilBrown
2022-01-31 13:15 ` Matthew Wilcox
2022-01-31 21:38 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164366509142.18996.11029008051103064089@noble.neil.brown.name \
--to=neilb@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@hammerspace.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).