From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B682C433F5 for ; Mon, 14 Feb 2022 23:50:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C42F6B0078; Mon, 14 Feb 2022 18:50:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 873AC6B007B; Mon, 14 Feb 2022 18:50:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73B026B007D; Mon, 14 Feb 2022 18:50:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 61F786B0078 for ; Mon, 14 Feb 2022 18:50:39 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 252EF8BED4 for ; Mon, 14 Feb 2022 23:50:39 +0000 (UTC) X-FDA: 79143032598.06.F0A6356 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id 81CD8140006 for ; Mon, 14 Feb 2022 23:50:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 03792210F5; Mon, 14 Feb 2022 23:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1644882637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qvPKjOh/wsUJqEQu+1yAdeggiSSJIk+3zVWtr119qmc=; b=MZKhM6baDXALJ8vMZRvkt0G/ule23iqk82N9aMTi4UY7j4EgQTr+czqmbaKwCj/YvSzYW9 0NqlSUIKeAr2COGHUE2sx6+4MXY77jrH3EEv6oyosIHgYgHgVi9YC+o+SDuxFyhb7RfRgU AQb380eSlEsyi6eU+84RGkWhP1+S6h4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1644882637; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qvPKjOh/wsUJqEQu+1yAdeggiSSJIk+3zVWtr119qmc=; b=q4XCtTO4Ndidxg058D+Zx3F0YQcH4twF3P/3VBgXGRGXeQ0YS4wrPnsb+7tj85xUBjPJF5 d+qoI2Skz5LzVPCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DAD1213B59; Mon, 14 Feb 2022 23:50:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 81zII8jqCmJ9MwAAMHmgww (envelope-from ); Mon, 14 Feb 2022 23:50:32 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 From: "NeilBrown" To: "Geert Uytterhoeven" Cc: "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Andrew Morton" , "Mark Hemment" , "Christoph Hellwig" , "David Howells" , "open list:NFS, SUNRPC, AND..." , "Linux MM" , "Linux Kernel Mailing List" Subject: Re: [PATCH 01/21] MM: create new mm/swap.h header file. In-reply-to: References: <164420889455.29374.17958998143835612560.stgit@noble.brown>, <164420916109.29374.8959231877111146366.stgit@noble.brown>, Date: Tue, 15 Feb 2022 10:50:26 +1100 Message-id: <164488262648.17471.2510331812560662090@noble.neil.brown.name> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 81CD8140006 X-Rspam-User: Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MZKhM6ba; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=q4XCtTO4; spf=pass (imf09.hostedemail.com: domain of neilb@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=neilb@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Stat-Signature: 5gefmq89pxzjbzef6fcoce9iqamfjooe X-HE-Tag: 1644882638-601668 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 11 Feb 2022, Geert Uytterhoeven wrote: > Hi Neil, > > On Wed, Feb 9, 2022 at 10:52 AM NeilBrown wrote: > > Many functions declared in include/linux/swap.h are only used within mm/ > > > > Create a new "mm/swap.h" and move some of these declarations there. > > Remove the redundant 'extern' from the function declarations. > > > > Reviewed-by: Christoph Hellwig > > Signed-off-by: NeilBrown > > Thanks for your patch! > > > --- /dev/null > > +++ b/mm/swap.h > > @@ -0,0 +1,129 @@ > > + > > scripts/checkpatch.pl: > WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 > > Gr{oetje,eeting}s, > > Geert Argg... I think you pointed that out previously and I forgot to act on it. I've now copied the SPDX line from linux/swap.h, and also added that standard "#ifndef _MM_SWAP_H" etc protection. Thanks, NeilBrown