From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0694BC433EF for ; Mon, 7 Mar 2022 22:04:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F7588D0002; Mon, 7 Mar 2022 17:04:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67F028D0001; Mon, 7 Mar 2022 17:04:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 520398D0002; Mon, 7 Mar 2022 17:04:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 3F6338D0001 for ; Mon, 7 Mar 2022 17:04:18 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 0AB2781743 for ; Mon, 7 Mar 2022 22:04:18 +0000 (UTC) X-FDA: 79218969396.12.39CD189 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id 563D010000B for ; Mon, 7 Mar 2022 22:04:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DCCEDB8172F; Mon, 7 Mar 2022 22:04:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D62BC340F4; Mon, 7 Mar 2022 22:04:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646690653; bh=tHzv3jXO/6WBy7nP3aIzA2cZjv9B8tpQxuj2TUQdmLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G8OoRzp4f0iPxFf6cm65htHnUT4HipPAgoKJr596kXYRr3tyJQonSF7NY/BY8occ1 XREVLo81Z0rHwht20zE4NO9kXuvvOs1PoHQDM8lwP1TFIn6NzIVLr28fQJ/U/5NYs4 JhD5z7THsdptDiRzwc79pQh1dB5RntXhWFIMy2xm1Mo240mTQE69msoQQYUuloQams Z2EcNSmGBUTj3belAl62BneBSyOGG8TINYXblE9gMOzOKpwLQhQe5WZhXN0JgTMMWp JyjCh29AO97eeDDEGJmG2YZgrO0alSb715c6X45MNti5mK1f/iEyb0dUO4dw7bhnN6 ooILn0O4zOq7Q== From: Will Deacon To: mike.kravetz@oracle.com, osalvador@suse.de, rientjes@google.com, mark.rutland@arm.com, Muchun Song , akpm@linux-foundation.org, james.morse@arm.com, bodeddub@amazon.com, david@redhat.com, catalin.marinas@arm.com, song.bao.hua@hisilicon.com Cc: kernel-team@android.com, Will Deacon , smuchun@gmail.com, linux-kernel@vger.kernel.org, duanxiongchun@bytedance.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, fam.zheng@bytedance.com Subject: Re: [PATCH v2 RESEND 1/2] arm64: avoid flushing icache multiple times on contiguous HugeTLB Date: Mon, 7 Mar 2022 22:03:36 +0000 Message-Id: <164668935493.3276132.12110588269320094587.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220302084624.33340-1-songmuchun@bytedance.com> References: <20220302084624.33340-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 563D010000B X-Stat-Signature: 9mjw5no5qtb3u1on1sfc54juxwjsuzjg Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=G8OoRzp4; spf=pass (imf14.hostedemail.com: domain of will@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-HE-Tag: 1646690656-798841 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Mar 2022 16:46:23 +0800, Muchun Song wrote: > When a contiguous HugeTLB page is mapped, set_pte_at() will be called > CONT_PTES/CONT_PMDS times. Therefore, __sync_icache_dcache() will > flush cache multiple times if the page is executable (to ensure > the I-D cache coherency). However, the first flushing cache already > covers subsequent cache flush operations. So only flusing cache > for the head page if it is a HugeTLB page to avoid redundant cache > flushing. In the next patch, it is also depends on this change > since the tail vmemmap pages of HugeTLB is mapped with read-only > meanning only head page struct can be modified. > > [...] Applied first patch only to arm64 (for-next/mm), thanks! [1/2] arm64: avoid flushing icache multiple times on contiguous HugeTLB https://git.kernel.org/arm64/c/cf5a501d985b Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev