From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A5C2C38145 for ; Thu, 8 Sep 2022 03:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0443C6B0072; Wed, 7 Sep 2022 23:14:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F361C8D0002; Wed, 7 Sep 2022 23:14:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E23E96B0074; Wed, 7 Sep 2022 23:14:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D4D466B0072 for ; Wed, 7 Sep 2022 23:14:32 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A7272120D36 for ; Thu, 8 Sep 2022 03:14:32 +0000 (UTC) X-FDA: 79887450384.28.0A1C7DA Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf19.hostedemail.com (Postfix) with ESMTP id 597FE1A0062 for ; Thu, 8 Sep 2022 03:14:32 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id n65-20020a17090a5ac700b001fbb4fad865so970341pji.1 for ; Wed, 07 Sep 2022 20:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=Lj2YfwNoO49u1JDvTZXx6+kIlpsbYxEjipNfytO+vCs=; b=nQEK5nC8oAw6xALpVaD7cWoOAlsvszdvZRYNlOlnIP6f8eCsh8ue+N//oqGvqbqHO5 JPoGwPd+LVd8tyB6El85eVRif2ySMJwKKMXgjjv6bXH6/tKgZaXPd7e/7upZICjeGhGl uBfXSj5FxyBTqiqllpHZjf4yr0Z+AlhunZ5hE1nG5Yqr/+IJWo2RrjdC8bkf7Rk1wuCn 9fRGaZMU0UdkDUe6ZyCRd8dRmZjMrwEH8kMoWOmGbu5fdFDrmWccstZwmtdiX99QbJFR cBpSX7IRtqKjBpGGxsFUzXMlCQbrbyfnmPFkkxucaKggPvRKs894sOxOUs9/AsdS7Wc8 qS+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=Lj2YfwNoO49u1JDvTZXx6+kIlpsbYxEjipNfytO+vCs=; b=e9IZWi+mbajglXtwEnzgvpMboxATNonK/xPWc3RTmPebR9cs6rDQK3l9deb8//PJ24 lHqD+ZXH/yKIp84jlnPs2yJMFqbFUeR2HZGYS7Zi3g4C1guP+xSvVPuzcID5nkBqTfeZ +xMjay/56uUWaiA++QVh7YnZ/9yCOzUKEkebiTcn5c/gZ6ubCgBbf7mtVDvObYZs+zjf L/nyEv5xpfJGuLCPdg1RUudK3zzpitQF+jAmfYanIeJpzFr1DcFFtU6IwmFae0GtjLv2 eF3mXBpHJaX2tkw6dC1vfRsGvhCuduAFgp/wH8uP56XOezT61yUekDLpk2Z/ECmLwbd2 snPQ== X-Gm-Message-State: ACgBeo2D4xhcbso1dnXiJKkpjzazcIBz8V732PzVAoD+CDx24xfheHMU J1NQlaZh4LoiAH1bKzpaFA== X-Google-Smtp-Source: AA6agR7YKcNoEQt92SgUbr5dFIFg3iQEjYDhmdzCFobfDa2+qKVtlIHdsY8Xn/4H7W0btC7I0h5FfA== X-Received: by 2002:a17:90a:b782:b0:1fd:bef9:d49 with SMTP id m2-20020a17090ab78200b001fdbef90d49mr1757702pjr.221.1662606871311; Wed, 07 Sep 2022 20:14:31 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id d13-20020a17090ae28d00b002008ba3a74csm457870pjz.52.2022.09.07.20.14.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Sep 2022 20:14:30 -0700 (PDT) From: xiakaixu1987@gmail.com X-Google-Original-From: kaixuxia@tencent.com To: sj@kernel.org, akpm@linux-foundation.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kaixu Xia Subject: [PATCH v2] mm/damon/vaddr: add a comment for 'default' case in damon_va_apply_scheme() Date: Thu, 8 Sep 2022 11:13:17 +0800 Message-Id: <1662606797-23534-1-git-send-email-kaixuxia@tencent.com> X-Mailer: git-send-email 1.8.3.1 ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662606872; a=rsa-sha256; cv=none; b=Lj/Gkqb27TEaG65dGEJNB5dgJdKJlw4uNcrdiSPV/8nzZQR+IVIFnudd5y0jQcJNZEwcAt 30hBhXRulOZA1yXa0+r866M5ln56xeMEbqQAVlWvqQiFPQMKxbzrM0+u+5i0gbLBJGm6xF DkdtSk38k1DLRrx9jjKHzppFo3ovxzg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nQEK5nC8; spf=pass (imf19.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662606872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references:dkim-signature; bh=Lj2YfwNoO49u1JDvTZXx6+kIlpsbYxEjipNfytO+vCs=; b=Ux7nBtR4f4FDbSqis0IgjWgjlsC6cjec7kfdxmxzUCONMr2ScAXdj5NuXGcdU1AH88n1s7 bNizc8Obhh4oXDsBqLJzQe8m7O1eprfEmbjo9DFX1hJ4S38qyZtInKsSo8oEpuoLwlxPmD VUX31BdqGE5846gwqKwM+QaSmHCvEHA= Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nQEK5nC8; spf=pass (imf19.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Queue-Id: 597FE1A0062 X-Rspamd-Server: rspam09 X-Stat-Signature: 6wj11arw3cnybhxnohb7a1enkjnx43f6 X-HE-Tag: 1662606872-660323 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Kaixu Xia The switch case 'DAMOS_STAT' and switch case 'default' have same return value in damon_va_apply_scheme(), and the 'default' case is for DAMOS actions that not supported by 'vaddr'. It might make sense to add a comment here. Signed-off-by: Kaixu Xia --- mm/damon/vaddr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c index 3c7b9d6dca95..3814200e61e4 100644 --- a/mm/damon/vaddr.c +++ b/mm/damon/vaddr.c @@ -646,6 +646,9 @@ static unsigned long damon_va_apply_scheme(struct damon_ctx *ctx, case DAMOS_STAT: return 0; default: + /* + * DAMOS actions that not yet supported by 'vaddr'. + */ return 0; } -- 2.27.0