From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043A6C63777 for ; Fri, 27 Nov 2020 01:56:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 696D7207BC for ; Fri, 27 Nov 2020 01:56:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 696D7207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6A5056B006E; Thu, 26 Nov 2020 20:56:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 655136B0070; Thu, 26 Nov 2020 20:56:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56B6D6B0071; Thu, 26 Nov 2020 20:56:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 3E6596B006E for ; Thu, 26 Nov 2020 20:56:14 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 02B911EE6 for ; Fri, 27 Nov 2020 01:56:14 +0000 (UTC) X-FDA: 77528533068.06.hair14_430801d27384 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id D978A1003C0C4 for ; Fri, 27 Nov 2020 01:56:13 +0000 (UTC) X-HE-Tag: hair14_430801d27384 X-Filterd-Recvd-Size: 3434 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Nov 2020 01:56:12 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R501e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UGdzEzw_1606442166; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UGdzEzw_1606442166) by smtp.aliyun-inc.com(127.0.0.1); Fri, 27 Nov 2020 09:56:07 +0800 Subject: Re: [PATCH next] mm/vmscan: __isolate_lru_page_prepare clean up To: Vlastimil Babka , Andrew Morton Cc: Matthew Wilcox , Hugh Dickins , Yu Zhao , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1605859413-53864-1-git-send-email-alex.shi@linux.alibaba.com> <20201120151307.4d9e3ef092ba01a325db7ce2@linux-foundation.org> <20201122123552.GF4327@casper.infradead.org> <728874d7-2d93-4049-68c1-dcc3b2d52ccd@linux.alibaba.com> <46ad053f-1401-31e8-50cf-09acda588f6f@suse.cz> <20201125154346.b2032c39cf3905bbebec3322@linux-foundation.org> <2ba66325-e3c8-d809-a8dd-85af77c3904b@suse.cz> From: Alex Shi Message-ID: <166d0496-a304-5005-e14d-1963389b558b@linux.alibaba.com> Date: Fri, 27 Nov 2020 09:56:06 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <2ba66325-e3c8-d809-a8dd-85af77c3904b@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2020/11/26 =E4=B8=8B=E5=8D=8811:23, Vlastimil Babka =E5=86=99=E9= =81=93: >>> >>> I tried that, and .text became significantly larger, for reasons whic= h >>> I didn't investigate ;) >=20 > I found out that comparing whole .text doesn't often work as changes mi= ght be lost in alignment, or > once in a while cross the alignment boundary and become exagerated. blo= at-o-meter works nice though. >=20 >> Uh, BTW, with the gcc 8.3.1 and centos 7, goto or continue version has= same size >> on my side with or w/o DEBUG_LIST. But actually, this clean up patch c= ould >> add 10 bytes also with or w/o DEDBUG_LIST. >> >> Maybe related with different compiler? >=20 > gcc (SUSE Linux) 10.2.1 20201117 [revision 98ba03ffe0b9f37b4916ce6238fa= d754e00d720b] >=20 > ./scripts/bloat-o-meter vmscan.o.before mm/vmscan.o > add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-1 (-1) > Function=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 old=C2=A0=C2=A0=C2=A0=C2=A0 new=C2=A0=C2=A0 delta > isolate_lru_pages=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 1125=C2=A0=C2=A0=C2=A0 1124=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 -1 > Total: Before=3D57283, After=3D57282, chg -0.00% >=20 > Not surprising, as I'd expect the compiler to figure out by itself that= list_move + continue > repeats and can be unified.=C2=A0 The reason for goto to stay would be = rather readability (subjective). Hi Vlastimil, Thanks for tool sharing! The gcc do give different. My data is read from 'size' tool and isolate_lru_pages text size from 'ob= jdump -d'. Maybe a same way like bloat-o-meter. :) Thanks Alex