From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A2FC2BBD4 for ; Fri, 18 Dec 2020 09:15:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B47F023A80 for ; Fri, 18 Dec 2020 09:15:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B47F023A80 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD4196B005D; Fri, 18 Dec 2020 04:15:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B84CC6B0068; Fri, 18 Dec 2020 04:15:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A732F6B006C; Fri, 18 Dec 2020 04:15:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 8D6706B005D for ; Fri, 18 Dec 2020 04:15:21 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 525D4BA13 for ; Fri, 18 Dec 2020 09:15:21 +0000 (UTC) X-FDA: 77605844442.16.crime39_0616a362743c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 30881100E5A5D for ; Fri, 18 Dec 2020 09:15:21 +0000 (UTC) X-HE-Tag: crime39_0616a362743c X-Filterd-Recvd-Size: 4333 Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Dec 2020 09:15:19 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.78,430,1599494400"; d="scan'208";a="102711642" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 18 Dec 2020 17:15:17 +0800 Received: from G08CNEXMBPEKD05.g08.fujitsu.local (unknown [10.167.33.204]) by cn.fujitsu.com (Postfix) with ESMTP id 61E5048990D2; Fri, 18 Dec 2020 17:15:15 +0800 (CST) Received: from irides.mr (10.167.225.141) by G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Dec 2020 17:15:15 +0800 Subject: Re: [RFC PATCH v3 0/9] fsdax: introduce fs query to support reflink To: "Darrick J. Wong" CC: Jane Chu , , , , , , , , , , , , , References: <20201215121414.253660-1-ruansy.fnst@cn.fujitsu.com> <7fc7ba7c-f138-4944-dcc7-ce4b3f097528@oracle.com> <20201218034907.GG6918@magnolia> From: Ruan Shiyang Message-ID: <16ac8000-2892-7491-26a0-84de4301f168@cn.fujitsu.com> Date: Fri, 18 Dec 2020 17:13:23 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201218034907.GG6918@magnolia> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US X-Originating-IP: [10.167.225.141] X-ClientProxiedBy: G08CNEXCHPEKD06.g08.fujitsu.local (10.167.33.205) To G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) X-yoursite-MailScanner-ID: 61E5048990D2.AA872 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@cn.fujitsu.com Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020/12/18 =E4=B8=8A=E5=8D=8811:49, Darrick J. Wong wrote: > On Fri, Dec 18, 2020 at 10:44:26AM +0800, Ruan Shiyang wrote: >> >> >> On 2020/12/17 =E4=B8=8A=E5=8D=884:55, Jane Chu wrote: >>> Hi, Shiyang, >>> >>> On 12/15/2020 4:14 AM, Shiyang Ruan wrote: >>>> The call trace is like this: >>>> memory_failure() >>>> =C2=A0 pgmap->ops->memory_failure()=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =3D= > pmem_pgmap_memory_failure() >>>> =C2=A0=C2=A0 gendisk->fops->corrupted_range() =3D> - pmem_corrupted= _range() >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 - md_blk_corrupted_range() >>>> =C2=A0=C2=A0=C2=A0 sb->s_ops->currupted_range()=C2=A0=C2=A0=C2=A0 =3D= > xfs_fs_corrupted_range() >>>> =C2=A0=C2=A0=C2=A0=C2=A0 xfs_rmap_query_range() >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 xfs_currupt_helper() >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * corrupted on metadata >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 try to= recover data, call xfs_force_shutdown() >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * corrupted on file data >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 try to= recover data, call mf_dax_mapping_kill_procs() >>>> >>>> The fsdax & reflink support for XFS is not contained in this patchse= t. >>>> >>>> (Rebased on v5.10) >>> >>> So I tried the patchset with pmem error injection, the SIGBUS payload >>> does not look right - >>> >>> ** SIGBUS(7): ** >>> ** si_addr(0x(nil)), si_lsb(0xC), si_code(0x4, BUS_MCEERR_AR) ** >>> >>> I expect the payload looks like >>> >>> ** si_addr(0x7f3672e00000), si_lsb(0x15), si_code(0x4, BUS_MCEERR_AR)= ** >> >> Thanks for testing. I test the SIGBUS by writing a program which call= s >> madvise(... ,MADV_HWPOISON) to inject memory-failure. It just shows t= hat >> the program is killed by SIGBUS. I cannot get any detail from it. So= , >> could you please show me the right way(test tools) to test it? >=20 > I'm assuming that Jane is using a program that calls sigaction to > install a SIGBUS handler, and dumps the entire siginfo_t structure > whenever it receives one... OK. Let me try it and figure out what's wrong in it. -- Thanks, Ruan Shiyang. >=20 > --D >=20 >> >> -- >> Thanks, >> Ruan Shiyang. >> >>> >>> thanks, >>> -jane >>> >>> >>> >>> >>> >>> >> >> >=20 >=20