From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F72C43603 for ; Thu, 5 Dec 2019 18:11:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E00B24249 for ; Thu, 5 Dec 2019 18:11:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="lFMXFtEc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E00B24249 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B40F96B117E; Thu, 5 Dec 2019 13:11:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC9E16B117F; Thu, 5 Dec 2019 13:11:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 992286B1180; Thu, 5 Dec 2019 13:11:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 7EE6D6B117E for ; Thu, 5 Dec 2019 13:11:55 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 3606B180AD807 for ; Thu, 5 Dec 2019 18:11:55 +0000 (UTC) X-FDA: 76231881390.04.crime31_4aec242d3b724 X-HE-Tag: crime31_4aec242d3b724 X-Filterd-Recvd-Size: 3793 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 18:11:54 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id j5so4384096qtq.9 for ; Thu, 05 Dec 2019 10:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=giazvTsGDVrAkD0F11ztp2e1h3nTDeaUJG0efXt9Qrs=; b=lFMXFtEcWUl3vJMrunz+yvhUAHmdxhRsKYC0p7Ww0hm9AofnOkELBIELu3Y54o+WBW novXm1JEjC85nkqN6PL53QjDNkdrPwCN36KDxMm+6zGCn8/oq0+btL8PR972iASQLSq2 OSIUYWIvaSUXx5OcYje2nqq6KTSyBnjhr+jeeXyzkwNzIjgUpYOhR5OUvIPgj8xhODnd ih1iXWDSE7ssl9uKceGzrbcY5aEwHaVd2j5OfgxkzP+6qS1Jq8uXjdH9W471R/yLTybl UXlPvsTwbuFRbCoH7k3IiOR/tBOzGBCW9oSHaukPeSItSueq3tqES/4Jx+Au4j+MBIzX ykxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=giazvTsGDVrAkD0F11ztp2e1h3nTDeaUJG0efXt9Qrs=; b=EXJIKbENNupfzc724QcXQ7BSRD9+kqE2CFGgIZofFN+mo5ES5XFwwgg+odVUk1HO2I Zhj4bxEvAA8s8cx2t46Fzsnbvt97IMrNOiTXAcbmhdh5QM/SAs432pejnfDTkTBQJhcc aw3Qar8PCHMNHgct6VNDBToMdTwoI1qE5B0bhaE7WYt0ZsU5Oq273QRvBbgH33IcTB5L PsWyIv+KUkQ3iLlXW8xDPLATvr60EpXuiWvjwMIyB6PZ87o29xx6hdaGs7DkfVVTSPbE xfrquNN8qg+SUbQeYTDmRTRJVKD8z/A98GxAEakpj2DIoYEp2LvzRKXwW7VT9TSWV63q 9bpA== X-Gm-Message-State: APjAAAXqQ0Y/uRTyXBzKb+oM5+osvnD/gXySsATfzsAV5UxzAu6spxAL d0IpsfrdOlyAOrbQ1W40XMGsPQ== X-Google-Smtp-Source: APXvYqyAWzrAYSXDcjIG4gMKpsUjXiPIN5Oj6sKdEq19PPy08baLSSvxwi0IrUd/1m+F1gSsOAOZNQ== X-Received: by 2002:aed:2805:: with SMTP id r5mr8778816qtd.335.1575569513941; Thu, 05 Dec 2019 10:11:53 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id u12sm5589261qta.79.2019.12.05.10.11.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2019 10:11:52 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [v2 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node Date: Thu, 5 Dec 2019 13:11:51 -0500 Message-Id: <1707CDD0-E05E-411A-A093-35E8E50ACA4B@lca.pw> References: Cc: fabecassis@nvidia.com, jhubbard@nvidia.com, mhocko@suse.com, cl@linux.com, vbabka@suse.cz, mgorman@techsingularity.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org In-Reply-To: To: Yang Shi X-Mailer: iPhone Mail (17B111) X-Bogosity: Ham, tests=bogofilter, spamicity=0.011585, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 5, 2019, at 12:39 PM, Yang Shi wrote: >=20 > There are definitely a few inconsistencies, but I think the manpage is qui= te clear for this specific case, which says "status is an array of integers t= hat return the status of each page. The array contains valid values only if m= ove_pages() did not return an error." And, it looks kernel just misbehaved s= ince 4.17 due to the fixes commit, so it sounds like a regression too. =E2=80=9COnly if=E2=80=9D in strictly logical term does not necessarily mea= n it must contain valid values if move_pages() succeed.=