From: linmiaohe <linmiaohe@huawei.com>
To: Michal Hocko <mhocko@suse.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hannes@cmpxchg.org" <hannes@cmpxchg.org>,
"vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: eliminate redundant check in __mem_cgroup_insert_exceeded()
Date: Sat, 10 Oct 2020 01:58:23 +0000 [thread overview]
Message-ID: <176a5eb5a80d40fdb3fe6e4f460fee08@huawei.com> (raw)
Michal Hocko <mhocko@suse.com> wrote:
> On Fri 09-10-20 09:51:04, Miaohe Lin wrote:
>> The mz->usage_in_excess >= mz_node->usage_in_excess check is exactly
>> the else case of mz->usage_in_excess < mz_node->usage_in_excess. So we
>> could replace else if (mz->usage_in_excess >=
>> mz_node->usage_in_excess) with else equally.
>>
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
>Acked-by: Michal Hocko <mhocko@suse.com>
>
>I believe this is a result of a very unreadable code. Resp. the comment makes it hard to follow. It would be slightly better to simply drop the comment which doesn't really explain much IMHO.
>
Agree. Will do it in v2. Many thanks.
next reply other threads:[~2020-10-10 1:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 1:58 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-10-09 13:51 [PATCH] mm: memcontrol: eliminate redundant check in __mem_cgroup_insert_exceeded() Miaohe Lin
2020-10-09 15:12 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176a5eb5a80d40fdb3fe6e4f460fee08@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).