From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F88DC4338F for ; Tue, 10 Aug 2021 15:33:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C6C960EBD for ; Tue, 10 Aug 2021 15:33:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C6C960EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A5C5B6B007E; Tue, 10 Aug 2021 11:33:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0C0A6B0080; Tue, 10 Aug 2021 11:33:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FA8C8D0001; Tue, 10 Aug 2021 11:33:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0160.hostedemail.com [216.40.44.160]) by kanga.kvack.org (Postfix) with ESMTP id 73ADB6B007E for ; Tue, 10 Aug 2021 11:33:05 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0399022BEC for ; Tue, 10 Aug 2021 15:33:05 +0000 (UTC) X-FDA: 78459564330.16.6491EB0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 4608D300185D for ; Tue, 10 Aug 2021 15:33:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628609582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zkbo7tVPU5rdtYR09GqUwrCkfbSUVb255s4YcI/Pzm8=; b=IO+sOb9KOA86MKY1EU/2dN4OtIpfBZ5f9TtERD5r8CxBkJDUXeyYAP8G5WGi00lF5y2Up9 zd/4xkhW6cwKHLgiyj0PBB/8V171suxEAX0/Nf/Tx43R2b/zNQWP5SveDWmQxoWAG4iV3C 9aLh0UHrR5kP65nY2dpY/JnzJJukzqQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-P6aQ7iMBMGS_FvCHulTrXg-1; Tue, 10 Aug 2021 11:33:01 -0400 X-MC-Unique: P6aQ7iMBMGS_FvCHulTrXg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26359802C88; Tue, 10 Aug 2021 15:33:00 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4CB3A5C25A; Tue, 10 Aug 2021 15:32:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-20-willy@infradead.org> References: <20210715033704.692967-20-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , Vlastimil Babka , William Kucharski Subject: Re: [PATCH v14 019/138] mm/filemap: Add folio_lock_killable() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1796350.1628609577.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 16:32:57 +0100 Message-ID: <1796351.1628609577@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4608D300185D Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IO+sOb9K; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf08.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: j5r6fjp8m8npz1qfdguuqtnr36tn4n97 X-HE-Tag: 1628609583-167277 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > This is like lock_page_killable() but for use by callers who > know they have a folio. Convert __lock_page_killable() to be > __folio_lock_killable(). This saves one call to compound_head() per > contended call to lock_page_killable(). > > __folio_lock_killable() is 19 bytes smaller than __lock_page_killable() > was. filemap_fault() shrinks by 74 bytes and __lock_page_or_retry() > shrinks by 71 bytes. That's a total of 164 bytes of text saved. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski Reviewed-by: David Howells