From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A69F2C4338F for ; Tue, 10 Aug 2021 15:35:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4DD4961052 for ; Tue, 10 Aug 2021 15:35:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4DD4961052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B6C776B0081; Tue, 10 Aug 2021 11:35:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1ABD6B0082; Tue, 10 Aug 2021 11:35:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A307E6B0083; Tue, 10 Aug 2021 11:35:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 8CD326B0081 for ; Tue, 10 Aug 2021 11:35:01 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 27CCA1C967 for ; Tue, 10 Aug 2021 15:35:01 +0000 (UTC) X-FDA: 78459569202.40.99D30E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf08.hostedemail.com (Postfix) with ESMTP id C70EE3001856 for ; Tue, 10 Aug 2021 15:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628609700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RQ/0SiinduV3LbfrDNpCgNc852w6KVFq2vg6uA6nZMY=; b=Yf9TrbDYCGn+S1P5QJb6bv5YgCdGfhmeSX7i2Bgbzfd+HBOiWuTDbXJfGGmor3w3ok8/vj 3fJVN1aO+pSsE72toaa0JsYBLLcMlAq7Wtda6dHrix5UFYXFiFePB2Z8J7LJY+V6lmsle7 6Y8ViI/OI7wGe+tiyI99t/0czfNO18Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-SQn8TOELMhaaUUu2SlN4DQ-1; Tue, 10 Aug 2021 11:34:59 -0400 X-MC-Unique: SQn8TOELMhaaUUu2SlN4DQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 677571026200; Tue, 10 Aug 2021 15:34:57 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8386620DE; Tue, 10 Aug 2021 15:34:55 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-23-willy@infradead.org> References: <20210715033704.692967-23-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jeff Layton , "Kirill A . Shutemov" , William Kucharski Subject: Re: [PATCH v14 022/138] mm/filemap: Add __folio_lock_or_retry() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1796456.1628609695.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 16:34:55 +0100 Message-ID: <1796457.1628609695@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C70EE3001856 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Yf9TrbDY; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf08.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: zs97qyxwqgtqbyfdzp7hi1s35wtq76ii X-HE-Tag: 1628609700-505924 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Convert __lock_page_or_retry() to __folio_lock_or_retry(). This actually > saves 4 bytes in the only caller of lock_page_or_retry() (due to better > register allocation) and saves the 14 byte cost of calling page_folio() > in __folio_lock_or_retry() for a total saving of 18 bytes. Also use > a bool for the return type. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > Acked-by: Jeff Layton > Acked-by: Kirill A. Shutemov > Reviewed-by: William Kucharski Reviewed-by: David Howells