From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A351C4338F for ; Tue, 10 Aug 2021 15:39:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14DFC60462 for ; Tue, 10 Aug 2021 15:39:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14DFC60462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 6F9066B008C; Tue, 10 Aug 2021 11:39:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AA238D0001; Tue, 10 Aug 2021 11:39:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 598016B0093; Tue, 10 Aug 2021 11:39:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 3C78F6B008C for ; Tue, 10 Aug 2021 11:39:11 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id CE6CB18077B3F for ; Tue, 10 Aug 2021 15:39:10 +0000 (UTC) X-FDA: 78459579660.33.1E86BE8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 7EA5B200281C for ; Tue, 10 Aug 2021 15:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628609949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/XX2NCopgWUN1ynp8Zyld+km/JWS/skjUysosbsfUW0=; b=ZhSfFHfwhGsBYucKC4mV2tDc7zHjldqTR8yprjZTDRK62YSPbSEFytS7kJALBm4SZRizD4 lxnIxjz8Es76c7EGfN8FioRs1ruM4CIclxc/vKPRTYrqiFhHvCq/YKj3Wcg4wzLjaCc65z 80GZwtRnO4WXPfQ3/5Nk1ZlVpgA96jg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-485-WpF4DkhwP-mSxhE2UWd9_A-1; Tue, 10 Aug 2021 11:39:08 -0400 X-MC-Unique: WpF4DkhwP-mSxhE2UWd9_A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2D4591008064; Tue, 10 Aug 2021 15:39:07 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0C76136F5; Tue, 10 Aug 2021 15:39:05 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-32-willy@infradead.org> References: <20210715033704.692967-32-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig , "Kirill A . Shutemov" Subject: Re: [PATCH v14 031/138] fs/netfs: Add folio fscache functions MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1796697.1628609944.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 16:39:04 +0100 Message-ID: <1796698.1628609944@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7EA5B200281C Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZhSfFHfw; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: rytao7mxj8u4n7qx4xog943fq6qqinze X-HE-Tag: 1628609950-659450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Match the page writeback functions by adding > folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and > folio_wait_fscache_killable(). Remove set_page_private_2(). Also rewrite > the kernel-doc to describe when to use the function rather than what the > function does, and include the kernel-doc in the appropriate rst file. > Saves 31 bytes of text in netfs_rreq_unlock() due to set_page_fscache() > calling page_folio() once instead of three times. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig > Acked-by: Kirill A. Shutemov Assuming you fixed the kernel test robot report: Reviewed-by: David Howells