From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01374C4338F for ; Tue, 10 Aug 2021 20:42:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8E68B61008 for ; Tue, 10 Aug 2021 20:42:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8E68B61008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BE78E6B0071; Tue, 10 Aug 2021 16:42:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B71316B0072; Tue, 10 Aug 2021 16:42:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A125D8D0001; Tue, 10 Aug 2021 16:42:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id 8712B6B0071 for ; Tue, 10 Aug 2021 16:42:21 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3066818369443 for ; Tue, 10 Aug 2021 20:42:21 +0000 (UTC) X-FDA: 78460343682.33.8E83C1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id D6B14D024BD2 for ; Tue, 10 Aug 2021 20:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628628140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=++wkOjMEpIZk1UaKIXWLectFjgawTsU5Dv9e7nL8sMw=; b=YKtbzcH/oaFXRCwH9WDWcHK+0PEW9HsFQ9ggyJXkYQtiSYrsGjryPGJXYVaBP5VAhv9pwA IiU4d74TcALqYzMqRClCmvZJ0NFt5vBRioG3fz5aJ+hP2SNBl5o9X42OuErKaTgH5c1UHi prubz61SOr5hgrdwq+jBcJTBpTKfi0I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-OpMXW8FxO3ygC_RBe5wxOA-1; Tue, 10 Aug 2021 16:42:19 -0400 X-MC-Unique: OpMXW8FxO3ygC_RBe5wxOA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 074CB1008062; Tue, 10 Aug 2021 20:42:18 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C29A2B0B3; Tue, 10 Aug 2021 20:42:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-53-willy@infradead.org> References: <20210715033704.692967-53-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 052/138] mm: Add folio_raw_mapping() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1811269.1628628133.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 21:42:13 +0100 Message-ID: <1811270.1628628133@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="YKtbzcH/"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of dhowells@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=dhowells@redhat.com X-Stat-Signature: 1b95p8j3jex5qazxq5gyrnrfddpb593n X-Rspamd-Queue-Id: D6B14D024BD2 X-Rspamd-Server: rspam01 X-HE-Tag: 1628628140-26876 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox (Oracle) wrote: > Convert __page_rmapping to folio_raw_mapping and move it to mm/internal.h. > It's only a couple of instructions (load and mask), so it's definitely > going to be cheaper to inline it than call it. Leave page_rmapping > out of line. > > Signed-off-by: Matthew Wilcox (Oracle) I assume you're going to call it from another source file at some point, otherwise this is unnecessary. Apart from that, Reviewed-by: David Howells